Page MenuHomePhabricator

Multiple: undefined index in SpecialContributions.php on line 203
Closed, ResolvedPublic

Description

Notice: Undefined index: start in /srv/mediawiki/php-1.30.0-wmf.12/includes/specials/SpecialContributions.php on line 202
Notice: Undefined index: end in /srv/mediawiki/php-1.30.0-wmf.12/includes/specials/SpecialContributions.php on line 203

Event Timeline

mmodell created this task.Aug 3 2017, 7:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2017, 7:28 PM
SBisson added a subscriber: SBisson.Aug 3 2017, 8:54 PM

Any chance that can be related to the previous blocker about how wikibase inserts RC records? T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.

Is there also a trace in the logs so we know who's calling?

Krinkle added a subscriber: Krinkle.Aug 3 2017, 9:10 PM

Relevant code (from current version of wmf.12):

https://github.com/wikimedia/mediawiki/blob/8e7900b115/includes/specials/SpecialContributions.php#L132-L204
It seems like the $skip case would naturally have start and end undefined. The code doesn't appear to have changed recently, but perhaps a particular call pattern has become more common with the introduction of ORES and date filters?

Mattflaschen-WMF added a comment.EditedAug 3 2017, 9:12 PM

I don't think so. Special:Contributions doesn't use the recentchanges table.

I don't think this is related to the Collaboration team, or a recent regression, but it's worth fixing. It looks to be from rMWb66888733c18: Use PHP DateInputWidget in Contribs and use for range filtering

This comment was removed by Krinkle.

Change 370097 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/core@master] Special:Contribs: Ensure 'start' and 'end' are never undefined

https://gerrit.wikimedia.org/r/370097

Change 370097 merged by jenkins-bot:
[mediawiki/core@master] Special:Contribs: Ensure 'start' and 'end' are never undefined

https://gerrit.wikimedia.org/r/370097

Change 370142 had a related patch set uploaded (by Krinkle; owner: Mattflaschen):
[mediawiki/core@wmf/1.30.0-wmf.12] Special:Contribs: Ensure 'start' and 'end' are never undefined

https://gerrit.wikimedia.org/r/370142

Change 370142 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.12] Special:Contribs: Ensure 'start' and 'end' are never undefined

https://gerrit.wikimedia.org/r/370142

Krinkle closed this task as Resolved.Aug 5 2017, 10:33 PM