php-1.30.0-wmf.12/extensions/Wikidata/extensions/Wikibase/client/includes/Changes/InjectRCRecordsJob.php
Description
Description
Details
Details
Customize query in gerrit
Revisions and Commits
Revisions and Commits
| rEWBA extension-Wikibase | |||
| rEWBA11aad9d2dbc8 Hot fix for InjectRCRecordsJob: disable coalescing | |||
| rEWBA2987fe5bcf62 Move injection of RC records to a separate job. | |||
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | daniel | T171877 Update grafana dashboard for WikiPageUpdater to use new statsd keys | |||
| Resolved | aaron | T175897 Audit and improve JobQueue stability and performance (2017) | |||
| Resolved | Release | thcipriani | T170632 1.30.0-wmf.14 deployment blockers | ||
| Resolved | daniel | T164173 Cache invalidations coming from the JobQueue are causing lag on several wikis | |||
| Resolved | PRODUCTION ERROR | None | T171370 ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope" | ||
| Resolved | PRODUCTION ERROR | daniel | T172320 Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set. | ||
| Resolved | daniel | T172394 InjectRCRecordsJob: include the serialize EntityChange object in the job spec |
Event Timeline
Comment Actions
Comment Actions
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2017-08-02T19:50:05Z] <twentyafterfour@tin> rebuilt wikiversions.php and synchronized wikiversions files: group1 wikis to 1.30.0-wmf.11 refs T168053 - rollback due to T172320
Comment Actions
Reason: the new job tried to load the Change object based on the change ID. This fails if the Change object was a "virtual" change created by ChangeRunCoalescer::mergeChanges.
Solution: serialize the merged change instead of the id, or give a list of all IDs in the merged Change, and load and merge again while executing the job.
Effect: no RC rows get inserted for "mergeable" runs of wikidata edits.
Fun fact: $params['change'] is defined, it's just null.
This was not caught in testing because coalesced runs are relatively rare. The exist to reduce spam on the RC board.
I see no good way for a hot fix, sorry. I'll look into this first thing tomorrow.
Comment Actions
Change 369846 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/Wikibase@master] Hot fix for InjectRCRecordsJob: disable coalescing
Comment Actions
Change 369846 abandoned by Daniel Kinzler:
Hot fix for InjectRCRecordsJob: disable coalescing
Comment Actions
Change 369847 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/Wikibase@wmf/1.30.0-wmf.12] Hot fix for InjectRCRecordsJob: disable coalescing
Comment Actions
Change 369847 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.30.0-wmf.12] Hot fix for InjectRCRecordsJob: disable coalescing
Comment Actions
After rolling forward with wmf.12 I saw this error showing up again. Apparently the hotfix didn't work?
Comment Actions
Change 370006 had a related patch set uploaded (by 20after4; owner: 20after4):
[mediawiki/core@wmf/1.30.0-wmf.12] Revert Wikidata to wmf.10
Comment Actions
Change 370007 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] All wikis except wikidata to wmf.12, wikidata to wmf.11
Comment Actions
Change 370007 merged by jenkins-bot:
[operations/mediawiki-config@master] All wikis except wikidata to wmf.12, wikidata to wmf.11
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2017-08-03T20:29:37Z] <twentyafterfour@tin> rebuilt wikiversions.php and synchronized wikiversions files: all wikis except wikidata to 1.30.0-wmf.12, leaving wikidata behind due to T172320
Comment Actions
AFAIK this bug should be fixed by https://gerrit.wikimedia.org/r/#/c/369881 (T172394)
Comment Actions
Just to be clear: it looks like there are fixes for this in wikibase master that made it into wikidata wmf.14 which made the branch cut for core wmf.14, so this shouldn't block wmf.14 train going to group1. This is the assumption I will be working under when I run the train in an hour or so.