Page MenuHomePhabricator

InjectRCRecordsJob: include the serialize EntityChange object in the job spec
Closed, ResolvedPublic

Description

The job spec returned InjectRCRecordsJob::makeJobSpecification currently uses the Change ID to represent the EntityChange object. This fails badly for changes that have been constructed by merging multiple other changes by the ChangeRunCoalescer, causing T172320.

Instead of putting the Change's ID into the job spec, we should instead JSON-serialize the entire EntityChange object into the job spec.

Event Timeline

daniel created this task.Aug 3 2017, 2:19 PM

Change 369881 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix handling of coalesced changes in InjectRCRecordsJob

https://gerrit.wikimedia.org/r/369881

Change 370915 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove unused code snippets from EntityChangeFactory and related

https://gerrit.wikimedia.org/r/370915

Just to be clear: it looks like there are fixes for this in wikibase master that made it into wikidata wmf.14 which made the branch cut for core wmf.14, so this shouldn't block wmf.14 train going to group1. This is the assumption I will be working under when I run the train in an hour or so.

Ladsgroup closed this task as Resolved.Aug 18 2017, 9:04 AM
Ladsgroup moved this task from Proposed to Done on the Wikidata-Former-Sprint-Board board.

Change 370915 abandoned by Krinkle:
Remove unused code snippets from EntityChangeFactory and related

Reason:
Looks like these imports have already been removed and/or changed significantly in other commits since.

https://gerrit.wikimedia.org/r/370915

Change 370915 restored by Thiemo Mättig (WMDE):
Remove unused code snippets from EntityChangeFactory and related

Reason:
I don't understand. This is not about unused imports. I'm currently trying to rebase this, and it's quite simple.

https://gerrit.wikimedia.org/r/370915

Change 370915 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix minor control flow and doc issues in EntityChangeFactory and related

https://gerrit.wikimedia.org/r/370915