The job spec returned InjectRCRecordsJob::makeJobSpecification currently uses the Change ID to represent the EntityChange object. This fails badly for changes that have been constructed by merging multiple other changes by the ChangeRunCoalescer, causing T172320.
Instead of putting the Change's ID into the job spec, we should instead JSON-serialize the entire EntityChange object into the job spec.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | daniel | T171877 Update grafana dashboard for WikiPageUpdater to use new statsd keys | |||
| Resolved | aaron | T175897 Audit and improve JobQueue stability and performance (2017) | |||
| Resolved | Release | thcipriani | T170632 1.30.0-wmf.14 deployment blockers | ||
| Resolved | daniel | T164173 Cache invalidations coming from the JobQueue are causing lag on several wikis | |||
| Resolved | PRODUCTION ERROR | None | T171370 ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope" | ||
| Resolved | PRODUCTION ERROR | daniel | T172320 Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set. | ||
| Resolved | daniel | T172394 InjectRCRecordsJob: include the serialize EntityChange object in the job spec |
Change 369881 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix handling of coalesced changes in InjectRCRecordsJob
Change 370915 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove unused code snippets from EntityChangeFactory and related
Just to be clear: it looks like there are fixes for this in wikibase master that made it into wikidata wmf.14 which made the branch cut for core wmf.14, so this shouldn't block wmf.14 train going to group1. This is the assumption I will be working under when I run the train in an hour or so.
Change 370915 abandoned by Krinkle:
Remove unused code snippets from EntityChangeFactory and related
Reason:
Looks like these imports have already been removed and/or changed significantly in other commits since.
Change 370915 restored by Thiemo Mättig (WMDE):
Remove unused code snippets from EntityChangeFactory and related
Reason:
I don't understand. This is not about unused imports. I'm currently trying to rebase this, and it's quite simple.
Change 370915 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix minor control flow and doc issues in EntityChangeFactory and related