Now that we are recording profiling data for AbuseFilter, we should build some kind of visualization for that data.
To do:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T166802 Epic ⚡️ AbuseFilter performance management improvements | |||
| Resolved | dmaza | T161059 Measure AbuseFilter runtime | |||
| Resolved | dmaza | T174204 Build graph/dashboard for AbuseFilter profiling data |
https://grafana.wikimedia.org/dashboard/db/mediawiki-abuse-filter-runtime?orgId=1
We'll also want to add some sort of visualization for T174205: Log cases where abusefilter filters take over a certain amount of time to run.
@kaldari , @dmaza , @MaxSem — what else would be useful to display on this dashboard?
Mean time is meaningless, I'd rather see p75, p90 and p99. I've made some changes, please check out.
Looks good to me. I have no experience with Grafana but I think that's about all we can get from these data. Maybe adding a line for conditions.lower?
Split into two graphs:
Replicate these two graphs for all wikis with this performance measurement
Rename the dashboard to AbuseFilter profiling
Here it is, https://grafana.wikimedia.org/dashboard/db/mediawiki-abusefilter-profiling?orgId=1
We can probably remove Test Wiki and MediaWiki since it doesn't provide any useful information and add instead other high traffic wikis.
Looks great! A lot easier to read. I think we can leave test and MediaWiki — there's really no harm and they're at the bottom of the page so they're not in the way.
Does this need code review, or just visual review?