Page MenuHomePhabricator

Focus outline around watch star extends to left
Closed, ResolvedPublic


When I focus the watch star in Firefox, the outline extends to the left:

It should only enclose the star instead.

Event Timeline

Agh, looks like it's related to the removal of the message in order to make an icon-only toggle...

Maybe using an <input type="button">/<input type="checkbox"> and a <label> with the message? It certainly resolves this issue while maintaining accessibility, but it can be tricky to implement without causing visual difference.

Change 530705 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Prevent icon label overflow in focus state

Change 530705 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Prevent icon label overflow in focus state

Isarra claimed this task.

Hopefully the fix doesn't cause any other problems.

When will it land in production with the new bugs? ;) (Seriously, when?)

I dunno, next week? I expect the bugs will be eminently noticeable, though.