Page MenuHomePhabricator
Create Task
Maniphest T174429

[Task] Update data-values dependencies
Closed, ResolvedPublic
Actions

Description

wikibase/wikibase depends on data-values/common ^0.4.0, but its dependencies

  • data-values/geo released on 9 Aug
  • data-values/number released on 9 Aug
  • data-values/time released on 9 Aug
  • wikibase/internal-serialization

all depend on data-values/common ~0.3.0|~0.2.0.

Furthermore, wikibase/wikibase depends on data-values/number ^0.9.0, but its dependencies

  • wikibase/data-model-serialization
  • wikibase/internal-serialization

depend on data-values/number >=0.1 <0.9.

This results in conflicts when trying to do a composer install or composer update with the merge plugin. The CI build succeeds, which @WMDE-leszek suspects is due to the CI build not using the merge plugin, so the conflicts are hidden (“it accidentally works”).

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Update wikibase/data-model-serialization dependencymediawiki/extensions/Wikibasemaster+1 -1
Update data-values/number dependencymediawiki/extensions/WikibaseQualityExternalValidationmaster+1 -1
Update data-values/common dependency to include 0.4mediawiki/extensions/WikibaseQualityExternalValidationmaster+1 -1
Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Aug 29 2017, 11:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2017, 11:44 AM
Lucas_Werkmeister_WMDE added a subscriber: Addshore.Aug 29 2017, 11:45 AM
gerritbot subscribed.Sep 15 2017, 7:43 AM

Change 378213 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseQualityExternalValidation@master] Update data-values/common dependency to include 0.4

https://gerrit.wikimedia.org/r/378213

gerritbot added a project: Patch-For-Review.Sep 15 2017, 7:43 AM
thiemowmde renamed this task from Update data-values dependencies to [Task] Update data-values dependencies.Sep 15 2017, 7:50 AM
thiemowmde claimed this task.
thiemowmde triaged this task as High priority.
thiemowmde added projects: Wikidata-Former-Sprint-Board, DataValues, Wikibase-DataModel-Serialization.
thiemowmde updated the task description. (Show Details)
thiemowmde added subscribers: Lydia_Pintscher, thiemowmde.
thiemowmde moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.Sep 15 2017, 8:21 AM
thiemowmde moved this task from incoming to in progress on the Wikidata board.
gerritbot added a comment.Sep 15 2017, 1:00 PM

Change 378213 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityExternalValidation@master] Update data-values/common dependency to include 0.4

https://gerrit.wikimedia.org/r/378213

WMDE-leszek moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Sep 18 2017, 8:43 AM
thiemowmde closed this task as Resolved.Sep 19 2017, 9:16 AM
thiemowmde removed a project: Patch-For-Review.
thiemowmde updated the task description. (Show Details)

I'm disappointed that https://github.com/wmde/WikibaseDataModelSerialization/pull/222 was not merged, even if it was clearly linked to this task. I'm going to close it as done anyway because said patch was technically not required to fulfill what this task asked for.

gerritbot added a comment.Sep 22 2017, 2:38 PM

Change 379765 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Update wikibase/data-model-serialization dependency

https://gerrit.wikimedia.org/r/379765

gerritbot added a project: Patch-For-Review.Sep 22 2017, 2:38 PM
gerritbot added a comment.Sep 22 2017, 2:48 PM

Change 379769 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityExternalValidation@master] Update data-values/number dependency

https://gerrit.wikimedia.org/r/379769

Lucas_Werkmeister_WMDE reopened this task as Open.Sep 22 2017, 2:48 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE moved this task from Done to Review on the Wikidata-Former-Sprint-Board board.

Reopening because there are still some parts left as far as I can tell (see changes linked above).

gerritbot added a comment.Sep 22 2017, 4:21 PM

Change 379769 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityExternalValidation@master] Update data-values/number dependency

https://gerrit.wikimedia.org/r/379769

gerritbot added a comment.Sep 23 2017, 8:05 AM

Change 379765 abandoned by Lucas Werkmeister (WMDE):
Update wikibase/data-model-serialization dependency

https://gerrit.wikimedia.org/r/379765

Ladsgroup removed a project: Patch-For-Review.Sep 23 2017, 10:19 AM
Ladsgroup updated the task description. (Show Details)
Ladsgroup subscribed.

All are merged.

Ladsgroup moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Sep 23 2017, 10:19 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.Sep 27 2017, 9:03 AM

Yup, composer-merge plugin works again. Thanks everyone!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL