Page MenuHomePhabricator

mobile.startup should be only dependency of Minerva and Minerva should be able to define it itself
Closed, ResolvedPublic


After applying and parent patches the Minerva skin will work without the MobileFrontend extension, however it will throw JS errors and not be fully functional. This is good progress.

The next goal would be to get to T144402

My plan to solve this would be to conditionally add an external dependency to the RL definition for the rendering library. This will be a compiled and versioned version of the mobile.startup module, but to get to this point we'll need to make some changes to prepare for that.

Currently, given we organise our ResourceLoader modules by feature, the following errors are thrown:
Unknown dependency: mobile.betaoptin Error: Unknown dependency: mobile.betaoptin, mobile.toggle Error: Unknown dependency: mobile.toggle, Unknown dependency: mobile.watchstar, Unknown dependency: mobile.startup

If we can reduce this to:
Unknown dependency: mobile.startup Error: Unknown dependency: mobile.startup - this means we only need to swap out one module. This will be a lot easier.

I am following T158980 and T167713 closely as they will both help with this initiative.

This also opens the doors for rebuilding the entire library using a different framework/library e.g. OOjs UI / preact.

Event Timeline

Jdlrobson renamed this task from mobile.startup should be only dependency of Minerva to mobile.startup should be only dependency of Minerva and Minerva should be able to define it itself.Sep 5 2017, 9:44 PM
Jdlrobson created this task.
Jdlrobson triaged this task as Low priority.Aug 2 2019, 6:10 PM
Jdlrobson closed this task as Resolved.Sep 19 2019, 8:58 PM
Jdlrobson claimed this task.

The only module used by Minerva from MobileFrontend now is mobile.startup so this is done.