Page MenuHomePhabricator
Create Task
Maniphest T175260

As a MediaWiki.org admin or Newsletter publisher, I cannot manage my own newsletter
Closed, ResolvedPublic
Actions

Description

This is strange. I have created two almost identical newsletters in test.wikipedia and MediaWiki.org. When I click "Manage", it works on test.wikipedia, but not in MW.o. I believe I have the same permissions in both wikis (administrator and publisher of that newsletter).

Both pages look the same, as an admin/publisher I see the same buttons. However, clicking "Manage", in MW.o I stay in the same page.

Introducing the URL manually, I also end up in the same page:

Details

SubjectRepoBranchLines +/-
Revert "Don't mess around with $wgHooks by using CustomEditor hook"mediawiki/extensions/TwoColConflictmaster+11 -7
Customize query in gerrit

Related Objects

Event Timeline

Qgil created this task.Sep 7 2017, 1:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2017, 1:00 PM
Qgil added a comment.Sep 7 2017, 1:04 PM

I wonder whether it has to do with database permissions. A cannot open/update database kind of thing.

Clicking on "Announce", I do land in https://www.mediawiki.org/wiki/Special:Newsletter/1/announce. And the announcements work. I just sent a Hello World! one (with the secret intention of testing).

Addshore added a project: Two-Column-Edit-Conflict-Merge.Sep 7 2017, 1:40 PM

It looks like this is something to do with some interaction between the TwoColConflict extension and Newsletter

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptSep 7 2017, 1:40 PM
Addshore claimed this task.Sep 7 2017, 1:41 PM
Addshore added a project: User-Addshore.
Addshore added a comment.Sep 7 2017, 1:43 PM

The onCustomEditor hook in TwoColConflict returns false when the TwoColConflict extension is enabled and the user is using the feature.
As a result the onCustomEditor hook for Newsletter is never fired.

Addshore added a project: WMDE-QWERTY-Sprint-2017-09-05.Sep 7 2017, 1:45 PM
Addshore moved this task from Unsorted 💣 to Back Burner 🏛️ on the User-Addshore board.
Addshore moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2017-09-05 board.
Addshore added a subscriber: Legoktm.Sep 7 2017, 1:51 PM

It looks like this was actually caused by https://gerrit.wikimedia.org/r/#/c/329202

Qgil moved this task from Backlog to Confirmed on the MediaWiki-extensions-Newsletter board.Sep 7 2017, 7:11 PM
Legoktm added a comment.Sep 11 2017, 5:29 PM

In the short-term I'd recommend reverting my commit (https://gerrit.wikimedia.org/r/#/c/329202), which was just supposed to be cleanup and not have any actual effects. Long term we should probably refactor EditPage and make the edit conflict handling pluggable or something, so it doesn't require overriding the whole page (composition not inheritance).

gerritbot subscribed.Sep 11 2017, 7:15 PM

Change 377308 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/TwoColConflict@master] Revert "Don't mess around with $wgHooks by using CustomEditor hook"

https://gerrit.wikimedia.org/r/377308

gerritbot added a project: Patch-For-Review.Sep 11 2017, 7:15 PM
Addshore mentioned this in rESCCfe7144652ad1: Revert "Don't mess around with $wgHooks by using CustomEditor hook".Sep 11 2017, 7:16 PM
Addshore moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2017-09-05 board.Sep 13 2017, 9:42 AM
Addshore moved this task from Back Burner 🏛️ to Active 🚁 on the User-Addshore board.
Addshore mentioned this in rESCC794a50cbcfa6: Revert "Don't mess around with $wgHooks by using CustomEditor hook".Sep 13 2017, 9:43 AM
Addshore mentioned this in rESCCff86dd70f0d6: Revert "Don't mess around with $wgHooks by using CustomEditor hook".
Addshore mentioned this in rESCC323f3f30fb68: Revert "Don't mess around with $wgHooks by using CustomEditor hook".Sep 13 2017, 10:16 AM
gerritbot added a comment.Sep 13 2017, 9:07 PM

Change 377308 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Revert "Don't mess around with $wgHooks by using CustomEditor hook"

https://gerrit.wikimedia.org/r/377308

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)).Sep 13 2017, 10:00 PM
Addshore closed this task as Resolved.Sep 15 2017, 2:38 PM

Looks like the issue is now fixed and will be deployed with the next train!

Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.Sep 15 2017, 2:39 PM
Addshore moved this task from Review to Done on the WMDE-QWERTY-Sprint-2017-09-05 board.
Legoktm mentioned this in T176393: TwoColConflict is overriding EditPage for all ContentFormats.Sep 21 2017, 2:44 PM
Tobi_WMDE_SW moved this task from Incoming to Edit Conflict Handling on the TCB-Team (now WMDE-TechWish) board.Oct 10 2017, 9:36 AM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL