When editing a statement, unedited entity input fields are marked unrecognized once unfocused
Closed, ResolvedPublic

Description

Steps to reproduce:

  1. Open any random item with at least one entity-type statement, like this one.
  2. Edit an entity-type statement.
  3. Remove focus from the main snak entity selector, e. g. by clicking elsewhere in the document or adding a qualifier or reference.

The main snak entity selector text field turns red (ui-entityselector-input-unrecognized class) as soon as it loses focus, even though I haven’t edited it at all and I’ll still be able to save the edited statement as soon as I make any other change (e. g. edit qualifiers or references). The same thing happens to other entity selectors as soon as they’ve had focus at least once – e. g., in a statement with an entity-type qualifier or reference, if you focus that text field and then the main snak text field again, the qualifier/reference text field will now be red too.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Sep 11, 9:28 AM
Nikki added a subscriber: Nikki.Mon, Sep 11, 1:01 PM

It also happens if you click "add reference" for the statement without first clicking "edit", even though the property selector is focused. I'm not sure whether the main value field gets focused briefly while it renders, my eyes aren't that fast.

Change 377271 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove red highlighting on all entity selectors

https://gerrit.wikimedia.org/r/377271

Change 377272 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix initial state of all Entity experts

https://gerrit.wikimedia.org/r/377272

Change 377273 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.30.0-wmf.17] Remove red highlighting on all entity selectors

https://gerrit.wikimedia.org/r/377273

Change 377413 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikidata@wmf/1.30.0-wmf.17] Remove red highlighting on all entity selectors

https://gerrit.wikimedia.org/r/377413

Change 377273 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.30.0-wmf.17] Remove red highlighting on all entity selectors

https://gerrit.wikimedia.org/r/377273

Change 377427 had a related patch set uploaded (by Aude; owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.30.0-wmf.18] Remove red highlighting on all entity selectors

https://gerrit.wikimedia.org/r/377427

Change 377427 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.30.0-wmf.18] Remove red highlighting on all entity selectors

https://gerrit.wikimedia.org/r/377427

Change 377413 merged by jenkins-bot:
[mediawiki/extensions/Wikidata@wmf/1.30.0-wmf.17] Remove red highlighting on all entity selectors

https://gerrit.wikimedia.org/r/377413

Mentioned in SAL (#wikimedia-operations) [2017-09-12T13:15:42Z] <hashar@tin> Synchronized php-1.30.0-wmf.17/extensions/Wikidata/extensions/Wikibase/view/resources/jquery/wikibase/themes/default/jquery.wikibase.entityselector.css: Remove red highlighting on all entity selectors - T175525 (duration: 00m 45s)

thiemowmde closed this task as Resolved.Wed, Sep 13, 10:11 AM

Change 377271 abandoned by Thiemo Mättig (WMDE):
Remove red highlighting on all entity selectors

https://gerrit.wikimedia.org/r/377271

Change 377272 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix initial state of all Entity experts

https://gerrit.wikimedia.org/r/377272