Page MenuHomePhabricator
Create Task
Maniphest T176191

[betalabs] Watchlist - empty markers displayed for seen/unseen changes
Closed, ResolvedPublic
Actions

Description

The Watchlist page states: "Changes to pages you haven't visited since the changes occurred are in bold, with solid markers."

  1. In betalabs, user A make changes to some page(s) that are on a watchlist of user B.
  2. User B logs in and go to Watchlist - the pages titles of the unseen changes will be displayed in bold, but the markers (small circles) will be empty.

Screen Shot 2017-09-18 at 5.30.52 PM.png (561×926 px, 123 KB)

Details

SubjectRepoBranchLines +/-
WLFilters: Handle (un)seen (un)filled bullets on grouped RCmediawiki/corewmf/1.30.0-wmf.18+2 -2
WLFilters: Handle (un)seen (un)filled bullets on grouped RCmediawiki/coremaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Sep 19 2017, 12:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2017, 12:55 AM
Etonkovidova renamed this task from [betalabs] Watchlist - unseen changes displayed with empty markers to [betalabs] Watchlist - empty markers displayed for seen/unseen changes.Sep 19 2017, 1:07 AM
Etonkovidova mentioned this in T175062: Update gadgets for seen/unseen styling.
• Mattflaschen-WMF claimed this task.Sep 19 2017, 2:21 AM
gerritbot subscribed.Sep 19 2017, 2:32 AM

Change 378832 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/core@master] WLFilters: Handle (un)seen (un)filled bullets on grouped RC

https://gerrit.wikimedia.org/r/378832

gerritbot added a project: Patch-For-Review.Sep 19 2017, 2:32 AM
• Mattflaschen-WMF mentioned this in T164234: Provide "RC Filters" functionality on the watchlist.Sep 19 2017, 2:37 AM
• Mattflaschen-WMF moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Sep 19 2017, 2:45 AM
Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Sep 19 2017, 5:08 AM
gerritbot added a comment.Sep 19 2017, 5:19 AM

Change 378832 merged by jenkins-bot:
[mediawiki/core@master] WLFilters: Handle (un)seen (un)filled bullets on grouped RC

https://gerrit.wikimedia.org/r/378832

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)).Sep 19 2017, 6:00 AM
gerritbot added a comment.Sep 19 2017, 3:15 PM

Change 378929 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/core@wmf/1.30.0-wmf.18] WLFilters: Handle (un)seen (un)filled bullets on grouped RC

https://gerrit.wikimedia.org/r/378929

gerritbot added a comment.Sep 19 2017, 3:24 PM

Change 378929 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.18] WLFilters: Handle (un)seen (un)filled bullets on grouped RC

https://gerrit.wikimedia.org/r/378929

Stashbot subscribed.Sep 19 2017, 3:33 PM

Mentioned in SAL (#wikimedia-operations) [2017-09-19T15:33:35Z] <catrope@tin> Started scap: core, GuidedTour and WikimediaMessages patches for T176191, T167262 and T175765

Stashbot mentioned this in T167262: Server-launched guided tour can show on the wrong page if the user navigates away before full page load.Sep 19 2017, 3:33 PM
Stashbot mentioned this in T175765: Move New Filters opt-out preference to its own section on the page.
Etonkovidova added a comment.Sep 19 2017, 3:46 PM

Checked in betalabs - the solid markers are displayed properly (in grouped changes too) along with bold titles:

Screen Shot 2017-09-19 at 8.45.13 AM.png (564×937 px, 120 KB)

Etonkovidova closed this task as Resolved.Sep 19 2017, 3:47 PM
Etonkovidova triaged this task as High priority.
Stashbot added a comment.Sep 19 2017, 3:54 PM

Mentioned in SAL (#wikimedia-operations) [2017-09-19T15:54:08Z] <catrope@tin> Finished scap: core, GuidedTour and WikimediaMessages patches for T176191, T167262 and T175765 (duration: 20m 32s)

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)); removed MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)).Sep 19 2017, 4:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits