| MBeat33 | |
| Oct 17 2017, 4:15 PM |
| F26633498: Screenshot_20181018-235523_Chrome.jpg | |
| Oct 19 2018, 12:27 PM |
| F10313931: Screen Shot 2017-10-19 at 9.58.13 AM.png | |
| Oct 19 2017, 1:59 PM |
| F10279097: Bahrain form error.png | |
| Oct 17 2017, 4:15 PM |
https://donate.wikimedia.org/w/index.php?title=Special:LandingPage&uselang=en&country=BH throws an error after specifying 5.00 BHD and then selecting a card:
This was pointed out by a donor, and though BH volume is not large, would be great to fix.
Same thing for Oman:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Stop breaking 3 decimal currencies in validation | mediawiki/extensions/DonationInterface | master | +19 -14 |
Looks like donatewiki is correctly sending amount=5 in the URL, so it seems the problem is on the payments end.
We just got another ticket related to this issue: #461176:
"I'm trying to donate 10.00 Bahraini Dinars (around 26.50 US dollars) but the website is saying it can't process amounts more than $10,000."
Oh shoot, BHD is one of those currencies that takes three decimal points - I bet that has something to do with it. This is probably stopping us from getting anything at all in that currency!
@MBeat33 reports "a donor says the form increased his amount by factor of 1k, sent screenshot - maybe a currency display ‘.’ issue" for Oman, seems like it could be related to this. http://donate.wikimedia.org/?country=OM
Thanks, @Pcoombe I had forgotten about this task! The donor ended up giving us an enormous donation by mistake. Here is the screenshot of what they tried to donate, which became Ingenico 4000265890:
I tried but was unable to replicate this on the OM landing page.
Change 468599 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Stop breaking 3 decimal currencies in validation
Aha, we were doing some dumb amount fiddling in validation, trying to second guess the browser and user's number formatting. I've got the minimum viable fix up for review, but we maybe should drop the whole chunk of code that does the reformatting.
Change 468599 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Stop breaking 3 decimal currencies in validation