Page MenuHomePhabricator

[Spike] __NEWSECTIONLINK__ and __NONEWSECTIONLINK__ behaviour in skins
Open, LowestPublicSpike

Description

According to mw:Help:Magic words#Behavior switches the __NEWSECTIONLINK__ magic word adds a link beside the "Edit" tab for adding a new section on a non-talk page.

Question: Given the changes in Vector how easy will it be to retain this behaviour?

Question: In Minerva this magic word doesn't currently work. How might the existing code be adapted to support the interface change?

Output: Update existing tasks/create new tasks for any problems you discover.

Event Timeline

Jdlrobson triaged this task as Lowest priority.Oct 18 2017, 5:16 PM
Jdlrobson subscribed.

The MinervaNeue skin is incompatible with most of these behavioural switches. If someone wants to investigate that and think about how the behaviour and logic required to make it work they should feel free but this is not a priority and if the logic is messy (e.g. there's no helper methods in core) I don't think we should support it.

Something doesn't work.

OK, leave it broken.

I don't think it's acceptable for any software, especially for a default component of one of the largest websites on the Internet.

@Tacsipacsi whether this is one of the largest websites on the internet is irrelevant. MobileFrontend still only has at most 5 active contributors to the codebase and most of those people also have to maintain other projects. Software is all about prioritizing what can be done by the people available to do the work and this has been broken for at least 6 years without being noticed.

As I've said, if someone is willing to investigate and attempt to fix this they should go ahead, but there are much more pressing bugs that need addressing by the core team.

It's OK if you say it likely won't be fixed in the next years. I have problem with saying "it won't be fixed at all". And I may dig in the code at some time, but it will take me double time as I'm totally unfamiliar with it.

Jdlrobson renamed this task from Support all switch magic words in MinervaNeue to [Spike] __NEWSECTIONLINK__ behaviour in Minerva and Vector..Dec 7 2021, 7:42 PM
Jdlrobson updated the task description. (Show Details)
Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptDec 7 2021, 7:42 PM
Jdlrobson renamed this task from [Spike] __NEWSECTIONLINK__ behaviour in Minerva and Vector. to [Spike] __NEWSECTIONLINK__, __NEWSECTIONLINK__ and __NONEWSECTIONLINK__ behaviour in skins.EditedDec 7 2021, 7:44 PM
Jdlrobson updated the task description. (Show Details)

Repurposed as spike. Since the task was created __TOC__ and all relevant magic words should be working on mobile site. If one isn't it's best to create a task specific to that magic word and tag MediaWiki-Parser .

As far as I understand, in Minerva with DiscussionTools this is solved in T302417. @ppelberg, will Minerva without DiscussionTools be supported in the long term (for third-party wikis)? (On mobile, DiscussionTools seems to replace MobileFrontend’s current talk page tools, unlike desktop, where it mainly augments the existing experience.)

As far as I understand, in Minerva with DiscussionTools this is solved in T302417. @ppelberg, will Minerva without DiscussionTools be supported in the long term (for third-party wikis)? (On mobile, DiscussionTools seems to replace MobileFrontend’s current talk page tools, unlike desktop, where it mainly augments the existing experience.)

Minerva's talk page tools have been removed in https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/837224, so I guess the answer is that they're no longer supported. The basic minimal support for reading talk pages is still there, of course.

matmarex renamed this task from [Spike] __NEWSECTIONLINK__, __NEWSECTIONLINK__ and __NONEWSECTIONLINK__ behaviour in skins to [Spike] __NEWSECTIONLINK__ and __NONEWSECTIONLINK__ behaviour in skins.Sep 17 2023, 9:37 PM

(the title had __NEWSECTIONLINK__ twice)