Page MenuHomePhabricator

Re-use a citation isn't finding citations
Closed, ResolvedPublic1 Estimated Story Points

Description

  1. Open a page with a lot of citations.
  2. Click the Cite button and choose the Re-use tab.
  3. Type an author's name or other content.
  4. It's not there.

I can consistently find citations by searching for their number, but not under other circumstances. It doesn't matter if the citation was added during this editing session.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The search seems only to take the number and the name attribute (if it has one) of the reference into consideration.
Yes, searching the content of the reference would be very convenient.

This is probably a jQuery 3 async regression...

I've gone back to the creation of PreviewWidget, and it looks like it never actually used the CE rendering, which we assumed it did: https://github.com/wikimedia/VisualEditor/commit/db2ed0b1282e41f558987225fdab4b9706101176#diff-de3066494436ef8a305ab69f3805373a

The connection to PreviewWidget (now PreviewElement), is that the index is built by creating previews of each reference and running them through jQuery.text. It was assumed that some rendering will be available synchronously from the CE node, but that CE node was never actually appended to the PreviewElement.

Looks like this regressed some time ago.

Change 389729 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Actually use the CE node while waiting for the DM render

https://gerrit.wikimedia.org/r/389729

Change 389729 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Actually use the CE node while waiting for the DM render

https://gerrit.wikimedia.org/r/389729

Change 389901 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bf37a87d2)

https://gerrit.wikimedia.org/r/389901

Change 389901 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bf37a87d2)

https://gerrit.wikimedia.org/r/389901

Deskana assigned this task to Esanders.
Deskana triaged this task as Medium priority.
Deskana set the point value for this task to 1.
Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.
Deskana removed a project: Patch-For-Review.

@Esanders I still can't find anything? I'm looking at https://en.wikipedia.org/wiki/Salvator_Mundi_(Leonardo)?action=edit and am trying author surnames, source titles, part of the article titles etc. Also, I'd appreciate knowing what that field can find, generally speaking, so that it can be properly documented somewhere. TY!

@Esanders I still can't find anything? I'm looking at https://en.wikipedia.org/wiki/Salvator_Mundi_(Leonardo)?action=edit and am trying author surnames, source titles, part of the article titles etc. Also, I'd appreciate knowing what that field can find, generally speaking, so that it can be properly documented somewhere. TY!

Looks like it's working now.

Deskana changed the task status from Resolved to Invalid.Nov 22 2017, 12:44 PM
Deskana subscribed.

Closing per the above.

Deskana changed the task status from Invalid to Resolved.Nov 22 2017, 12:44 PM

I'd already closed it. Silly me.