Page MenuHomePhabricator
Create Task
Maniphest T179913

Category title appears in blue in preview, even when the description page hasn't been created
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

(Per report) Unlike what T153534 claims, you can actually see categories while previewing the page, but they will always be in blue even if the related category page doesn't actually exist.

Details

SubjectRepoBranchLines +/-
ui.MWSaveDialog: consistent handling of preview category linksmediawiki/extensions/VisualEditormaster+5 -4
Customize query in gerrit

Related Objects

Event Timeline

• Elitre created this task.Nov 7 2017, 10:40 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2017, 10:40 AM
• Elitre added a project: VisualEditor-MediaWiki-2017WikitextEditor.Nov 7 2017, 10:40 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptNov 7 2017, 10:40 AM
• Elitre renamed this task from Categories title appear in blue in preview, even when the description page hasn't been created to Category title appears in blue in preview, even when the description page hasn't been created.Nov 7 2017, 10:41 AM
Dvorapa subscribed.Nov 7 2017, 7:55 PM

Related: T153535

gerritbot subscribed.Nov 29 2017, 5:28 PM

Change 394088 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] ui.MWSaveDialog: consistent handling of preview category links

https://gerrit.wikimedia.org/r/394088

gerritbot added a project: Patch-For-Review.Nov 29 2017, 5:28 PM
gerritbot added a comment.Nov 30 2017, 3:45 PM

Change 394088 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ui.MWSaveDialog: consistent handling of preview category links

https://gerrit.wikimedia.org/r/394088

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)).Nov 30 2017, 4:00 PM
• Deskana closed this task as Resolved.Dec 1 2017, 11:04 AM
• Deskana assigned this task to DLynch.
• Deskana triaged this task as Medium priority.
• Deskana set the point value for this task to 1.
• Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 1 2017, 11:04 AM
• Whatamidoing-WMF reopened this task as Open.Mar 7 2018, 11:59 PM
• Whatamidoing-WMF subscribed.

Codename Lisa reports that non-existent categories are previewing in blue. I verified this at the English Wikipedia. Only one of these cats should be blue:

Screen Shot 2018-03-07 at 3.58.37 PM.png (174×461 px, 24 KB)

• Whatamidoing-WMF renamed this task from Category title appears in blue in preview, even when the description page hasn't been created to [Regression] Category title appears in blue in preview, even when the description page hasn't been created.Mar 7 2018, 11:59 PM
DLynch added a comment.Mar 8 2018, 12:07 AM

Ahh. Side-effect of 3c72766720, with the existing check on rel being too specific. One second.

gerritbot added a comment.Mar 8 2018, 12:10 AM

Change 417175 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] LinkCache: styleParsoidElements find mw:WikiLink with ~=

https://gerrit.wikimedia.org/r/417175

Jdforrester-WMF closed this task as Resolved.Mar 8 2018, 12:13 AM
Jdforrester-WMF mentioned this in T189175: [Regression] Category title appears in blue in preview, even when the description page hasn't been created.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF subscribed.

Not a regression, different break.

Jdforrester-WMF renamed this task from [Regression] Category title appears in blue in preview, even when the description page hasn't been created to Category title appears in blue in preview, even when the description page hasn't been created.Mar 8 2018, 12:14 AM
TheDJ awarded a token.Mar 8 2018, 10:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits