Page MenuHomePhabricator

NWE: Language links, indicators, and transcluded categories are missing in preview
Open, LowPublic8 Story Points

Description

Steps to reproduce:

  1. Open a featured article for editing in NWE (as these should have categories, language links and a badge via <indicator>, at least in most Wikipedias)
  2. Change something, click "Save", click "Preview".

Expected:
You can preview all content.

Actual:
Categories, language links and indicators are missing.

Event Timeline

Schnark created this task.Dec 17 2016, 10:01 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 17 2016, 10:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

And also {{DISPLAYTITLE:}}, which currently is omitted, too.

A real test case is https://de.wikipedia.org/wiki/IPhone?veaction=editsource, a minimal

{{DISPLAYTITLE:foo}}
<indicator name=foo>foo</indicator>
[[Category:Foo]]
[[fr:foo]]
Elitre added a subscriber: Elitre.Jan 19 2017, 11:30 AM

To expand a bit on why seeing the categories would be useful: when adding them via VE, if you're adding a new category that doesn't exist, this is obvious both because the interface tells you about it while you're adding it (and can prevent you from making a mistake if this is the case), and because the related link is red.

A preview with categories also answers questions like: "Does the {{Infobox Town in XY}} add a [[Category:Town in XY]] automatically or do I have to add it manually?"

TheDJ added a subscriber: TheDJ.Feb 1 2017, 10:15 AM
Jdforrester-WMF triaged this task as Low priority.Feb 21 2017, 8:24 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 8.

Change 359646 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Show simple category list in preview

https://gerrit.wikimedia.org/r/359646

Language links will be low priority because most of our wikis use wikidata for them.

Even with Wikidata they are especially useful to see if you accidentally added an interwiki link by forgetting a leading colon in a link.

Change 359646 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Show simple category list in preview

https://gerrit.wikimedia.org/r/359646

Actually categories seem to be part of preview now?

Elitre added a subscriber: Deskana.Nov 7 2017, 10:44 AM

Categories are shown in preview, but only if they are added directly ([[Category:Use British English]]) and not if they're added by transclusion ({{Use British English}}).

Esanders added a comment.EditedMar 12 2018, 11:00 PM

Display title issue filed as T189540

Whatamidoing-WMF renamed this task from NWE: Categories, language links and indicators are missing in preview to NWE: Language links, indicators, and transcluded categories are missing in preview.Apr 19 2018, 6:39 PM
stjn awarded a token.Jan 2 2019, 10:35 PM
stjn added a subscriber: stjn.
stjn added a comment.Jan 2 2019, 10:55 PM

Actually categories seem to be part of preview now?

Was this reverted at any point in time? I can’t see any categories in the preview in 2017 wikitext editor, not even those that weren’t transcluded from a template.

Actually categories seem to be part of preview now?

Was this reverted at any point in time? I can’t see any categories in the preview in 2017 wikitext editor, not even those that weren’t transcluded from a template.

I do see categories in the 2017 wikitext editor preview, so it's up to you to check again and provide an example if they are really missing in some cases.

stjn added a comment.Jan 3 2019, 9:52 AM

I do see categories in the 2017 wikitext editor preview, so it's up to you to check again and provide an example if they are really missing in some cases.

Sure:

  1. Go to https://ru.wikipedia.org/wiki/Кинг,_Мартин_Лютер?veaction=editsource
  2. Try to add something and use preview
  3. No categories in preview at all, ‘Categories’ button from the submenu in the toolbar is also not clickable.

Very interesting. I can reproduce with your example and many other Russian articles, but not all. E.g. https://ru.wikipedia.org/wiki/Zing!_Went_the_Strings_of_My_Heart?veaction=editsource has the categories in preview. I never had this issue in German Wikipedia, and I can't reproduce in English and French, either.

TheDJ added a comment.Jan 4 2019, 10:01 AM

This is due to query to retrieve the categories making the url too long I think

Previewing triggers urls like the following and then i get request errors. We've seen issues like this before.

https://ru.wikipedia.org/w/api.php?action=query&format=json&prop=info%7Cpageprops%7Cpageimages%7Cdescription&pithumbsize=80&pilimit=50&ppprop=disambiguation%7Chiddencat&titles=%D0%9B%D1%8E%D1%82%D0%B5%D1%80%2C%20%D0%9C%D0%B0%D1%80%D1%82%D0%B8%D0%BD%7C%D0%9A%D0%B8%D0%BD%D0%B3%20(%D1%84%D0%B0%D0%BC%D0%B8%D0%BB%D0%B8%D1%8F)%7C%D0%90%D0%BD%D0%B3%D0%BB%D0%B8%D0%B9%D1%81%D0%BA%D0%B8%D0%B9%20%D1%8F%D0%B7%D1%8B%D0%BA%7C15%20%D1%8F%D0%BD%D0%B2%D0%B0%D1%80%D1%8F%7C1929%20%D0%B3%D0%BE%D0%B4%7C%D0%90%D1%82%D0%BB%D0%B0%D0%BD%D1%82%D0%B0%7C4%20%D0%B0%D0%BF%D1%80%D0%B5%D0%BB%D1%8F%7C1968%20%D0%B3%D0%BE%D0%B4%7C%D0%9C%D0%B5%D0%BC%D1%84%D0%B8%D1%81%20(%D0%A2%D0%B5%D0%BD%D0%BD%D0%B5%D1%81%D1%81%D0%B8)%7C%D0%A2%D0%B5%D0%BD%D0%BD%D0%B5%D1%81%D1%81%D0%B8%7C%D0%A1%D0%BE%D0%B5%D0%B4%D0%B8%D0%BD%D1%91%D0%BD%D0%BD%D1%8B%D0%B5%20%D0%A8%D1%82%D0%B0%D1%82%D1%8B%20%D0%90%D0%BC%D0%B5%D1%80%D0%B8%D0%BA%D0%B8%7C%D0%93%D1%80%D0%B0%D0%B6%D0%B4%D0%B0%D0%BD%D1%81%D0%BA%D0%B8%D0%B5%20%D0%B8%20%D0%BF%D0%BE%D0%BB%D0%B8%D1%82%D0%B8%D1%87%D0%B5%D1%81%D0%BA%D0%B8%D0%B5%20%D0%BF%D1%80%D0%B0%D0%B2%D0%B0%7C%D0%91%D0%BE%D0%B3%D0%BE%D1%81%D0%BB%D0%BE%D0%B2%7C%D0%A1%D0%B2%D1%8F%D1%89%D0%B5%D0%BD%D0%BD%D0%BE%D1%81%D0%BB%D1%83%D0%B6%D0%B8%D1%82%D0%B5%D0%BB%D1%8C%7C%D0%9F%D0%B8%D1%81%D0%B0%D1%82%D0%B5%D0%BB%D1%8C%7C%D0%9F%D0%B0%D1%81%D1%82%D0%BE%D1%80%7C%D0%9F%D0%B0%D1%86%D0%B8%D1%84%D0%B8%D0%B7%D0%BC%7C%D0%93%D1%83%D0%BC%D0%B0%D0%BD%D0%B8%D1%82%D0%B0%D1%80%D0%BD%D0%B0%D1%8F%20%D0%BF%D0%BE%D0%BC%D0%BE%D1%89%D1%8C%7C%D0%9F%D1%80%D0%B0%D0%B2%D0%BE%D0%B7%D0%B0%D1%89%D0%B8%D1%82%D0%BD%D0%B8%D0%BA%D0%B8%7C%D0%9A%D0%B8%D0%BD%D0%B3%2C%20%D0%9C%D0%B0%D1%80%D1%82%D0%B8%D0%BD%20%D0%9B%D1%8E%D1%82%D0%B5%D1%80%20(%D1%81%D1%82%D0%B0%D1%80%D1%88%D0%B8%D0%B9)%7C%D0%9D%D0%BE%D0%B1%D0%B5%D0%BB%D0%B5%D0%B2%D1%81%D0%BA%D0%B0%D1%8F%20%D0%BF%D1%80%D0%B5%D0%BC%D0%B8%D1%8F%20%D0%BC%D0%B8%D1%80%D0%B0%7C1964%20%D0%B3%D0%BE%D0%B4%7C1966%20%D0%B3%D0%BE%D0%B4%7C%D0%9C%D0%B5%D0%B4%D0%B0%D0%BB%D1%8C%20%D0%A1%D0%BF%D0%B8%D0%BD%D0%B3%D0%B0%D1%80%D0%BD%D0%B0%7C1957%20%D0%B3%D0%BE%D0%B4%7C1978%20%D0%B3%D0%BE%D0%B4%7C1959%20%D0%B3%D0%BE%D0%B4%7C%D0%A7%D0%B5%D0%BB%D0%BE%D0%B2%D0%B5%D0%BA%20%D0%B3%D0%BE%D0%B4%D0%B0%20(Time)%7C1963%20%D0%B3%D0%BE%D0%B4%7C%D0%97%D0%BE%D0%BB%D0%BE%D1%82%D0%B0%D1%8F%20%D0%BC%D0%B5%D0%B4%D0%B0%D0%BB%D1%8C%20%D0%9A%D0%BE%D0%BD%D0%B3%D1%80%D0%B5%D1%81%D1%81%D0%B0%20%D0%A1%D0%A8%D0%90%7C2004%20%D0%B3%D0%BE%D0%B4%7C1984%20%D0%B3%D0%BE%D0%B4%7C1929%7C%D0%90%D1%82%D0%BB%D0%B0%D0%BD%D1%82%D0%B0%20(%D0%94%D0%B6%D0%BE%D1%80%D0%B4%D0%B6%D0%B8%D1%8F)%7C%D0%94%D0%B6%D0%BE%D1%80%D0%B4%D0%B6%D0%B8%D1%8F%7C%D0%A1%D0%A8%D0%90%7C1968%7C%D0%90%D1%84%D1%80%D0%BE%D0%B0%D0%BC%D0%B5%D1%80%D0%B8%D0%BA%D0%B0%D0%BD%D1%86%D1%8B%7C%D0%91%D0%B0%D0%BF%D1%82%D0%B8%D0%B7%D0%BC%7C%D0%9F%D1%80%D0%BE%D0%BF%D0%BE%D0%B2%D0%B5%D0%B4%D1%8C%7C%D0%9E%D1%80%D0%B0%D1%82%D0%BE%D1%80%7C%D0%94%D0%B2%D0%B8%D0%B6%D0%B5%D0%BD%D0%B8%D0%B5%20%D0%B7%D0%B0%20%D0%B3%D1%80%D0%B0%D0%B6%D0%B4%D0%B0%D0%BD%D1%81%D0%BA%D0%B8%D0%B5%20%D0%BF%D1%80%D0%B0%D0%B2%D0%B0%20%D1%87%D0%B5%D1%80%D0%BD%D0%BE%D0%BA%D0%BE%D0%B6%D0%B8%D1%85%20%D0%B2%20%D0%A1%D0%A8%D0%90%7C%D0%9F%D1%80%D0%BE%D0%B3%D1%80%D0%B5%D1%81%D1%81%D0%B8%D0%B2%D0%B8%D0%B7%D0%BC%20%D0%B2%20%D0%A1%D0%A8%D0%90%7C%D0%94%D0%B8%D1%81%D0%BA%D1%80%D0%B8%D0%BC%D0%B8%D0%BD%D0%B0%D1%86%D0%B8%D1%8F%7C%D0%A1%D0%B5%D0%B3%D1%80%D0%B5%D0%B3%D0%B0%D1%86%D0%B8%D1%8F%7C%D0%92%D0%BE%D0%B9%D0%BD%D0%B0%20%D0%B2%D0%BE%20%D0%92%D1%8C%D0%B5%D1%82%D0%BD%D0%B0%D0%BC%D0%B5%7C%D0%94%D0%B6%D0%B5%D0%B9%D0%BC%D1%81%20%D0%AD%D1%80%D0%BB%20%D0%A0%D0%B5%D0%B9%7C%D0%92%D0%B0%D1%88%D0%B8%D0%BD%D0%B3%D1%82%D0%BE%D0%BD%2C%20%D0%91%D1%83%D0%BA%D0%B5%D1%80%20%D0%A2%D0%B0%D0%BB%D0%B8%D0%B0%D1%84%D0%B5%D1%80%7C%D0%9A%D0%B8%D0%BD%D0%B3%2C%20%D0%90%D0%BB%D1%8C%D0%B1%D0%B5%D1%80%D1%82%D0%B0%20%D0%A3%D0%B8%D0%BB%D1%8C%D1%8F%D0%BC%D1%81%7C%D0%90%D0%BC%D0%B5%D1%80%D0%B8%D0%BA%D0%B0%D0%BD%D1%86%D1%8B%20%D0%B8%D1%80%D0%BB%D0%B0%D0%BD%D0%B4%D1%81%D0%BA%D0%BE%D0%B3%D0%BE%20%D0%BF%D1%80%D0%BE%D0%B8%D1%81%D1%85%D0%BE%D0%B6%D0%B4%D0%B5%D0%BD%D0%B8%D1%8F&continue=