⚓ T180930 When a table is unclosed, parsoid adds the closing tag without respecting SOL constraints on the closing tag -- probably limited to selective serialization

• Whatamidoing-WMF created this task.Nov 20 2017, 6:59 AM

Restricted Application added a project: VisualEditor. · View Herald TranscriptNov 20 2017, 6:59 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I'm going to guess this is an invalid wikitext issue. Either way VE doesn't control the inserting of close table tags, so it would be probably be a Parsoid issue.

See https://de.wikipedia.org/w/index.php?title=Einwohnerentwicklung_von_Jena&action=edit&section=7 for the problem .. the closing tag is in the wrong place.

This old revision ( https://de.wikipedia.org/w/index.php?title=Einwohnerentwicklung_von_Jena&action=edit&oldid=170851443 ) has two of those.

So, the # of added closing tags matches the # of broken tables.

Fixed in https://de.wikipedia.org/w/index.php?title=Einwohnerentwicklung_von_Jena&type=revision&diff=171540683&oldid=171163661

Although ... it is odd that Parsoid added the table closing tags in a broken fashion as well :D :D

~~Is it? The table w/o the closing tag was edited in those cases.~~ Broken being the operative word.

Arlolra reopened this task as Open.Nov 30 2017, 7:13 PM

Arlolra claimed this task.

Arlolra triaged this task as Medium priority.

Arlolra removed a project: VisualEditor.

Repurposed the ticket for a related Parsoid bug, but the fix for the original reported issue is to fix the page (which Arlo already has) ... but, just an FYI for future reports of this nature.

Change 394412 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] T180930: Selser shouldn't reuse orig sep for autoinserted ends

https://gerrit.wikimedia.org/r/394412

gerritbot added a project: Patch-For-Review.Nov 30 2017, 9:36 PM

Change 394412 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T180930: Selser shouldn't reuse orig sep for autoinserted tags

https://gerrit.wikimedia.org/r/394412

Arlolra closed this task as Resolved.Dec 6 2017, 12:04 AM

Mentioned in SAL (#wikimedia-operations) [2017-12-06T21:43:17Z] <arlolra> Updated Parsoid to rGPAR01c1fc33c15c (T178253, T61840, T180930, T179259)

Stashbot mentioned this in T179259: Visual Editor removing whitespace from infoboxes by default.Dec 6 2017, 9:43 PM

A test edit on https://de.wikipedia.org/wiki/Einwohnerentwicklung_von_Jena?oldid=170950445&veaction=edit puts the table end tags on their own lines now.

ssastry mentioned this in T116554: Parsoid closes a table at the end of a page after a VisualEditor edit (due to broken wikitext?).Dec 18 2017, 9:59 PM

When a table is unclosed, parsoid adds the closing tag without respecting SOL constraints on the closing tag -- probably limited to selective serialization
Closed, ResolvedPublic
Actions

Description

Related Objects

Event Timeline

When a table is unclosed, parsoid adds the closing tag without respecting SOL constraints on the closing tag -- probably limited to selective serializationClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

When a table is unclosed, parsoid adds the closing tag without respecting SOL constraints on the closing tag -- probably limited to selective serialization
Closed, ResolvedPublic
Actions