Page MenuHomePhabricator

Timeless pictures do not have a "Go to file description" icon
Closed, ResolvedPublic

Description

Hi. As in the title. Thank you.

Event Timeline

ashley added subscribers: Isarra, TheDJ, ashley.

So this is about missing div.magnify CSS rules, which is why the little icon (resources/src/mediawiki.skinning/images/magnify-clip-{ltr,rtl}.{png,svg}) indicating the availability of a bigger image on thumbnail images is not showing up. Example: https://en.wikipedia.org/wiki/MediaWiki?useskin=monobook#History vs. https://en.wikipedia.org/wiki/MediaWiki?useskin=timeless#History

For most skins these rules are defined in /resources/src/mediawiki.skinning/content.css, which is a part of the mediawiki.skinning.content ResourceLoader module but Timeless doesn't use that module, so obviously the icon isn't showing up either. Copypasting the styles as-is is easy, but IMO with those rules the little icon looks a tad bit out of place.

cc'ing @Isarra and @TheDJ for further input.

Start with that, reposition, replace icon?

Can we just make a separate module just for this?

Change 460117 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Add thumb magnify icon

https://gerrit.wikimedia.org/r/460117

Change 460117 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Add thumb magnify icon

https://gerrit.wikimedia.org/r/460117

ashley assigned this task to Isarra.
ashley removed a project: Patch-For-Review.