Improve keyboard navigation on AdvancedSearch
Closed, ResolvedPublic
Actions

Description

Currently it's not possible to tab to the Advanced parameters: expander to expand the additional options.

Proposed improvements:

Autofocus main search field, especially when coming from a submitted search
Allow tabbing to the Advanced parameters: button
Figure and fix how to deal with 'search pils' here
Allow uncollapsing the advanced parameters by keyboard action
~~Maybe: Change tab order on advanced search fields, so help icons will be selected after the input field selection~~
~~Maybe: Allow an additional way to submit the form at the very end~~

Edit: Tab order task moved to T182125

Details

	Subject	Repo	Branch	Lines +/-
	Allow basic keyboard interaction with AdvancedSearch pane	mediawiki/extensions/AdvancedSearch	master	+23 -2
	Set autofocus for AdvancedSearch field	mediawiki/extensions/AdvancedSearch	master	+1 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T198599 Content checklist for making AdvancedSearch a default feature
Resolved	None	T181488 Improve screenreader compatibility in AdvancedSearch
Resolved	WMDE-Fisch	T181162 Improve keyboard navigation on AdvancedSearch

Event Timeline

WMDE-Fisch created this task.Nov 22 2017, 4:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 22 2017, 4:12 PM

Change 392874 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/AdvancedSearch@master] Allow basic keyboard interaction with AdvancedSearch pane

https://gerrit.wikimedia.org/r/392874

gerritbot added a project: Patch-For-Review.Nov 22 2017, 5:48 PM

WMDE-Fisch mentioned this in rEASR20cef91b6da8: Allow basic keyboard interaction with AdvancedSearch pane.Nov 22 2017, 5:48 PM

WMDE-Fisch mentioned this in rEASR8fdb736459e3: Allow basic keyboard interaction with AdvancedSearch pane.Nov 23 2017, 1:10 PM

WMDE-Fisch mentioned this in rEASR1f430ce94e0a: Allow basic keyboard interaction with AdvancedSearch pane.Nov 23 2017, 6:51 PM

WMDE-Fisch mentioned this in rEASRe809c08a5c29: Allow basic keyboard interaction with AdvancedSearch pane.Nov 24 2017, 8:33 AM

Change 393192 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/AdvancedSearch@master] Set autofocus for AdvancedSearch field

https://gerrit.wikimedia.org/r/393192

WMDE-Fisch mentioned this in rEASRda2aad1acfc5: Set autofocus for AdvancedSearch field.Nov 24 2017, 9:25 AM

• Lea_WMDE moved this task from Backlog to Text stuff on the Advanced-Search board.Nov 24 2017, 12:09 PM

WMDE-Fisch claimed this task.Nov 24 2017, 3:55 PM

WMDE-Fisch added a project: WMDE-QWERTY-Sprint-2017-11-14.

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2017-11-14 board.

WMDE-Fisch added a project: Accessibility.Nov 28 2017, 10:54 AM

WMDE-Fisch mentioned this in T181488: Improve screenreader compatibility in AdvancedSearch.

WMDE-Fisch added a parent task: T181488: Improve screenreader compatibility in AdvancedSearch.

Change 393192 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Set autofocus for AdvancedSearch field

https://gerrit.wikimedia.org/r/393192

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 28 2017, 12:00 PM

Change 392874 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Allow basic keyboard interaction with AdvancedSearch pane

https://gerrit.wikimedia.org/r/392874

Addshore added a project: WMDE-QWERTY-Sprint-2017-11-28.Nov 28 2017, 3:46 PM

Addshore moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2017-11-28 board.

Why not just use a normal ButtonWidget? It already does all the accessibility stuff. https://gerrit.wikimedia.org/r/#/c/393954/

Maybe: Change tab order on advanced search fields, so help icons will be selected after the input field selection

Yes please, this was very annoying for me. You might want to upstream your overrides of the FieldLayout design to OOjs UI – I think putting the help icons after the label and field is a better idea than between them, like we currently do.

Tobi_WMDE_SW moved this task from Proposed to Currently in sprint on the WMDE-TechWish board.Dec 5 2017, 1:38 PM

WMDE-Fisch closed this task as Resolved.Dec 5 2017, 4:51 PM

WMDE-Fisch mentioned this in T182125: Reposition the info (i) to match the standard OOUI look.

WMDE-Fisch updated the task description. (Show Details)

WMDE-Fisch moved this task from Doing to Done on the WMDE-QWERTY-Sprint-2017-11-28 board.

Tobi_WMDE_SW moved this task from Currently in sprint to Done on the WMDE-TechWish board.Dec 14 2017, 3:13 PM

• Lea_WMDE moved this task from Done to Demoed on the WMDE-TechWish board.Feb 20 2018, 3:33 PM