Page MenuHomePhabricator
Create Task
Maniphest T182125

Reposition the info (i) to match the standard OOUI look
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
None
Authored By
WMDE-Fisch
Dec 5 2017, 4:51 PM
Tags
Referenced Files
F16136784: image.png
Mar 26 2018, 6:51 PM
F16135896: image.png
Mar 26 2018, 6:51 PM
F15734513: advancesearch-bug3.webm
Mar 21 2018, 11:01 AM
Subscribers
Aklapper
Charlie_WMDE
gerritbot
Jdforrester-WMF
• Lea_WMDE
matmarex
• MichaelSchoenitzer_WMDE
View All 11 Subscribers

Description

Current situation:
Currently, when tabbing through the fields, the order is unexpected

Example:

This is due to the fact that the (i) is places behind the fields and not in front like in the standard UI elements which look like this

image.png (149×731 px, 11 KB)

Our UI looks like this

image.png (164×687 px, 11 KB)

Task:
Adapt out UI to the standard OOUI.

Acceptance criteria:

  • The into (i)s are now placed right after the field label but before the field itself
  • When tabbing the order is now LTR on LTR languages and RTL on RTL languages and goes to the next line when the current line has no more elements

Originally taken from T181162

Details

SubjectRepoBranchLines +/-
Un-break the field layoutmediawiki/extensions/AdvancedSearchmaster+0 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.Dec 5 2017, 4:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 5 2017, 4:51 PM
WMDE-Fisch mentioned this in T181162: Improve keyboard navigation on AdvancedSearch.Dec 5 2017, 4:51 PM
matmarex subscribed.Dec 5 2017, 10:17 PM
• Lea_WMDE triaged this task as Medium priority.Feb 6 2018, 2:53 PM
• Lea_WMDE removed a project: WMDE-TechWish.
• Lea_WMDE moved this task from Backlog to Other stuff on the Advanced-Search board.Feb 15 2018, 3:58 PM
• Lea_WMDE added a project: OOUI.Mar 21 2018, 11:01 AM
• Lea_WMDE updated the task description. (Show Details)
• Lea_WMDE added subscribers: Volker_E, Mooeypoo, • Lea_WMDE.

Hello again :) @Mooeypoo @Volker_E @matmarex is this something that should be changend for OOUI or just in advancedSearch?

• Lea_WMDE merged a task: T189961: Advanced search: Order of selection via Tab is confusing.Mar 21 2018, 11:03 AM
• Lea_WMDE moved this task from Other stuff to Backlog on the Advanced-Search board.
• Lea_WMDE added a subscriber: • MichaelSchoenitzer_WMDE.
matmarex added a comment.Mar 26 2018, 6:51 PM

@Lea_WMDE It's a problem with AdvancedSearch only, since it customizes the display of the fields in funny ways, in particular moving the "help" buttons to the right, but without doing anything to fix the tabbing order.

Just for reference, AdvancedSearch interface looks like this:

image.png (164×687 px, 11 KB)

While a normal OOUI FieldLayout looks like this:
image.png (149×731 px, 11 KB)

• Lea_WMDE added a comment.Mar 27 2018, 8:13 AM

@matmarex thanks for the hint! Then we will look for a custom solution (or change to standard behavior) :)

thiemowmde mentioned this in T190938: Input fields and info icons in the "structure" section are shifted to the right.Mar 28 2018, 2:03 PM
Charlie_WMDE subscribed.Apr 4 2018, 12:00 PM

As much as I prefer it to be the other way round, we should change to the standard behavior on this one. If we want to make such changes we should either have a very good reason for the exception on hand or we should address the OOUI pattern altogether.

Charlie_WMDE renamed this task from Change the tab order in advanced search fields to Reposition the info (i) to match the standart OOUI look.Apr 10 2018, 1:05 PM
Charlie_WMDE updated the task description. (Show Details)
• Lea_WMDE moved this task from Backlog to Tickets ready for pickup on the Advanced-Search board.Apr 23 2018, 9:48 AM
• Lea_WMDE renamed this task from Reposition the info (i) to match the standart OOUI look to Reposition the info (i) to match the standard OOUI look.Apr 25 2018, 11:55 AM
• Lea_WMDE set the point value for this task to 3.
• Lea_WMDE added a subtask: T194460: Fix info icon margin after OOUI v0.27 update.May 11 2018, 9:20 AM
• Lea_WMDE added a project: WMDE-FUN-Sprint-2018-05-28.May 28 2018, 10:27 AM
• Lea_WMDE moved this task from Tickets ready for pickup to In FUN sprint on the Advanced-Search board.
• Tim_WMDE claimed this task.Jun 1 2018, 9:58 AM
gerritbot subscribed.Jun 1 2018, 1:07 PM

Change 436788 had a related patch set uploaded (by Gabriel Birke; owner: Gabriel Birke):
[mediawiki/extensions/AdvancedSearch@master] Un-break the field layout

https://gerrit.wikimedia.org/r/436788

gerritbot added a project: Patch-For-Review.Jun 1 2018, 1:07 PM
gabriel-wmde mentioned this in rEASRf53b59fcf5db: Un-break the field layout.Jun 1 2018, 1:07 PM
• Tonina_Zhelyazkova_WMDE removed • Tim_WMDE as the assignee of this task.Jun 1 2018, 1:33 PM
• Tonina_Zhelyazkova_WMDE moved this task from Todo to Review on the WMDE-FUN-Sprint-2018-05-28 board.
• Tonina_Zhelyazkova_WMDE added a subscriber: • Tim_WMDE.
Jdforrester-WMF edited projects, added UI-Standardization; removed OOUI.Jun 1 2018, 5:10 PM
Jdforrester-WMF subscribed.

Not an issue with the OOUI library, but instead a piece of UI standardisation work.

gerritbot added a comment.Jun 4 2018, 12:58 PM

Change 436788 merged by Tonina Zhelyazkova:
[mediawiki/extensions/AdvancedSearch@master] Un-break the field layout

https://gerrit.wikimedia.org/r/436788

• Tonina_Zhelyazkova_WMDE moved this task from Review to Deploy to Test on the WMDE-FUN-Sprint-2018-05-28 board.Jun 4 2018, 12:59 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Jun 4 2018, 1:00 PM
gabriel-wmde moved this task from Deploy to Test to Test on the WMDE-FUN-Sprint-2018-05-28 board.Jun 7 2018, 9:30 AM
Charlie_WMDE moved this task from Test to Done on the WMDE-FUN-Sprint-2018-05-28 board.Jun 8 2018, 3:48 PM
thiemowmde moved this task from Incoming to Advanced Search on the TCB-Team (now WMDE-TechWish) board.Jun 12 2018, 4:05 PM
• Lea_WMDE closed subtask T194460: Fix info icon margin after OOUI v0.27 update as Resolved.Jun 16 2018, 6:51 AM
• Vvjjkkii reopened subtask T194460: Fix info icon margin after OOUI v0.27 update as Open.Jul 1 2018, 1:10 AM
CommunityTechBot closed subtask T194460: Fix info icon margin after OOUI v0.27 update as Resolved.Jul 2 2018, 1:37 PM
• Lea_WMDE closed this task as Resolved.Oct 11 2018, 8:52 AM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 2:48 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 7 2022, 3:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits