Steps to reproduce:
- Open any article with a reference.
- Click the reference.
Expected:
The reference is highlighted using a light blue background.
Actual:
The background extends above the reference, covering the ::before element.
Description
Description
Details
Details
Related Objects
Related Objects
- Mentioned In
- T183669: References bug
Event Timeline
Comment Actions
This seems to be caused by the :target:before rule in /skins/Timeless/resources/screen-desktop.less; specifically its height and margin properties. Setting height to auto and margin to 0 seems to fix the references list, but I'm not sure what that could be breaking, if anything. Still, we'll probably want a more precise fix and maybe we don't even want to touch the offending CSS rule.
cc'ing @Isarra @matmarex @SamanthaNguyen @TheDJ for additional input.
Comment Actions
Change 401188 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/skins/Timeless@master] Remove fake element created before links so background aligns correctly
Comment Actions
| Before | After |
 |  |
This was tested on Chrome v63.0.3239.84 (latest stable version), Windows 10 platform.
Comment Actions
And one more thing I forgot (sorry): https://www.mediawiki.org/wiki/Social_tools?useskin=timeless#cite_note-7 This was the page I tested on.
Comment Actions
Change 401188 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Remove fake element created before links so background aligns correctly