| matmarex | |
| Nov 28 2017, 11:41 PM |
| F14640505: image.png | |
| Mar 7 2018, 5:26 PM |
| F13952646: Screenshot_20180222_181608.png | |
| Feb 22 2018, 5:21 PM |
| F13906289: overallMock.png | |
| Feb 20 2018, 1:43 PM |
| F11057024: image.png | |
| Nov 28 2017, 11:41 PM |
Motivation
The "empty" first option for "File type" dropdown looks weird, and it is hard for people to understand they need to click there if they want to get rid of a file type specification
MOCK:
Acceptance Criteria
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Change the default file option text | mediawiki/extensions/AdvancedSearch | master | +4 -1 |
@Charlie_WMDE are you sure you want to use "Add file type" instead of "Choose file type"? During storytime it was indicated that "add" implies that you can add multiple ones (and for namespaces you can), but you can only select one file type
@Lea_WMDE I don't see this as a big problem, hence I picked add seeing that it is consistent with the wording we already use. I do understand your point though. Since convention seems to be to use "select" I suggest we use that. I have updated the mock accordingly.
Change 416989 had a related patch set uploaded (by Ebba Aniansson; owner: Ebba Aniansson):
[mediawiki/extensions/AdvancedSearch@master] Change the default file option text
@Charlie_WMDE hey charlie, do you want the "Select file Type" text to be gray or does it work with how it is now? :)
Change 416989 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Change the default file option text
Hey @aniansson we already talked face to face but just for documentation purposes: leaving it the way the OOUI widget comes naturally is fine.
This is even on the live system already - it was deployed last Tuesday. But fortunately it looks good :)