CodeMirror button still shown (and semi-functional) when used with wikEd
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	kaldari
	Dec 5 2017, 11:18 PM

Description

See T178348 for background. Currently when the wikEd gadget is enabled, CodeMirror's syntax highlighting is disabled to prevent conflicts. However the CodeMirror button is still displayed and it still changes the user prefs when clicked (even though the user doesn't see any change). The CodeMirror button should probably be completely removed when the wikEd gadget is enabled (since they aren't compatible).

Details

	Subject	Repo	Branch	Lines +/-
	Let CodeMirror load and work even with wikEd enabled	mediawiki/extensions/CodeMirror	master	+1 -3
	Early exit when the gadget wikEd is enabled	mediawiki/extensions/CodeMirror	master	+7 -4

Customize query in gerrit

Related Objects

Mentioned In: T246181: Small Wiki Toolkits: How-to guidelines and/or potential recommendations for Gadgets
Mentioned Here: T178348: Investigation: CodeMirror and WikEd gadget (and maybe other syntax highlighting gadgets) don't get along well

Event Timeline

kaldari created this task.Dec 5 2017, 11:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 5 2017, 11:18 PM

kaldari moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Dec 5 2017, 11:18 PM

Change 395692 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/extensions/CodeMirror@master] Early exit when the gadget wikEd is enabled

https://gerrit.wikimedia.org/r/395692

gerritbot added a project: Patch-For-Review.Dec 6 2017, 6:58 AM

Fomafix claimed this task.Dec 6 2017, 6:59 AM

Change 395692 abandoned by Niharika29:
Early exit when the gadget wikEd is enabled

Reason:
I agree with what James said. The fix should be made in wikEd and not CodeMirror. We can talk more about it in Phabricator if you wish. I'm going to abandon this patch meanwhile.

https://gerrit.wikimedia.org/r/395692

Niharika moved this task from Needs Discussion to Bug backlog on the Community-Tech board.Feb 6 2018, 10:27 PM

Who owns WikiEd? I don't see a Phab component...

In T182157#3998093, @TBolliger wrote:

Who owns WikiEd? I don't see a Phab component...

@Cacycle is the wikEd maintainer. (wikEd source)

Thank you!

@Cacycle — would you be able to look into this problem for us?

In T182157#3998093, @TBolliger wrote:

Who owns WikiEd? I don't see a Phab component...

We do not use Phab for gadgets.

Niharika removed a project: Community-Tech.Mar 2 2018, 6:01 AM

JJMC89 merged a task: T190282: CodeMirror is incompatible with wikEd.Mar 21 2018, 2:17 PM

JJMC89 added a subscriber: IKhitron.

hmm, I patched wikEd a couple of months ago to disable itself when CodeMirror is active though..

So.. why does code mirror disable itself (T178348 ) as well ?

In T182157#4068875, @TheDJ wrote:

hmm, I patched wikEd a couple of months ago to disable itself when CodeMirror is active though..

So.. why does code mirror disable itself (T178348 ) as well ?

Well, we were never told about it. :)

I can undo T178348.

Change 421078 had a related patch set uploaded (by Niharika29; owner: Niharika29):
[mediawiki/extensions/CodeMirror@master] Let CodeMirror load and work even with wikEd enabled

https://gerrit.wikimedia.org/r/421078

gerritbot added a project: Patch-For-Review.Mar 21 2018, 5:22 PM

well, one was AFTER the other, so maybe there still was a problem... we will have to test i guess

Fomafix removed Fomafix as the assignee of this task.Apr 10 2018, 8:13 PM

Fomafix subscribed.

Aklapper mentioned this in T246181: Small Wiki Toolkits: How-to guidelines and/or potential recommendations for Gadgets.Apr 29 2020, 3:17 PM

Question answered hence resetting task status. (Plus patch still awaiting review.)

Change #421078 abandoned by MusikAnimal:

[mediawiki/extensions/CodeMirror@master] Let CodeMirror load and work even with wikEd enabled

Reason:

stale; CM6 works with WikEd