| • Volker_E | |
| Dec 6 2017, 1:47 AM |
| F12233982: Screen Shot 2018-01-03 at 5.21.08 PM.png | |
| Jan 4 2018, 1:22 AM |
| F11211210: image.png | |
| Dec 6 2017, 1:47 AM |
Currently “Mark group as read” & “Mark all as read” buttons are flawed as they provide a labelIconWidget within a buttonWidget.
When we upstream the icon T139779 it should be possible to simplify the structure and resolve this easily by just using OOUI icon.
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/Echo | master | +5 -0 | Fix "Mark as read" button icon on no-JS |
Change 401738 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/Echo@master] Fix "Mark as read" button icon on no-JS
@Volker_E, is this about the DOM structure of no-JS buttons? Or about the icons in badgeicons.json and not from OOjs UI icon pack? Or about wrong appearance?
I think we should at least fix the appearance and the patch is submitted for that.
Change 401738 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Fix "Mark as read" button icon on no-JS
This can be reopened, moved out of QA and cleaned up for better widget structure, probably after T139779 is done.
