Mark * as read buttons' inner structure have flawed appearance in No-JS
Closed, ResolvedPublic

Description

Currently “Mark group as read” & “Mark all as read” buttons are flawed as they provide a labelIconWidget within a buttonWidget.
When we upstream the icon T139779 it should be possible to simplify the structure and resolve this easily by just using OOUI icon.

Volker_E created this task.Dec 6 2017, 1:47 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptDec 6 2017, 1:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Volker_E renamed this task from Mark * as read button's inner structure have flawed appearance in No-JS to Mark * as read buttons' inner structure have flawed appearance in No-JS.Dec 6 2017, 1:47 AM
Volker_E updated the task description. (Show Details)

Change 401738 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/Echo@master] Fix "Mark as read" button icon on no-JS

https://gerrit.wikimedia.org/r/401738

Petar.petkovic added a subscriber: Petar.petkovic.

@Volker_E, is this about the DOM structure of no-JS buttons? Or about the icons in badgeicons.json and not from OOjs UI icon pack? Or about wrong appearance?

I think we should at least fix the appearance and the patch is submitted for that.

Change 401738 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Fix "Mark as read" button icon on no-JS

https://gerrit.wikimedia.org/r/401738

The fix was checked in betalabs:

Etonkovidova closed this task as Resolved.Jan 4 2018, 1:28 AM

This can be reopened, moved out of QA and cleaned up for better widget structure, probably after T139779 is done.