Kill badgeicons.json and use OOUI's icons-alerts.json instead
Closed, ResolvedPublic
Actions

Description

Now that OOUI's "alerts" icon pack includes all the icons we need, we can use it and get rid of the badgeicons module.

Replace uses of the ext.echo.badgeicons module with oojs-ui.styles.icons-alerts
Delete the ext.echo.badgeicons module definition in extension.json
Delete modules/icons/badgeicons.json and the icon files it refers to (badge.svg and tray.svg)

Requires

Apex to feature 'alerts' icon pack as well – https://gerrit.wikimedia.org/r/#/c/298031/
T145163: Slim down the "alerts" icon pack to the bare essentials
Upstream 'double-check' icon to OOUI 'interactions' pack; added in 786c7e180fc0e4542a41cc0ae1e4c2961516aefb

Details

	Subject	Repo	Branch	Lines +/-
	Remove badgeicon module, use OOUI icon instead.	mediawiki/extensions/Echo	master	+20 -76
	add ooui icons	mediawiki/extensions/Echo	master	+3 -24

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Shivanshbindal9	T139779 Kill badgeicons.json and use OOUI's icons-alerts.json instead
		Resolved		Volker_E	T145163 Slim down the "alerts" icon pack to the bare essentials

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 8 2016, 6:15 PM

Quiddity added subscribers: Quiddity, Mooeypoo.Jul 8 2016, 11:09 PM

Danny_B moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.Jul 9 2016, 8:26 PM

matmarex removed a project: OOUI.Jul 12 2016, 6:10 PM

This requires https://gerrit.wikimedia.org/r/#/c/298031/ at the very least.

• Mattflaschen-WMF added a project: Collaboration-Team-Triage.Aug 2 2016, 1:45 AM

Jdforrester-WMF mentioned this in T145163: Slim down the "alerts" icon pack to the bare essentials.Sep 9 2016, 12:55 AM

Jdforrester-WMF created subtask T145163: Slim down the "alerts" icon pack to the bare essentials.

Isarra merged a task: T161348: svg icons should have png fallbacks.Mar 25 2017, 4:52 PM

Isarra subscribed.

Isarra merged a task: T161353: Use oojs-ui.Mar 28 2017, 11:23 PM

Isarra added subscribers: Catrope, Paladox.

As the implementer of this hack, I fully agree with the "Ewwww". It was a hack I was pushed into doing at the time for performance reasons, because the icons we needed were scattered across many icon packs, and pulling in all of them would be wasteful. Now that OOUI's icon packs have been reorganized, the situation is hopefully less bad, so I should look at this again.

Volker_E triaged this task as Low priority.Apr 18 2017, 12:44 AM

In order to get rid of badgeicons.json and use OOUI's icons, we'd also need to upstream 'double-check' icon. @Pginer-WMF I guess you are in support of this (it's then also missing in M229 and hasn't been overhauled yet)?

Volker_E updated the task description. (Show Details)Dec 5 2017, 2:30 AM

Volker_E updated the task description. (Show Details)

In T139779#3811383, @Volker_E wrote:

In order to get rid of badgeicons.json and use OOUI's icons, we'd also need to upstream 'double-check' icon. @Pginer-WMF I guess you are in support of this (it's then also missing in M229 and hasn't been overhauled yet)?

The double-check icon is used to communicate the action affects multiple elements, and it is used in "Mark all as done/read" buttons on the notifications page and the New filters beta on the Watchlist. So I think it is useful as its own concept, complementing the single check with a key distinction that helps anticipating the effect of the action. Similar to the done-all icon in Material design.

Regarding the visual style it needs to be adjusted, since we want it to be aligned with the single check. @Volker_E, can you tell me which is the best place to update the icon? Since we are in the middle of the icon update process I want to avoid adding it to an outdated place.

@Pginer-WMF The best place would right now still be M229. It's not perfect from a process perspective coming in later, but it doesn't hurt either to add it there to move forward.

Quiddity unsubscribed.Dec 5 2017, 6:55 PM

Volker_E updated the task description. (Show Details)Dec 6 2017, 1:46 AM

Volker_E mentioned this in T182167: Mark * as read buttons' inner structure have flawed appearance in No-JS.

In T139779#3813695, @Volker_E wrote:

@Pginer-WMF The best place would right now still be M229. It's not perfect from a process perspective coming in later, but it doesn't hurt either to add it there to move forward.

I added an icon for "mark all as done" in the design source file for M229 (it will become visible when updated). That should make it ready to be available in the icon repo at some point. Let me know if anything else is needed.

Volker_E mentioned this in T181108: Reconsider loading icon packs in enableOOUI for optimising critical rendering path.Dec 15 2017, 5:12 AM

Volker_E removed a subtask: T145163: Slim down the "alerts" icon pack to the bare essentials.Dec 22 2017, 9:26 PM

Volker_E added a subtask: T145163: Slim down the "alerts" icon pack to the bare essentials.

matmarex added a subtask: T160690: Be able to request a custom icon pack on-the-fly without bloating RL module registry.Mar 20 2018, 12:45 AM

Volker_E closed subtask T145163: Slim down the "alerts" icon pack to the bare essentials as Resolved.Mar 20 2018, 8:03 PM

I don't think that T160690: Be able to request a custom icon pack on-the-fly without bloating RL module registry is strictly required for this, but it would be a performance improvement if it ever happens.

Upstream 'double-check' icon to OOUI 'interactions' pack

I assume this is 'checkAll', and therefore done

In T139779#4074395, @Esanders wrote:

Upstream 'double-check' icon to OOUI 'interactions' pack

I assume this is 'checkAll', and therefore done

Yes, indeed!

See https://gerrit.wikimedia.org/r/#/c/421427/

That's not on OOUI any more, is ready to be done in Notifications.

Liuxinyu970226 subscribed.Jul 14 2018, 3:42 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 14 2018, 3:42 AM

JTannerWMF moved this task from Inbox to Needs Discussion on the Growth-Team board.Jul 18 2018, 6:32 PM

@Catrope will ask @Mooeypoo if this could be a good GSoC project. Staying in "To Triage" for now until that conversation.

MMiller_WMF assigned this task to Catrope.Aug 7 2018, 6:06 PM

We'll get to this at some point in Q2/Q3/Q4 but in the meantime, volunteer contributions are very welcome!

JTannerWMF moved this task from Upcoming Work to FY 2019-20 on the Growth-Team board.Oct 3 2018, 5:50 PM

JTannerWMF moved this task from FY 2019-20 to Q2 2019-20 on the Growth-Team board.Jan 3 2019, 3:57 PM

JTannerWMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Feb 5 2019, 6:58 PM

JTannerWMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

JTannerWMF moved this task from Ready for Development to Incoming on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 13 2019, 5:53 PM

JTannerWMF edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).Feb 13 2019, 6:24 PM

JTannerWMF moved this task from Q2 2019-20 to Upcoming Work on the Growth-Team board.

JTannerWMF moved this task from Upcoming Work to Sprint 0 (Growth Team) on the Growth-Team board.Mar 20 2019, 6:03 PM

JTannerWMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 20 2019, 11:34 PM

kostajh mentioned this in T219222: Make notification counts update without page reload.Mar 25 2019, 7:47 PM

Catrope updated the task description. (Show Details)Mar 25 2019, 8:03 PM

Unassigning @Catrope as this is a microtask for T219222: Make notification counts update without page reload

Hi @kostajh @Catrope, I will like to work on this issue.
I am a bit unclear as what needs to be done for the first point Replace uses of the ext.echo.badgeicons module with oojs-ui.styles.icons-alerts.
On using grep I can only find two places where this module has been used i.e. in /includes/EchoHooks.php and /includes/special/SpecialNotifications.php.
Do I need to change only those statements for this task?

kostajh edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)), Collaboration-Team-Triage.Apr 1 2019, 5:28 PM

Do I need to change only those statements for this task?

Yes, that sounds right.

JTannerWMF moved this task from Inbox to External on the Growth-Team board.Apr 2 2019, 6:04 PM

Volker_E mentioned this in T219826: Add 'error' icon to 'alerts' icon pack.Apr 3 2019, 4:13 PM

Hi @kostajh, can I work on this?

@Shivanshbindal9 yes please do!

Shivanshbindal9 claimed this task.Apr 13 2019, 1:43 PM

Hi @kostajh, on deleting tray.svgand bell.svg the tray and bell icon from the header also disappears as they are used in /modules/nojs/mw.echo.badge.less. So, should we delete them?

Change 504404 had a related patch set uploaded (by Kosta Harlan; owner: shivanshbindal9):
[mediawiki/extensions/Echo@master] add ooui icons

https://gerrit.wikimedia.org/r/504404

gerritbot added a project: Patch-For-Review.Apr 16 2019, 6:22 PM

Hi @kostajh @Volker_E @Esanders, on deleting tray.svg and bell.svg the tray and bell icon from the header also disappears as they are used in /modules/nojs/mw.echo.badge.less. So, should we delete them and move it in some other folder or is there some other way around?

Change 510211 had a related patch set uploaded (by Shivanshbindal9; owner: shivanshbindal9):
[mediawiki/extensions/Echo@master] add ooui icons and deletes tray.svg and bell.svg from modules

https://gerrit.wikimedia.org/r/510211

Change 504404 abandoned by Kosta Harlan:
add ooui icons

Reason:
Abandoning in favor of I8218530ed2cdd2d81c1fc24509f36ea2b6742bd9

https://gerrit.wikimedia.org/r/504404

Change 510211 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Remove badgeicon module, use OOUI icon instead.

https://gerrit.wikimedia.org/r/510211

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 5 2019, 8:01 PM

matmarex removed a subtask: T160690: Be able to request a custom icon pack on-the-fly without bloating RL module registry.Jun 11 2019, 7:36 PM