Page MenuHomePhabricator
Create Task
Maniphest T182254

Namespace parameters in the url should be shown in the namespace bar
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Bug report
When using a Search-InputBox provided by Extension:InputBox to search for something with the option prefix or namespaces Advanced Search breaks.

Example: Go to https://de.wikipedia.org/wiki/Hilfe:%C3%9Cbersicht an search for something in the archive with the given Search-box. The search will give you the right results but the filters set by the InputBox will not be shown in the Advanced Search-Form. If you click search again you will get different results, ignoring the filters.

Task
When the url contains namespace info, such as "...&ns12=1....", these namespaces are selected in the namespace widget and overwrite the defaults

Acceptance criteria

  • When I reach the specialPage:Search with a url that contains namespace info, this namespace info can also be found in the namespace box.
  • When there is no info in the url, the namespace behavior remains unchanged (i.e. default settings)

Details

SubjectRepoBranchLines +/-
Respect ns… parameters when no namespace state is availablemediawiki/extensions/AdvancedSearchmaster+13 -11
Allow URL preselection of namespacesmediawiki/extensions/AdvancedSearchmaster+65 -5
Customize query in gerrit

Related Objects

Event Timeline

• MichaelSchoenitzer_WMDE created this task.Dec 6 2017, 9:27 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptDec 6 2017, 9:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gabriel-wmde updated the task description. (Show Details)Jan 23 2018, 4:38 PM
Lea_WMDE moved this task from Backlog to Tickets ready for pickup on the Advanced-Search board.Feb 15 2018, 10:28 AM
• Tonina_Zhelyazkova_WMDE moved this task from Tickets ready for pickup to Backlog on the Advanced-Search board.Feb 21 2018, 1:35 PM
gerritbot subscribed.Feb 22 2018, 1:56 PM

Change 413365 had a related patch set uploaded (by Gabriel Birke; owner: Gabriel Birke):
[mediawiki/extensions/AdvancedSearch@master] Allow URL preselection of namespaces

https://gerrit.wikimedia.org/r/413365

gerritbot added a project: Patch-For-Review.Feb 22 2018, 1:56 PM
gabriel-wmde mentioned this in rEASR260b19a38403: Allow URL preselection of namespaces.Feb 22 2018, 1:57 PM
gabriel-wmde subscribed.EditedFeb 22 2018, 2:04 PM

I stumbled upon this and the solution seemed so straightforward to me, I wrote a PR for it. Together with T172260: Default namespaces is what has been defined in user preferences we now have the following behavior when coming to the search page from another page:

  1. If the URL contains namespace ids, these namespaces will be preselected.
  2. If the user has namespace preferences set, they will be preselected
  3. The main namespace will be preselected.

The option to define namespaces selection via URL might be even more complicated if we consider T187911: Fallback namespaces are what has been defined in user preferences - what happens if the "All" preset is deselected, causing the form to fall back to some "default" state. When we have 3 possible defaults, which one will it be?

Aklapper renamed this task from Advanced Search incompatible with InputBox-Extension to Advanced Search incompatible with InputBox extension.Feb 22 2018, 2:42 PM
Charlie_WMDE subscribed.Feb 26 2018, 11:37 AM

I talked to @Lea_WMDE and these are our thoughts on your points:

  1. If the URL contains namespace ids, these namespaces will be preselected.

This is what we'd like to happen

  1. If the user has namespace preferences set, they will be preselected

This should only happen when there's nothing else selected, so if point 1 is valid then the default selection is ignored.

  1. The main namespace will be preselected.

This would happen when neither of the first two points are valid so no preselection from either preferences or somewhere else. Also some wikis have multiple namespaces set as default like commons for example so we should talk about default namespaces and not the main namespace.

Screenshot_20180226_122958.png (508×1 px, 49 KB)

there will be an extra ticket for this behavior.

The option to define namespaces selection via URL might be even more complicated if we consider T187911: Fallback namespaces are what has been defined in user preferences - what happens if the "All" preset is deselected, causing the form to fall back to some "default" state. When we have 3 possible defaults, which one will it be?

There is a ticket for this which the UX-Team currently works on.

Lea_WMDE triaged this task as Medium priority.Feb 26 2018, 11:45 AM
Lea_WMDE updated the task description. (Show Details)
Lea_WMDE moved this task from Backlog to Tickets ready for pickup on the Advanced-Search board.
Lea_WMDE updated the task description. (Show Details)Feb 28 2018, 1:58 PM
Lea_WMDE added a project: WMDE-Fundraising-Sprint-18.Feb 28 2018, 2:05 PM
Lea_WMDE set the point value for this task to 3.
Lea_WMDE moved this task from Tickets ready for pickup to In FUN sprint on the Advanced-Search board.
gabriel-wmde mentioned this in rEASR3542073d5e95: [WIP] Allow URL preselection of namespaces.Mar 2 2018, 9:18 AM
• Pablo-WMDE mentioned this in T188493: On redirect, parts of the search query are not filled into the main search bar.Mar 5 2018, 4:36 PM
Lea_WMDE renamed this task from Advanced Search incompatible with InputBox extension to Namespace parameters in the url should be shown in the namespace bar.Mar 7 2018, 1:24 PM
Lea_WMDE added a project: wmde-fundraising-sprint-19.Mar 7 2018, 1:34 PM
gabriel-wmde claimed this task.Mar 12 2018, 11:05 AM
gabriel-wmde moved this task from Todo to Doing on the wmde-fundraising-sprint-19 board.
gabriel-wmde mentioned this in rEASRb2e26cf5d3a9: Allow URL preselection of namespaces.Mar 12 2018, 11:23 AM
gabriel-wmde mentioned this in rEASR224abec43cc9: Allow URL preselection of namespaces.Mar 12 2018, 11:27 AM
gabriel-wmde mentioned this in rEASRa582a3e4d6e5: Allow URL preselection of namespaces.Mar 12 2018, 3:22 PM
gabriel-wmde removed gabriel-wmde as the assignee of this task.Mar 12 2018, 3:27 PM
gabriel-wmde moved this task from Doing to Review on the wmde-fundraising-sprint-19 board.
gerritbot added a comment.Mar 15 2018, 2:54 PM

Change 419743 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/AdvancedSearch@master] Respect ns… parameters when no namespace state is available

https://gerrit.wikimedia.org/r/419743

thiemowmde mentioned this in rEASR2943b1e89c54: Respect ns… parameters when no namespace state is available.Mar 15 2018, 2:55 PM
gerritbot added a comment.Mar 15 2018, 3:05 PM

Change 413365 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Allow URL preselection of namespaces

https://gerrit.wikimedia.org/r/413365

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)).Mar 15 2018, 4:01 PM
gerritbot added a comment.Mar 15 2018, 5:23 PM

Change 419743 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Respect ns… parameters when no namespace state is available

https://gerrit.wikimedia.org/r/419743

• Tonina_Zhelyazkova_WMDE moved this task from Review to Deploy to Test on the wmde-fundraising-sprint-19 board.Mar 15 2018, 5:57 PM
• Tonina_Zhelyazkova_WMDE moved this task from Deploy to Test to Test on the wmde-fundraising-sprint-19 board.Mar 19 2018, 8:48 AM
Lea_WMDE moved this task from Test to Deploy on the wmde-fundraising-sprint-19 board.Mar 19 2018, 9:16 AM
• Tonina_Zhelyazkova_WMDE moved this task from Deploy to Done on the wmde-fundraising-sprint-19 board.Mar 21 2018, 8:58 AM
Lea_WMDE closed this task as Resolved.Mar 23 2018, 12:23 PM
thiemowmde mentioned this in rEASR1be593022134: Update patch set 1.Jun 8 2018, 9:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL