Page MenuHomePhabricator
Create Task
Maniphest T184636

[wmf.17 - regression] Edit post page shows no-js reply link
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Screen Shot 2018-01-10 at 13.42.51.png (473×777 px, 49 KB)

In testwiki SD board topic make a double-click on any Reply - the permalink for the topic will be displayed with the text area looking as in no-js mode.

Uncaught TypeError: Cannot read property 'focus' of undefined
    at VeCeMwWikitextSurface.ve.ce.Surface.focus (VM4559 load.php?debug=false&lang=en&modules=ext.CodeMirror.lib|ext.visualEditor.core%2Cdata&skin=vector&version=1ssfeb4:669)
    at mwFlowUiEditorWidget.mw.flow.ui.EditorWidget.focus (<anonymous>:420:775)
    at mwFlowUiReplyWidget.mw.flow.ui.ReplyWidget.focus (<anonymous>:388:681)
    at HTMLAnchorElement.<anonymous> (<anonymous>:494:595)
    at HTMLDivElement.dispatch (VM4534 load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=14kbqyi:69)
    at HTMLDivElement.elemData.handle (VM4534 load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=14kbqyi:66)

And there are other UI manifestations of the error

  • not having the topic title in Reply to ""
  • another reply area is open and no buttons are dispalyed

Screen Shot 2018-01-16 at 3.53.16 PM.png (428×837 px, 77 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (d5044cd1d)mediawiki/extensions/VisualEditormaster+1 -1
ve.ce.Surface: Refuse to focus when disabledVisualEditor/VisualEditormaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

SBisson created this task.Jan 10 2018, 6:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 10 2018, 6:47 PM
Trizek-WMF subscribed.Jan 11 2018, 10:38 AM

Can't reproduce on test wikis. Have you disabled the 2017 wikitext editor in your preferences, Editing tab (Enable the visual editor and the new wikitext mode in Structured Discussions)?

SBisson added a comment.Jan 12 2018, 1:18 PM

I can reproduce this in beta and frwiki.

I'm not sure it's a regression, maybe it has always been there. I filed it mostly so it can be clarified.

Etonkovidova renamed this task from Edit post page shows no-js reply link to [wmf.17 - regression] Edit post page shows no-js reply link.Jan 17 2018, 12:13 AM
Etonkovidova updated the task description. (Show Details)
Etonkovidova edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Etonkovidova subscribed.Jan 17 2018, 12:16 AM

It's certainly a regression - I've updated the description and moved it to Collab-Team-Triage(Collab-Team-This-Quarter board.

Etonkovidova updated the task description. (Show Details)Jan 17 2018, 12:18 AM
Etonkovidova moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jan 18 2018, 7:30 PM
• Mattflaschen-WMF subscribed.Jan 19 2018, 7:24 AM

I think at one point we didn't include JavaScript on secondary pages (which are intended for no-JS users anyway) to avoid such issues.

gerritbot subscribed.Apr 4 2018, 1:45 AM

Change 423822 had a related patch set uploaded (by Catrope; owner: Catrope):
[VisualEditor/VisualEditor@master] ve.ce.Surface: Refuse to focus when disabled

https://gerrit.wikimedia.org/r/423822

gerritbot added a project: Patch-For-Review.Apr 4 2018, 1:45 AM
gerritbot added a comment.Apr 4 2018, 3:36 PM

Change 423822 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ce.Surface: Refuse to focus when disabled

https://gerrit.wikimedia.org/r/423822

SBisson assigned this task to Catrope.Apr 4 2018, 3:39 PM
SBisson moved this task from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
gerritbot added a comment.Apr 4 2018, 3:40 PM

Change 423941 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d5044cd1d)

https://gerrit.wikimedia.org/r/423941

gerritbot added a comment.Apr 4 2018, 3:57 PM

Change 423941 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d5044cd1d)

https://gerrit.wikimedia.org/r/423941

Jdforrester-WMF edited projects, added VisualEditor (Current work); removed Patch-For-Review.Apr 4 2018, 4:41 PM
Jdforrester-WMF moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.
Etonkovidova closed this task as Resolved.Apr 6 2018, 4:55 PM

Checked in betalabs - the fix works.

• Deskana set the point value for this task to 1.Apr 9 2018, 12:17 PM
• 238482n375 removed Catrope as the assignee of this task.Jun 15 2018, 8:03 AM
• 238482n375 triaged this task as Lowest priority.
• 238482n375 moved this task from Next Up to In Code Review on the Analytics-Kanban board.
• 238482n375 added projects: Analytics-Kanban, acl*security, Wikimedia-VE-Campaigns (S2-2018), Scap (Scap3-Adoption-Phase2), AbuseFilter, Data-release, Hashtags, LabsDB-Auditor, Ladies-That-FOSS-MediaWiki, Language-2018-Apr-June, Language-2018-Jan-Mar, HHVM, HAWelcome.
• 238482n375 edited subscribers, added: • 238482n375; removed: Aklapper.

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpUYWdzCgogICAgQW5hbHl0aWNzLUthbmJhbiAoSW4gUHJvZ3Jlc3MpCgpTdWJzY3JpYmVycwpBa2xhcHBlciwgSkFsbGVtYW5kb3UKQXNzaWduZWQgVG8KSkFsbGVtYW5kb3UKQXV0aG9yZWQgQnkKSkFsbGVtYW5kb3UsIEZyaSwgSnVuIDE1CkRlc2NyaXB0aW9uCgpPb3ppZSBqb2JzIGhhdmUgYmVlbiBmYWlsaW5nIGF0IGxlYXN0IGEgZmV3IHRpbWVzIGVhY2guIE1vcmUgaW52ZXN0aWdhdGlvbiBuZWVkZWQuCkpBbGxlbWFuZG91IGNyZWF0ZWQgdGhpcyB0YXNrLkZyaSwgSnVuIDE1LCA3OjIxIEFNCkhlcmFsZCBhZGRlZCBhIHN1YnNjcmliZXI6IEFrbGFwcGVyLiC3IFZpZXcgSGVyYWxkIFRyYW5zY3JpcHRGcmksIEp1biAxNSwgNzoyMSBBTQpKQWxsZW1hbmRvdSBjbGFpbWVkIHRoaXMgdGFzay5GcmksIEp1biAxNSwgNzoyMiBBTQpKQWxsZW1hbmRvdSB1cGRhdGVkIHRoZSB0YXNrIGRlc2NyaXB0aW9uLiAoU2hvdyBEZXRhaWxzKQpKQWxsZW1hbmRvdSBhZGRlZCBhIHByb2plY3Q6IEFuYWx5dGljcy1LYW5iYW4uCkpBbGxlbWFuZG91IG1vdmVkIHRoaXMgdGFzayBmcm9tIE5leHQgVXAgdG8gSW4gUHJvZ3Jlc3Mgb24gdGhlIEFuYWx5dGljcy1LYW5iYW4gYm9hcmQuCkNoYW5nZSBTdWJzY3JpYmVycwpDaGFuZ2UgUHJpb3JpdHkKQXNzaWduIC8gQ2xhaW0KTW92ZSBvbiBXb3JrYm9hcmQKQ2hhbmdlIFByb2plY3QgVGFncwpBbmFseXRpY3MtS2FuYmFuCtcKU2VjdXJpdHkK1wpXaWtpbWVkaWEtVkUtQ2FtcGFpZ25zIChTMi0yMDE4KQrXClNjYXAK1wpTY2FwIChTY2FwMy1BZG9wdGlvbi1QaGFzZTIpCtcKQWJ1c2VGaWx0ZXIK1wpEYXRhLXJlbGVhc2UK1wpIYXNodGFncwrXCkxhYnNEQi1BdWRpdG9yCtcKTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2kK1wpMYW5ndWFnZS0yMDE4LUFwci1KdW5lCtcKTGFuZ3VhZ2UtMjAxOC1KYW4tTWFyCtcKSEhWTQrXCkhBV2VsY29tZQrXCkJvbGQKSXRhbGljcwpNb25vc3BhY2VkCkxpbmsKQnVsbGV0ZWQgTGlzdApOdW1iZXJlZCBMaXN0CkNvZGUgQmxvY2sKUXVvdGUKVGFibGUKVXBsb2FkIEZpbGUKTWVtZQpQcmV2aWV3CkhlbHAKRnVsbHNjcmVlbiBNb2RlClBpbiBGb3JtIE9uIFNjcmVlbgoyMzg0ODJuMzc1IGFkZGVkIHByb2plY3RzOiBTZWN1cml0eSwgV2lraW1lZGlhLVZFLUNhbXBhaWducyAoUzItMjAxOCksIFNjYXAgKFNjYXAzLUFkb3B0aW9uLVBoYXNlMiksIEFidXNlRmlsdGVyLCBEYXRhLXJlbGVhc2UsIEhhc2h0YWdzLCBMYWJzREItQXVkaXRvciwgTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2ksIExhbmd1YWdlLTIwMTgtQXByLUp1bmUsIExhbmd1YWdlLTIwMTgtSmFuLU1hciwgSEhWTSwgSEFXZWxjb21lLlBSRVZJRVcKMjM4NDgybjM3NSBtb3ZlZCB0aGlzIHRhc2sgZnJvbSBJbiBQcm9ncmVzcyB0byBJbiBDb2RlIFJldmlldyBvbiB0aGUgQW5hbHl0aWNzLUthbmJhbiBib2FyZC4KMjM4NDgybjM3NSByZW1vdmVkIEpBbGxlbWFuZG91IGFzIHRoZSBhc3NpZ25lZSBvZiB0aGlzIHRhc2suCjIzODQ4Mm4zNzUgdHJpYWdlZCB0aGlzIHRhc2sgYXMgTG93ZXN0IHByaW9yaXR5LgoyMzg0ODJuMzc1IHJlbW92ZWQgc3Vic2NyaWJlcnM6IEFrbGFwcGVyLCBKQWxsZW1hbmRvdS4KQ29udGVudCBsaWNlbnNlZCB1bmRlciBDcmVhdGl2ZSBDb21tb25zIEF0dHJpYnV0aW9uLVNoYXJlQWxpa2UgMy4wIChDQy1CWS1TQSkgdW5sZXNzIG90aGVyd2lzZSBub3RlZDsgY29kZSBsaWNlbnNlZCB1bmRlciBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSAoR1BMKSBvciBvdGhlciBvcGVuIHNvdXJjZSBsaWNlbnNlcy4gQnkgdXNpbmcgdGhpcyBzaXRlLCB5b3UgYWdyZWUgdG8gdGhlIFRlcm1zIG9mIFVzZSwgUHJpdmFjeSBQb2xpY3ksIGFuZCBDb2RlIG9mIENvbmR1Y3QuILcgV2lraW1lZGlhIEZvdW5kYXRpb24gtyBQcml2YWN5IFBvbGljeSC3IENvZGUgb2YgQ29uZHVjdCC3IFRlcm1zIG9mIFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

Aklapper assigned this task to Catrope.Jun 15 2018, 11:20 AM
Aklapper raised the priority of this task from Lowest to Needs Triage.
Aklapper removed projects: HAWelcome, HHVM, Language-2018-Jan-Mar, Language-2018-Apr-June, Ladies-That-FOSS-MediaWiki, LabsDB-Auditor, Hashtags, Data-release, AbuseFilter, Scap (Scap3-Adoption-Phase2), Wikimedia-VE-Campaigns (S2-2018), acl*security, Analytics-Kanban.Jun 15 2018, 11:22 AM
Aklapper edited subscribers, added: Aklapper; removed: • 238482n375.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL