Page MenuHomePhabricator
Create Task
Maniphest T184669

Fetching incorrect description data from the Feed API
Closed, ResolvedPublic
Actions

Description

It only happens on zh-wiki API

The description of Picture of the day in 2018/01/10 shows only <

Screenshot at Jan 10 16-27-29.png (311×1 px, 61 KB)

Source: https://commons.wikimedia.org/wiki/File:Das_Motorrad_mit_den_Skiern_von_der_Seite_-_CH-BAR_-_3241064.tif

API: https://zh.wikipedia.org/api/rest_v1/feed/featured/2018/01/10

Details

ProjectBranchLines +/-Subject
mediawiki/services/mobileappsmaster+48 -30Feed: Always use a POTD caption as the featured image description
Customize query in gerrit

Related Objects

Event Timeline

cooltey created this task.Jan 11 2018, 12:35 AM
Restricted Application added a project: Product-Infrastructure-Team-Backlog-Deprecated. · View Herald TranscriptJan 11 2018, 12:35 AM
Restricted Application added subscribers: Stang, Aklapper. · View Herald Transcript
• Mholloway claimed this task.Jan 11 2018, 1:56 AM
• Mholloway edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Multimedia, Product-Infrastructure-Team-Backlog-Deprecated.
• Mholloway moved this task from To Do to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
gerritbot added a subscriber: gerritbot.Jan 11 2018, 1:58 AM

Change 403575 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/services/mobileapps@master] Guard against unexpected ImageDescription extmetadata values

https://gerrit.wikimedia.org/r/403575

gerritbot added a project: Patch-For-Review.Jan 11 2018, 1:58 AM
Tgr added a subscriber: Tgr.Jan 11 2018, 2:53 AM

The API response:

"ImageDescription": {
    "value": "<span class=\"description\">\n<span class=\"language de\"><b>Das Motorrad mit den Skiern von der Seite</b><br>Darin: Transport Dienst<br>Original: Negativ; Glasplatte; Silberbromid; 13x18cm<br>Signatur: CH-BAR#E27#1000/721#14095#5045*</span></span>",
    "source": "commons-desc-page"
}

(same with or without iiextmetadatamultilang). So not an EXIF issue actually.

Tgr added a comment.Jan 11 2018, 3:09 AM

This is a combination of T59846: Multilang mode should always return a list of languages and Template:CH-BAR-picture having some hand-mucked language markup which is different from language markup elsewhere so CommonsMetadata does not pick it up as such. (See also this thread for context.) So not really a bug on the MW side (although T59846 was certainly bad API design).

• Mholloway added a project: Multimedia.Jan 11 2018, 12:46 PM
• bearND added a subscriber: • bearND.EditedJan 15 2018, 5:53 PM

Hmm, https://commons.wikimedia.org/w/index.php?title=Commons:Picture_of_the_day/all_languages&action=submit#10 or https://commons.wikimedia.org/wiki/Template:Potd/2018-01-10_(en) has multiple languages but https://commons.wikimedia.org/w/api.php?action=query&format=json&formatversion=2&generator=images&prop=imageinfo%7Crevisions&iiextmetadatafilter=ImageDescription&iiextmetadatamultilang=true&iiprop=url%7Cextmetadata%7Cdimensions&iiurlwidth=640&rawcontinue=&titles=Template%3APotd%2F2018-01-10&continue= shows the caption.

• Mholloway added a comment.Jan 16 2018, 8:46 PM

@bearND, Yep, I think the POTD captions (as seen on Template:Potd and sub-templates) are completely separate from the general image description metadata picked up as ImageDescription.

The more I think about it, the more I agree with @Tgr's comment on that the POTD captions are actually what we should be using. So I've updated that patch to use a POTD caption in all cases.

• Ramsey-WMF moved this task from Untriaged to Tracking on the Multimedia board.Jan 17 2018, 6:06 PM
• Ramsey-WMF added a subscriber: • Ramsey-WMF.

I'll be keeping this in mind as we spec out Structured Data changes.

gerritbot added a comment.Jan 18 2018, 5:35 PM

Change 403575 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Feed: Always use a POTD caption as the featured image description

https://gerrit.wikimedia.org/r/403575

Stashbot mentioned this in T184328: Add revision + tid to references output.Jan 18 2018, 6:40 PM
Stashbot mentioned this in T177007: Should we flatten spans in summary output.
Stashbot added a subscriber: Stashbot.

Mentioned in SAL (#wikimedia-operations) [2018-01-18T18:40:32Z] <bsitzmann@tin> Started deploy [mobileapps/deploy@669fb5b]: Update mobileapps to 2690899 (T184328 T184557 T177007 T184669 T177430 T185050)

Stashbot mentioned this in T177430: Develop a Media JSON API.Jan 18 2018, 6:40 PM
Stashbot mentioned this in T185050: Run comparison of html extracts again.
Stashbot added a comment.Jan 18 2018, 6:47 PM

Mentioned in SAL (#wikimedia-operations) [2018-01-18T18:47:35Z] <bsitzmann@tin> Finished deploy [mobileapps/deploy@669fb5b]: Update mobileapps to 2690899 (T184328 T184557 T177007 T184669 T177430 T185050) (duration: 07m 03s)

• Mholloway moved this task from Code Review to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jan 18 2018, 8:59 PM
• bearND closed this task as Resolved.Jan 18 2018, 11:25 PM

Now it shows the correct description.

cooltey awarded a token.Jan 18 2018, 11:29 PM
• 238482n375 removed • Mholloway as the assignee of this task.Jun 15 2018, 8:04 AM
• 238482n375 triaged this task as Lowest priority.
• 238482n375 moved this task from Next Up to In Code Review on the Analytics-Kanban board.
• 238482n375 added projects: Analytics-Kanban, acl*security, Wikimedia-VE-Campaigns (S2-2018), Scap (Scap3-Adoption-Phase2), AbuseFilter, Data-release, Hashtags, LabsDB-Auditor, Ladies-That-FOSS-MediaWiki, Language-2018-Apr-June, Language-2018-Jan-Mar, HHVM, HAWelcome.
• 238482n375 edited subscribers, added: • Mholloway, • 238482n375; removed: Aklapper.

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpUYWdzCgogICAgQW5hbHl0aWNzLUthbmJhbiAoSW4gUHJvZ3Jlc3MpCgpTdWJzY3JpYmVycwpBa2xhcHBlciwgSkFsbGVtYW5kb3UKQXNzaWduZWQgVG8KSkFsbGVtYW5kb3UKQXV0aG9yZWQgQnkKSkFsbGVtYW5kb3UsIEZyaSwgSnVuIDE1CkRlc2NyaXB0aW9uCgpPb3ppZSBqb2JzIGhhdmUgYmVlbiBmYWlsaW5nIGF0IGxlYXN0IGEgZmV3IHRpbWVzIGVhY2guIE1vcmUgaW52ZXN0aWdhdGlvbiBuZWVkZWQuCkpBbGxlbWFuZG91IGNyZWF0ZWQgdGhpcyB0YXNrLkZyaSwgSnVuIDE1LCA3OjIxIEFNCkhlcmFsZCBhZGRlZCBhIHN1YnNjcmliZXI6IEFrbGFwcGVyLiC3IFZpZXcgSGVyYWxkIFRyYW5zY3JpcHRGcmksIEp1biAxNSwgNzoyMSBBTQpKQWxsZW1hbmRvdSBjbGFpbWVkIHRoaXMgdGFzay5GcmksIEp1biAxNSwgNzoyMiBBTQpKQWxsZW1hbmRvdSB1cGRhdGVkIHRoZSB0YXNrIGRlc2NyaXB0aW9uLiAoU2hvdyBEZXRhaWxzKQpKQWxsZW1hbmRvdSBhZGRlZCBhIHByb2plY3Q6IEFuYWx5dGljcy1LYW5iYW4uCkpBbGxlbWFuZG91IG1vdmVkIHRoaXMgdGFzayBmcm9tIE5leHQgVXAgdG8gSW4gUHJvZ3Jlc3Mgb24gdGhlIEFuYWx5dGljcy1LYW5iYW4gYm9hcmQuCkNoYW5nZSBTdWJzY3JpYmVycwpDaGFuZ2UgUHJpb3JpdHkKQXNzaWduIC8gQ2xhaW0KTW92ZSBvbiBXb3JrYm9hcmQKQ2hhbmdlIFByb2plY3QgVGFncwpBbmFseXRpY3MtS2FuYmFuCtcKU2VjdXJpdHkK1wpXaWtpbWVkaWEtVkUtQ2FtcGFpZ25zIChTMi0yMDE4KQrXClNjYXAK1wpTY2FwIChTY2FwMy1BZG9wdGlvbi1QaGFzZTIpCtcKQWJ1c2VGaWx0ZXIK1wpEYXRhLXJlbGVhc2UK1wpIYXNodGFncwrXCkxhYnNEQi1BdWRpdG9yCtcKTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2kK1wpMYW5ndWFnZS0yMDE4LUFwci1KdW5lCtcKTGFuZ3VhZ2UtMjAxOC1KYW4tTWFyCtcKSEhWTQrXCkhBV2VsY29tZQrXCkJvbGQKSXRhbGljcwpNb25vc3BhY2VkCkxpbmsKQnVsbGV0ZWQgTGlzdApOdW1iZXJlZCBMaXN0CkNvZGUgQmxvY2sKUXVvdGUKVGFibGUKVXBsb2FkIEZpbGUKTWVtZQpQcmV2aWV3CkhlbHAKRnVsbHNjcmVlbiBNb2RlClBpbiBGb3JtIE9uIFNjcmVlbgoyMzg0ODJuMzc1IGFkZGVkIHByb2plY3RzOiBTZWN1cml0eSwgV2lraW1lZGlhLVZFLUNhbXBhaWducyAoUzItMjAxOCksIFNjYXAgKFNjYXAzLUFkb3B0aW9uLVBoYXNlMiksIEFidXNlRmlsdGVyLCBEYXRhLXJlbGVhc2UsIEhhc2h0YWdzLCBMYWJzREItQXVkaXRvciwgTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2ksIExhbmd1YWdlLTIwMTgtQXByLUp1bmUsIExhbmd1YWdlLTIwMTgtSmFuLU1hciwgSEhWTSwgSEFXZWxjb21lLlBSRVZJRVcKMjM4NDgybjM3NSBtb3ZlZCB0aGlzIHRhc2sgZnJvbSBJbiBQcm9ncmVzcyB0byBJbiBDb2RlIFJldmlldyBvbiB0aGUgQW5hbHl0aWNzLUthbmJhbiBib2FyZC4KMjM4NDgybjM3NSByZW1vdmVkIEpBbGxlbWFuZG91IGFzIHRoZSBhc3NpZ25lZSBvZiB0aGlzIHRhc2suCjIzODQ4Mm4zNzUgdHJpYWdlZCB0aGlzIHRhc2sgYXMgTG93ZXN0IHByaW9yaXR5LgoyMzg0ODJuMzc1IHJlbW92ZWQgc3Vic2NyaWJlcnM6IEFrbGFwcGVyLCBKQWxsZW1hbmRvdS4KQ29udGVudCBsaWNlbnNlZCB1bmRlciBDcmVhdGl2ZSBDb21tb25zIEF0dHJpYnV0aW9uLVNoYXJlQWxpa2UgMy4wIChDQy1CWS1TQSkgdW5sZXNzIG90aGVyd2lzZSBub3RlZDsgY29kZSBsaWNlbnNlZCB1bmRlciBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSAoR1BMKSBvciBvdGhlciBvcGVuIHNvdXJjZSBsaWNlbnNlcy4gQnkgdXNpbmcgdGhpcyBzaXRlLCB5b3UgYWdyZWUgdG8gdGhlIFRlcm1zIG9mIFVzZSwgUHJpdmFjeSBQb2xpY3ksIGFuZCBDb2RlIG9mIENvbmR1Y3QuILcgV2lraW1lZGlhIEZvdW5kYXRpb24gtyBQcml2YWN5IFBvbGljeSC3IENvZGUgb2YgQ29uZHVjdCC3IFRlcm1zIG9mIFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

Aklapper raised the priority of this task from Lowest to Needs Triage.Jun 15 2018, 12:44 PM
Aklapper removed projects: HAWelcome, HHVM, Language-2018-Jan-Mar, Language-2018-Apr-June, Ladies-That-FOSS-MediaWiki, LabsDB-Auditor, Hashtags, Data-release, AbuseFilter, Scap (Scap3-Adoption-Phase2), Wikimedia-VE-Campaigns (S2-2018), acl*security, Analytics-Kanban.
Aklapper edited subscribers, added: Aklapper; removed: • 238482n375.
Aklapper assigned this task to • Mholloway.Jun 15 2018, 12:47 PM
• Mholloway mentioned this in T215708: Translateable Pictures of day on Commons.Feb 11 2019, 8:10 PM
Stang removed a subscriber: Stang.Nov 13 2021, 9:23 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 13 2021, 10:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL