Page MenuHomePhabricator
Create Task
Maniphest T185279

Linter isn't highlighting text in 2017 WTE anymore
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

I was out of office for a week, so I'm not sure this happened in the deploy this week or one last week, but 2017 wikitext editor no longer highlights the error when you click a lint error edit link in Firefox 57.0.4 on either Windows 7 or 10. More precisely, it does seem to highlight but then disappears.

Steps to reproduce:

  1. Enable NWE in preferences
  2. Go to e.g. https://en.wikipedia.org/wiki/Special:LintErrors/wikilink-in-extlink?namespace=0 and follow one of the "edit" links in the table

When the editor loads, it should select some text on the page, and scroll it into view.

Details

SubjectRepoBranchLines +/-
Handle VisualEditor when it skips the "tempWikitextEditor" stagemediawiki/extensions/Lintermaster+16 -11
Fix VisualEditor (NWE) integrationmediawiki/extensions/Lintermaster+1 -1
Fix NWE integration to use new tempWikitextEditormediawiki/extensions/Lintermaster+3 -13
Public API for the tempWikitextEditormediawiki/extensions/VisualEditormaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Izno created this task.Jan 19 2018, 12:52 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJan 19 2018, 12:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Izno added a comment.Jan 19 2018, 2:29 PM

This might be a Timeless thing too/instead; I haven't check vector.

ShakespeareFan00 mentioned this in T185085: Show EXACT markup or diff in Linter report so that it's possible to actually find the error when highlighting fails....Jan 21 2018, 10:56 AM
gerritbot subscribed.Jan 22 2018, 6:28 PM

Change 405746 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Public API for the tempWikitextEditor

https://gerrit.wikimedia.org/r/405746

gerritbot added a project: Patch-For-Review.Jan 22 2018, 6:28 PM

Change 405747 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Linter@master] Fix NWE integration to use new tempWikitextEditor

https://gerrit.wikimedia.org/r/405747

• Esanders mentioned this in rELINT6e379107c38a: Fix NWE integration to use new tempWikitextEditor.Jan 22 2018, 6:32 PM
gerritbot added a comment.Jan 24 2018, 12:53 AM

Change 405746 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Public API for the tempWikitextEditor

https://gerrit.wikimedia.org/r/405746

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 24 2018, 1:01 AM
gerritbot added a comment.Jan 29 2018, 5:22 PM

Change 405747 merged by jenkins-bot:
[mediawiki/extensions/Linter@master] Fix NWE integration to use new tempWikitextEditor

https://gerrit.wikimedia.org/r/405747

Jdforrester-WMF closed this task as Resolved.Jan 29 2018, 5:28 PM
Jdforrester-WMF assigned this task to • Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 29 2018, 5:28 PM
Izno added subscribers: • ssastry, Jdforrester-WMF.Apr 11 2018, 10:14 PM

@Esanders @Jdforrester-WMF @ssastry I'm still unable to get the lint error. Now, however, I don't have

More precisely, it does seem to highlight but then disappears.

occurring. WTE2017 loads and there's no other indication that it knows about a lint error in any way.

Stryn reopened this task as Open.Apr 25 2018, 3:42 PM
Stryn subscribed.

I can confirm. ^

• Deskana lowered the priority of this task from Medium to Low.Aug 30 2018, 10:02 AM
• Deskana moved this task from TR0: Interrupt to Freezer on the VisualEditor board.
matmarex claimed this task.Jun 11 2019, 3:27 PM
matmarex added a subscriber: • Esanders.
gerritbot added a comment.Jun 11 2019, 3:30 PM

Change 516505 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Linter@master] Fix VisualEditor (NWE) integration

https://gerrit.wikimedia.org/r/516505

gerritbot added a project: Patch-For-Review.Jun 11 2019, 3:30 PM

Change 516506 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Linter@master] Handle VisualEditor when it skips the "tempWikitextEditor" stage

https://gerrit.wikimedia.org/r/516506

matmarex mentioned this in rELINT6d0c6b673023: Fix VisualEditor (NWE) integration.Jun 11 2019, 3:35 PM
matmarex mentioned this in rELINTa51f750f83b8: Handle VisualEditor when it skips the "tempWikitextEditor" stage.
gerritbot added a comment.Jun 11 2019, 4:51 PM

Change 516505 merged by jenkins-bot:
[mediawiki/extensions/Linter@master] Fix VisualEditor (NWE) integration

https://gerrit.wikimedia.org/r/516505

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 11 2019, 7:00 PM
gerritbot added a comment.Jun 26 2019, 8:18 PM

Change 516506 merged by jenkins-bot:
[mediawiki/extensions/Linter@master] Handle VisualEditor when it skips the "tempWikitextEditor" stage

https://gerrit.wikimedia.org/r/516506

matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.Jun 26 2019, 8:20 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.13; 2019-07-09); removed MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 26 2019, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 26 2019, 9:10 PM
matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.Jun 26 2019, 9:34 PM
matmarex added a project: Editing QA.Jul 1 2019, 4:35 PM
matmarex updated the task description. (Show Details)Jul 1 2019, 4:40 PM
matmarex moved this task from Inbox to Low Priority on the Editing QA board.Jul 1 2019, 4:45 PM
matmarex moved this task from QA to Product owner review on the VisualEditor (Current work) board.Aug 9 2019, 5:00 PM
matmarex edited projects, added Skipped QA; removed Editing QA.
ppelberg closed this task as Resolved.Sep 3 2019, 1:25 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits