[BUG] Some content is not rendering correctly in the Quick box / Info box on Android web view
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RHo
	Feb 2 2018, 8:50 PM

Description

Certain content in the info box is getting cut off, appears to be whenever a media player is in an info box on Android.
First reported via OTRS: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=10554532

Steps to reproduce

Go to the article Provincias Unidas del Centro de América
Open the quick/info box
Go to another article Tear down this wall!
Open the quick/info box

Expected

In steps 2 and 4, the media controls are shown not obscured/obscuring other content

Expected step 2 - play and download controls are shown below text

Expected step 4 - "Play media" is shown

Note that it is appearing as expected in the mweb and iOS app versions of these pages.

Actual

Media controls overlaps text in step 2, "Play media" not visible in step 4

Actual step 2

Actual step 4

Occurring on

Wikipedia v2.7.224-alpha-2018-01-26

Details

	Subject	Repo	Branch	Lines +/-
	Increase the default height mw:Audio to 32px	mediawiki/services/parsoid	master	+24 -11

Customize query in gerrit

Related Objects

Mentioned In: T198504: [BUG] Audio file shows incomplete toolbar in an article page
T192909: Dirty diff and other weird corruption in table edit
T191700: VE: Avoid piping links for formatting where possible
T133673: Add width/height attributes to the <audio><video> tag
Mentioned Here: rGPAR50b0588a8f45: Update sitematrix
T191700: VE: Avoid piping links for formatting where possible
T192909: Dirty diff and other weird corruption in table edit
T133673: Add width/height attributes to the <audio><video> tag
T167600: Audio files DOM is not really useful in Parsoid output

Event Timeline

RHo created this task.Feb 2 2018, 8:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2018, 8:50 PM

Pabloab subscribed.Feb 2 2018, 9:48 PM

Thanks Rita! I sent the first report from mobile app. On my device (Samsung Galaxy S5 with Android 6.0.1) the situation is much worst. Here is a screenshot what I see:

Screenshot_2018-01-31-15-03-23.png (1×1 px, 227 KB)

If I try to reproduce the bug with Chrome developer console > mobile view > Galaxy S5 the renderization is bad but not so terrible as actually is on the real device.
Is not necessary to clic the infobox, just scroll and there it is, cropped.

• Charlotte added projects: Parsoid-Rendering, Parsoid.Feb 7 2018, 5:32 PM

• Charlotte added a project: Page Content Service.

Restricted Application added a project: Product-Infrastructure-Team-Backlog-Deprecated. · View Herald TranscriptFeb 7 2018, 5:33 PM

• Charlotte moved this task from Needs Triage to Tracking on the Wikipedia-Android-App-Backlog board.Feb 7 2018, 5:33 PM

Similar to T167600 in that what's happening seems to be browser dependent. In T133673 we arbitrarily set the height of audio tags to 20px, but Chrome's player's controls seem to have a height of 32px. Firefox controls appear to scale.

Minerva seems to set,

audio {
    height: 32px;
}

ssastry moved this task from Needs Triage to Non-Parsing-Team Tasks on the Parsoid board.Feb 26 2018, 4:28 PM

• Fjalapeno edited projects, added Web-Team-Backlog; removed Page Content Service, Wikipedia-Android-App-Backlog, Android-app-Bugs.Mar 12 2018, 5:05 PM

• Fjalapeno moved this task from Needs triage to Tracking on the Product-Infrastructure-Team-Backlog-Deprecated board.

ovasileva triaged this task as Medium priority.Mar 13 2018, 11:05 AM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Mar 13 2018, 4:36 PM

Minerva seems to set,
audio {
    height: 32px;
}

I'm not seeing this anywhere.. The only mention of the audio tag inside "Minerva" is in the css reset file.

Jdlrobson added a project: TimedMediaHandler.Mar 13 2018, 4:54 PM

I'm not seeing this anywhere.. The only mention of the audio tag inside "Minerva" is in the css reset file.

Apologies, that's from the user agent stylesheet is Chrome.

Change 425900 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Increase the default height mw:Audio to 32px

https://gerrit.wikimedia.org/r/425900

gerritbot added a project: Patch-For-Review.Apr 12 2018, 8:46 PM

Arlolra mentioned this in T133673: Add width/height attributes to the <audio><video> tag.Apr 12 2018, 8:48 PM

Change 425900 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Increase the default height mw:Audio to 32px

https://gerrit.wikimedia.org/r/425900

"height" was bumped to 32 in that patch, and a new "mw-default-audio-size" class was added that can be targeted to override it.

Mentioned in SAL (#wikimedia-operations) [2018-04-30T20:27:25Z] <arlolra> Updated Parsoid to 50b0588 (T186358, T191700, T192909)

Stashbot mentioned this in T191700: VE: Avoid piping links for formatting where possible.Apr 30 2018, 8:27 PM

Stashbot mentioned this in T192909: Dirty diff and other weird corruption in table edit.

Arlolra mentioned this in T198504: [BUG] Audio file shows incomplete toolbar in an article page.Jul 13 2018, 9:12 PM

	F12970536: Screenshot_2018-01-31-15-03-23.png
	Feb 3 2018, 12:21 AM

[BUG] Some content is not rendering correctly in the Quick box / Info box on Android web viewClosed, ResolvedPublicActions