Page MenuHomePhabricator
Create Task
Maniphest T187230

Editing a <mapframe> whose GeoJSON has a wikitext link in the title of a point dirty-diffs the link to an HTML link
Closed, ResolvedPublic
Actions

Description

  1. Edit https://www.mediawiki.org/wiki/Maps in VE
  2. Edit the map
  3. Observe that the GeoJSON has a single point, whose title is [https://www.mediawiki.org/w/index.php?title=Discovery Maps Team]
  4. Do something that changes the GeoJSON, e.g. add a new point to the map
  5. Observe that the title of the existing point has changed to <a class="external text" href="https://www.mediawiki.org/w/index.php?title=Discovery">Maps Team</a>
  6. Add another point to the map
  7. The title now changes to &lt;a class="external text" href="<a class="external free" href="https://www.mediawiki.org/w/index.php?title=Discovery">https://www.mediawiki.org/w/index.php?title=Discovery</a>"&gt;Maps Team&lt;/a&gt;
  8. If you try to save this, it'll (obviously) break

The same thing happens with other types of wikitext links, like [https://www.example.org Example] or [[Foo]].

Details

SubjectRepoBranchLines +/-
Fix corruption of title/description wikitext to HTML when editing in VEmediawiki/extensions/Kartographermaster+55 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

Catrope created this task.Feb 13 2018, 7:10 PM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptFeb 13 2018, 7:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Catrope updated the task description. (Show Details)Feb 13 2018, 7:13 PM

From looking at the network traffic is looks like this happens inside api.php?action=sanitize-mapdata: the frontend makes a request to that API module with a GeoJSON blob containing wikitext, and it gets back a GeoJSON blob containing HTML.

Catrope added a parent task: T158013: Full-featured map visual editor.Feb 13 2018, 7:16 PM
Catrope edited parent tasks, added: T187236: Investigate broken features in maps VisualEditor integration and decide which ones to remove; removed: T158013: Full-featured map visual editor.Feb 13 2018, 7:20 PM
MaxSem subscribed.Feb 13 2018, 7:22 PM

This API is supposed to be used for display only.

• Deskana moved this task from To Triage to External and Administrivia on the VisualEditor board.Feb 13 2018, 7:35 PM
• jmatazzoni added projects: Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter).Feb 22 2018, 12:28 AM
• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
• jmatazzoni mentioned this in Collaboration-Team-Triage (Collab-Team-This-Quarter).Feb 26 2018, 11:48 PM
• jmatazzoni triaged this task as Medium priority.Feb 27 2018, 12:02 AM
Catrope added a comment.Mar 10 2018, 12:32 AM

I think I understand what happens: the "sanitized" GeoJSON is used for display but not in the editor. This works fine as long as you change the GeoJSON in the editor. But when you use the visual tools, the GeoJSON is modified programmatically, and the starting point used for that is the "sanitized" version. The modified version of the "sanitized" GeoJSON is that put into the editor.

gerritbot subscribed.Mar 10 2018, 2:19 AM

Change 418228 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Kartographer@master] Fix corruption of title/description wikitext to HTML when editing in VE

https://gerrit.wikimedia.org/r/418228

gerritbot added a project: Patch-For-Review.Mar 10 2018, 2:19 AM
Catrope claimed this task.Mar 10 2018, 2:19 AM
Catrope moved this task from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
gerritbot added a comment.Mar 13 2018, 1:19 PM

Change 418228 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Fix corruption of title/description wikitext to HTML when editing in VE

https://gerrit.wikimedia.org/r/418228

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Mar 13 2018, 1:23 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)).Mar 13 2018, 2:01 PM
Etonkovidova closed this task as Resolved.Mar 14 2018, 12:19 PM
Etonkovidova subscribed.

Checked in testwiki (wmf.25) - the title/description is not changed by unrelated edits.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 14 2018, 12:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL