| IKhitron | |
| Feb 17 2018, 9:14 PM |
| F13877317: Screen Shot 2018-02-19 at 12.54.13.png | |
| Feb 19 2018, 12:54 PM |
| F13877315: Screen Shot 2018-02-19 at 12.54.02.png | |
| Feb 19 2018, 12:54 PM |
Hello the VisualDiffs tool that was deployed this week sometimes can't recognize the particular place of the change. If one line was added, it can show 20 lines removed and 21 added. See, for example, here. Can it be fixed, please? Thank you.
Wikitext:
Visual:
Your report is very unclear, so I do not understand what it means.
Please provide exact reproduction steps, and write what you expected to happen and what actually happened.
Hello, Deskana. Please accept my appologies. I did not pay attention that the link I provided included "cur", so it became irrelevant with new revisions arrival. I changed it to "next" now. Please check it again. Thank you very much and sorry one more time.
That's helpful. Thank you.
I don't read Hebrew, but from looking at the wikitext diff, it's clear the visual diff isn't quite right.
Great, thank you, @Deskana!
But it does not look like as it was earlier today. I saw all the lines of the sections in red, and then once again in green.
Thanks for this, I've seen other examples like it.
It's a problem with the nested lists - the diff matches up the wrong paragraphs, so it looks like an insertion and a change, instead of just an insertion. It is correct from an HTML-structure point of view, but definitely not the best diff from the human reader's point of view! I have been thinking for a while that we should solve this by treating lists as a special case, and comparing each paragraph rather than the HTML structure.
Change 428259 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[VisualEditor/VisualEditor@master] WIP Separate out list diffs
Change 428259 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Separate out list, leaf and tree diffs
Change 439593 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] VisualDiff: Add test for add-simliar-and-indent
Change 439593 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] VisualDiff: Add test for add-simliar-and-indent
Change 439624 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8231b4d88)
Change 439624 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8231b4d88)