Page MenuHomePhabricator
Create Task
Maniphest T188061

[betalabs] VE crashes for "Draw a polyline" option
Closed, ResolvedPublic
Actions

Description

  1. In betalabs insert <mapframe> element, e.g.
<mapframe text="Downtown [[wikipedia:San Francisco|San Francisco]]" width=250 height=250 zoom=1 latitude=37.8013 longitude=-122.3988 />
  1. In VE click to edit Map and select the option "Draw a polyline"
  1. Draw a line and click on the popup option label ⧼leafletdraw-draw-toolbar-finish-text⧽
  1. Click Done - the following error will be displayed and VE crashes - not responding to any action. Need to reload the page.

Screen Shot 2018-02-21 at 5.32.53 PM.png (610×1 px, 417 KB)

VM3990:9 Uncaught TypeError: Cannot read property 'length' of undefined
    at NewClass._updateGuide (<anonymous>:9:227)
    at NewClass._onZoomEnd (<anonymous>:7:651)
    at NewClass.fire (load.php?debug=false&lang=en&modules=mapbox&skin=vector&version=0j9jq4y:9)
    at NewClass._updateZoomLevels (load.php?debug=false&lang=en&modules=mapbox&skin=vector&version=0j9jq4y:56)
    at NewClass._removeZoomLimit (load.php?debug=false&lang=en&modules=mapbox&skin=vector&version=0j9jq4y:56)
    at NewClass.onRemove (load.php?debug=false&lang=en&modules=mapbox&skin=vector&version=0j9jq4y:64)
    at NewClass.removeLayer (load.php?debug=false&lang=en&modules=mapbox&skin=vector&version=0j9jq4y:55)
    at NewClass.removeFrom (load.php?debug=false&lang=en&modules=mapbox&skin=vector&version=0j9jq4y:53)
    at NewClass.remove (load.php?debug=false&lang=en&modules=mapbox&skin=vector&version=0j9jq4y:53)
    at NewClass.remove (load.php?debug=false&lang=en&modules=mapbox&skin=vector&version=0j9jq4y:38)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Patch leaflet.draw-src.js to fix another JS errormediawiki/extensions/Kartographermaster+11 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Feb 23 2018, 1:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2018, 1:18 AM
Etonkovidova added projects: Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps).Feb 23 2018, 1:19 AM
Restricted Application added a project: Maps. · View Herald TranscriptFeb 23 2018, 1:19 AM
Etonkovidova added a parent task: T187236: Investigate broken features in maps VisualEditor integration and decide which ones to remove.Feb 23 2018, 1:20 AM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptFeb 23 2018, 1:20 AM
Catrope mentioned this in T187977: "Uncaught TypeError: Cannot read property 'call' of undefined" when using 'Edit layer' option.Feb 26 2018, 6:58 PM
• jmatazzoni mentioned this in Collaboration-Team-Triage (Collab-Team-This-Quarter).Feb 26 2018, 11:48 PM
• jmatazzoni triaged this task as Medium priority.Feb 27 2018, 12:02 AM
• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Mar 27 2018, 7:24 PM
• Mholloway subscribed.Mar 29 2018, 2:51 PM
• jmatazzoni moved this task from Need Triage to In Progress on the Collaboration-Feature-Rollouts (Collaboration-Maps) board.Apr 11 2018, 11:51 PM
Catrope subscribed.Apr 20 2018, 8:16 PM

Depressing finding: the crash happens while removing the map in the dialog, which happens while closing/tearing down the dialog. For some reason, removing a map that has a polyline drawn on it fails.

gerritbot subscribed.Apr 20 2018, 10:04 PM

Change 428025 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Kartographer@master] Patch leaflet.draw-src.js to fix another JS error

https://gerrit.wikimedia.org/r/428025

gerritbot added a project: Patch-For-Review.Apr 20 2018, 10:04 PM
Catrope moved this task from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Apr 20 2018, 10:05 PM

Turns out this was just a case of an event handler that was bound but never unbound.

SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Apr 25 2018, 5:51 PM
gerritbot added a comment.Apr 25 2018, 5:54 PM

Change 428025 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Patch leaflet.draw-src.js to fix another JS error

https://gerrit.wikimedia.org/r/428025

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).Apr 25 2018, 6:00 PM
Etonkovidova added a comment.Apr 26 2018, 9:44 PM

Checked the fix in enwiki betalabs.

Etonkovidova closed this task as Resolved.Apr 26 2018, 9:44 PM
Etonkovidova claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits