See T188011#4001934 - the structure test currently checks for a regex (https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/tests/phpunit/structure/StructureTest.php#28) that should be updated to detect non-qualified TestCase.
We might want to just check for a suffix of TestCase to support extension TestCases as well?
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Accept non-fully qualified TestCase in StructureTest | mediawiki/core | master | +1 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T188011 [Task] Use PHPUnit 6 forward compatibility aliases in all Wikibase code bases | |||
| Resolved | Lucas_Werkmeister_WMDE | T188276 Update StructureTest to find non-fully qualified PHPUnit\Framework\TestCase |
Change 414717 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/core@master] Accept non-fully qualified TestCase in StructureTest
We might want to just check for a suffix of TestCase to support extension TestCases as well?
Sounds reasonable – this would also make a few other list elements (MediaWikiTestCase, MediaWikiLangTestCase, …) obsolete.
(Side note: IIUC, StructureTest currently misses tests that extend \MediaWikiTestCase, due to the backslash.)
DumpTestCase is also namespaced since https://gerrit.wikimedia.org/r/#/c/404512/
The backslash could be moved before the regex to fix all that cases
Change 414717 merged by jenkins-bot:
[mediawiki/core@master] Accept non-fully qualified TestCase in StructureTest