| • Nirzar | |
| Mar 1 2018, 1:35 AM |
| F15974500: image.png | |
| Mar 22 2018, 9:29 PM |
| F15623638: image.png | |
| Mar 16 2018, 9:26 PM |
| F15623591: image.png | |
| Mar 16 2018, 9:26 PM |
| F15623609: image.png | |
| Mar 16 2018, 9:26 PM |
| F15623586: Screen Shot 2018-03-16 at 2.20.33 PM.png | |
| Mar 16 2018, 9:26 PM |
| F15440885: Screen Shot 2018-03-14 at 4.02.48 PM.png | |
| Mar 14 2018, 11:17 PM |
| F15440943: Screen Shot 2018-03-14 at 4.03.48 PM.png | |
| Mar 14 2018, 11:17 PM |
| F15440710: Screen Shot 2018-03-14 at 4.02.39 PM.png | |
| Mar 14 2018, 11:17 PM |
Page previews apply gradient fading to text summary even if the summary is one single line.
if the text summary is one single line, it means the sentence ends there. there sholdn't be any fading needed
.mwe-popups.mwe-popups-is-not-tall .mwe-popups-extract {
min-height:40px;
}| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Give summary a min-height to avoid overlap with gradient. | mediawiki/extensions/Popups | master | +4 -1 |
min-height prevents the gradient to be applied to first line, it starts with second line given our line height
Change 417985 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Popups@master] Give summary a min-height to avoid overlap with gradient.
Change 417985 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Give summary a min-height to avoid overlap with gradient.
https://en.wikipedia.beta.wmflabs.org/wiki/Special:AllPages
(All merged changes automatically go to the beta cluster within 10 minutes). If you need staging let me know as I'll need to manually set that up.
I'm having a little trouble finding a preview that looks like the one in the original description. @Nirzar, what links are you hovering on and on what page? I tried the page in @Jdlrobson comment but I could not find a link to hover on that produced a similar preview.
I am also seeing this but not sure if it is related:
https://en.wikipedia.beta.wmflabs.org/wiki/Dog
This one used to produce a preview
I was able to find this one on, which looks ok https://en.wikipedia.beta.wmflabs.org/wiki/Special:AllPages
@ABorbaWMF : Ouch. The previews in your examples are seriously broken. I hope this is not coming into production.
@Vachovec1 @ABorbaWMF this is the beta cluster. As can be seen the pages themselves are broken which is why their previews are broken - https://en.m.wikipedia.beta.wmflabs.org/wiki/Border_Terrier
The beta cluster is not a good place to test summaries :)
https://en.wikipedia.beta.wmflabs.org/wiki/Special:AllPages
10.1093/acprof:oso/9780195314250.003.0001 < this link has a preview that ends in one line at the edge. it doesn't fade into the gradient.
@Nirzar and @Jdlrobson, thanks for the link. I tried that one yesterday but figured it was a hair too short for the gradient to kick in. On my side, I am not seeing the gradient at all on that link. I purged the cache on the page. Let me know if I am missing something.
You should't be seeing gradient on it. since the sentence or text ends where it ends. if it wraps to second line. it will start showing the gradient. that is intended.
