Show HTML summaries on cswiki
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	ovasileva
	Dec 7 2017, 1:13 PM

Description

Background

In T173639: Hovercard text extract is broken for `* ` sequence in parenthesis, cswiki community members proposed testing the HTML summaries produced by the new Summary API. We would like to release it to cswiki first and do a round of QA prior to switching all projects to showing HTML summaries.

Acceptance criteria

Switch cswiki to showing HTML summaries
Prepare test articles for QA
Do a round of QA (full test plan) on cswiki
Ping @bearND and @Mholloway when this has happened.

Sign off steps

If any bugs are discovered during QA we may want to revert the change (Olga's decision). Bugs should be captured. We shouldn't rush to fix anything while the code is in production.

Update https://www.mediawiki.org/wiki/Reading/Web/Release_timeline#January

Done in https://www.mediawiki.org/w/index.php?title=Reading%2FWeb%2FRelease_timeline&type=revision&diff=2721756&oldid=2720598.

Developer Notes

This is as simple as adding $wgPopupsGateway = 'restbaseHTML'; to the config. Note that this gateway is different from the "RESTBase Plain" gateway, which is currently in use on all of the Wikipedias.

Details

	Subject	Repo	Branch	Lines +/-
	Show HTML summaries on cswiki	operations/mediawiki-config	master	+1 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Dereckson	T68374 Enable Hovercards on se.wikimedia.org (Swedish chapter wiki)
Resolved	Jdlrobson	T70860 [GOAL] Graduate Page Previews feature (Popups extension) out of Beta Feature
Resolved	ovasileva	T154635 [EPIC] Deploy page previews to English and German Wikipedia
Resolved	ovasileva	T182319 Show HTML summaries on all wikis
Resolved	ABorbaWMF	T182321 Show HTML summaries on cswiki
Resolved	• mobrovac	T179875 Update RESTBase to get summary content from MCS Summary 1.3 endpoint when development is complete
Resolved	ABorbaWMF	T182399 QA html previews on beta cluster
Resolved	ABorbaWMF	T182639 Page previews cannot handle empty responses gracefully - throws error in beta cluster and doesn't display preview (browser tests were failing)
Resolved	• Mholloway	T186847 Initial transcluded <p> elements on dewiki are fooling extractLeadIntroduction
Resolved	• Mholloway	T186933 204 summary responses cause Android app to crash
Resolved	• Mholloway	T187091 Summary: stop responding with 204s
Resolved	ovasileva	T187955 Page preview shows icon instead of thumbnail

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Probably blocked till at least Wednesday

Deploy now delayed until Monday.

ovasileva moved this task from Blocked on Others to To Do on the Readers-Web-Kanbanana-Board-Old board.Feb 13 2018, 6:18 PM

Here's the latest comparison run for the Czech html extracts from TextExtracts vs the MCS summary implementation: http://wpsummary.surge.sh/1.2.0-b0be98c/html/cs.html. See also T179875#3986429. Starting soon.

ovasileva moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Feb 21 2018, 12:48 PM

ovasileva moved this task from Needs Design Review to To Do on the Readers-Web-Kanbanana-Board-Old board.

ovasileva raised the priority of this task from Medium to High.Feb 21 2018, 4:05 PM

Restricted Application added a subscriber: Dereckson. · View Herald TranscriptFeb 21 2018, 4:05 PM

Summarizing: @EddieGP's config change patch can be merged pending verification (see QA notes above) of the summary v1.3 rollout.

ovasileva moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Feb 21 2018, 6:25 PM

The summaries for all pages on cswiki are now rendered using MCS.

Dvorapa subscribed.Feb 21 2018, 8:45 PM

In T182321#3990727, @bearND wrote:

The summaries for all pages on cswiki are now rendered using MCS.

I found no problems with the summary texts so far. But I stumbled across a lot of pages for which I see in the summary a blank space in the place of (expected) picture. E.g. Douglas MacArthur‎, Benito Mussolini, Chester Nimitz, Prezident Spojených států amerických, Labradoodle and others.

I suspect that this is a page preview (web client) issue. The /page/summary JSON responses for these pages look fine to me. All have the thumbnail property:

The thumbnail in this page preview looks definitely wrong:
On https://cs.wikipedia.org/wiki/Donald_Trump hover over "prezident Spojených států amerických"

Screen Shot 2018-02-21 at 3.17.03 PM.png (646×933 px, 381 KB)

The thumbnail URL in the summary for the target page (https://cs.wikipedia.org/api/rest_v1/page/summary/Prezident_Spojen%C3%BDch_st%C3%A1t%C5%AF_americk%C3%BDch) looks right, though: https://upload.wikimedia.org/wikipedia/commons/0/0e/Donald_Trump_Pentagon_2017.jpg

I can also reproduce the same on a few enwiki pages, see new subtask T187955.

In T182321#3991164, @bearND wrote:

The thumbnail in this page preview looks definitely wrong:
On https://cs.wikipedia.org/wiki/Donald_Trump hover over "prezident Spojených států amerických"

I see a blank space instead of icon. But that could be a matter of different browser. I am using Firefox 52.6.0 ESR.

Correct. I can repro it on FF showing blank space. What I showed above was with Chrome.
Thank you for reporting this.

The cswiki page summaries have been re-rendered with the correct thumbnail size. We're still working through other wikis but for cs the blank thumbnail image issue should be resolved.

In T182321#3991747, @bearND wrote:

The cswiki page summaries have been re-rendered with the correct thumbnail size. We're still working through other wikis but for cs the blank thumbnail image issue should be resolved.

The situation has improved, but I am still getting blank spaces instead of thumbnail for some of the above mentioned pages:

Douglas MacArthur‎
Benito Mussolini
Prezident Spojených států amerických

Thumbnail is served correctly now for:

Labradoodle
Chester Nimitz

MarcoAurelio moved this task from Blocked on development to Done on the Wikimedia-Site-requests board.Feb 22 2018, 11:16 AM

MarcoAurelio moved this task from Done to Blocked on development on the Wikimedia-Site-requests board.Feb 22 2018, 11:22 AM

@bearND - we're planning on switching html previews on today during the European mid-day SWAT.

In T182321#3992333, @Vachovec1 wrote:

In T182321#3991747, @bearND wrote:

The cswiki page summaries have been re-rendered with the correct thumbnail size. We're still working through other wikis but for cs the blank thumbnail image issue should be resolved.

The situation has improved, but I am still getting blank spaces instead of thumbnail for some of the above mentioned pages:

Douglas MacArthur‎
Benito Mussolini
Prezident Spojených států amerických

But these seems like rare exceptions. The only other failed thumbnails I've found so far are for Friedrich Engels and Adolf Hitler. Perhaps some lokal cache issue? I'll try with another browser.

@Vachovec1 - just checked through some of these as well - I'm seeing thumbnails on Prezident Spojených států amerických, Friedrich Engels, Benito Mussolini

Change 396318 merged by jenkins-bot:
[operations/mediawiki-config@master] Show HTML summaries on cswiki

https://gerrit.wikimedia.org/r/396318

In T182321#3992585, @ovasileva wrote:

@Vachovec1 - just checked through some of these as well - I'm seeing thumbnails on Prezident Spojených států amerických, Friedrich Engels, Benito Mussolini

Definitely caching issue. It worked as expected in Chrome. But for the Firefox, the cache was very persistent. A simple purge may not be enough, I needed minor edits for Prezident Spojených států amerických and Benito Mussolini's summary thumbnails to work.

Mentioned in SAL (#wikimedia-operations) [2018-02-22T14:26:53Z] <zfilipin@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:396318|Show HTML summaries on cswiki (T182321)]] (duration: 01m 13s)

EddieGP unsubscribed.Feb 22 2018, 2:28 PM

It seems there is some collision between the page previews code and "Zvýrazňovat přesměrování" (highlight redirects) gadget now. The redirects in the text extract are now highligted with rose background and overline. See for example previews for:

Anna
Ctiborův dub

If the gadget is disabled, the page previews behave as expected.

html previews now live. math looks great!

Screen Shot 2018-02-22 at 3.22.43 PM.png (429×409 px, 105 KB)

some small issues detected (listing them here and we can move to appropriate bugs later):

longer formulas not appearing correctly (https://cs.wikipedia.org/wiki/Geometrie, hover over polynomu)

Screen Shot 2018-02-22 at 3.28.37 PM.png (272×389 px, 75 KB)

fading with mathematical formulas can be confusing (for example, go to https://cs.wikipedia.org/wiki/Geometrie, hover over algebraických variet

Screen Shot 2018-02-22 at 3.29.35 PM.png (299×425 px, 94 KB)

IPA not always removed (https://cs.wikipedia.org/wiki/Geometrie, hover over Jánosem Bolyaiem

Screen Shot 2018-02-22 at 3.42.37 PM.png (291×570 px, 146 KB)

that's all I've noticed for now, but will keep testing.

(@Vachovec1) After switching HTML previews on, should we maybe inform Czech Wikipedia community about what happened and how to track bugs right?

In T182321#3992833, @Dvorapa wrote:

(@Vachovec1) After switching HTML previews on, should we maybe inform Czech Wikipedia community about what happened and how to track bugs right?

It would be definitely helpful to post an appropriate message in our Village pump (technical): Wikipedie:Pod lípou (technika).

@Vachovec1, @Dvorapa - yup, we'll be posting a message later today. Next step here would be to QA internally but we'll be asking for some help in identifying edge cases in our message as well

@ovasileva - T182321#3992796 is an example of an edge case or a bug? The preview should probably not accept css definitions designed for the normal article text. The above mentioned gadget may not be the only one that will influence the preview.

@Vachovec1 - good catch. I don't think we had thought about how all the gadgets might work with the feature. I'll open a separate task for this. For posterity, here's an example of the preview:

Screen Shot 2018-02-22 at 4.35.45 PM.png (263×409 px, 48 KB)

issue now logged here: https://phabricator.wikimedia.org/T188005
@Vachovec1 - I'm a bit conflicted on whether this is a bug or not. I can see a case being made for an editor who enabled the gadget to expect redirects within previews as well.

ovasileva mentioned this in T188005: HTML previews displaying changes made by gadgets.Feb 22 2018, 3:49 PM

In T182321#3992875, @Vachovec1 wrote:

@ovasileva - T182321#3992796 is an example of an edge case or a bug? The preview should probably not accept css definitions designed for the normal article text. The above mentioned gadget may not be the only one that will influence the preview.

that should be fixed in the gadget. The styling introduced by said gadget is very generic. Vachovec1 would you be so kind to flag that to the gadget author(s)?

phuedx updated the task description. (Show Details)Feb 22 2018, 5:06 PM

Jdlrobson moved this task from Needs Design Review to Doing on the Readers-Web-Kanbanana-Board-Old board.Feb 22 2018, 5:11 PM

over to you Anthony!

@ABorbaWMF - this would require going through all the page previews test cases (they should now have relevant articles on cswiki)

IPA not always removed (https://cs.wikipedia.org/wiki/Geometrie, hover over Jánosem Bolyaiem

This is by design. We don't scrub any content inside square brackets and we do not scrub parenthetical with one word. This would need to be marked up on wiki with the desired behaviour.

fading with mathematical formulas can be confusing (for example, go to https://cs.wikipedia.org/wiki/Geometrie, hover over algebraických variet
longer formulas not appearing correctly (https://cs.wikipedia.org/wiki/Geometrie, hover over polynomu)

We should open tickets for these and put them in the design backlog. We cannot change the preview content but we can change the presentation.

In T182321#3993121, @Jdlrobson wrote:

In T182321#3992875, @Vachovec1 wrote:

@ovasileva - T182321#3992796 is an example of an edge case or a bug? The preview should probably not accept css definitions designed for the normal article text. The above mentioned gadget may not be the only one that will influence the preview.

that should be fixed in the gadget. The styling introduced by said gadget is very generic. Vachovec1 would you be so kind to flag that to the gadget author(s)?

Well, the gadget definition is here:

MediaWiki:Gadget-HighlightRedirects.css

It's actualy very simple/basic code. So what would you propose?

The en-wiki has something very similar:

MediaWiki:Gadget-DisambiguationLinks.css (author: @kaldari)

I presume that the behaviour would be the same.

ovasileva added a subscriber: • Nirzar.Feb 22 2018, 6:31 PM

In T182321#3993765, @Vachovec1 wrote:

In T182321#3993121, @Jdlrobson wrote:

In T182321#3992875, @Vachovec1 wrote:

@ovasileva - T182321#3992796 is an example of an edge case or a bug? The preview should probably not accept css definitions designed for the normal article text. The above mentioned gadget may not be the only one that will influence the preview.

that should be fixed in the gadget. The styling introduced by said gadget is very generic. Vachovec1 would you be so kind to flag that to the gadget author(s)?

Well, the gadget definition is here:

MediaWiki:Gadget-HighlightRedirects.css

It's actualy very simple/basic code. So what would you propose?

The en-wiki has something very similar:

MediaWiki:Gadget-DisambiguationLinks.css (author: @kaldari)

I presume that the behaviour would be the same.

This conversation continues in T188005.

ovasileva closed subtask T187955: Page preview shows icon instead of thumbnail as Resolved.Feb 23 2018, 3:06 PM

Looks good so far for me. Here are some examples with different previews (images, math, bold, parens, etc) on different os/browsers:

Screen Shot 2018-02-23 at 8.45.07 AM.png (1×2 px, 2 MB)

Screen Shot 2018-02-23 at 9.06.47 AM.png (1×2 px, 1 MB)

Screen Shot 2018-02-23 at 9.07.33 AM.png (1×2 px, 2 MB)

Screen Shot 2018-02-23 at 8.56.30 AM.png (1×2 px, 1 MB)

Screen Shot 2018-02-23 at 8.56.55 AM.png (1×2 px, 1 MB)

Screen Shot 2018-02-23 at 8.35.12 AM.png (1×2 px, 1 MB)

I have some reservations about the "fading" logic. Look at the following previews:

Notice the fading. This is not good. The fading should definitely not be applied to the first line of the text. Another thing: it would be great if the fading would not be applied to the last word of the sentence.

A remark: this happens mostly for the previews without the picture or with the "horizontal" picture. The previews with the "vertical" picture have usually much more room for the text before the "fading" is applied, so the short text summaries are usually presented as whole, without fading.

I agree, the first sentence should not fade like this in the middle of the object:

"Jonathan Kuck is figure ska..."
"Brian Hansen is figure skat..."
(skater? skateboarder?)

ovasileva reopened subtask T187955: Page preview shows icon instead of thumbnail as Open.Feb 28 2018, 3:34 PM

The fading should definitely not be applied to the first line of the text

We could potentially define "min-height" to content to 40px to solve for this particular case. if you apply 40px as a min-height, it won't apply the fading to the first line. I find this way a bit unreliable and of course I will speak with an engineer to figure out what is the downside.

@Vachovec1 created a card to fix this issue
https://phabricator.wikimedia.org/T188581

ovasileva closed subtask T187955: Page preview shows icon instead of thumbnail as Resolved.Mar 1 2018, 4:45 PM

ovasileva moved this task from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Mar 1 2018, 6:34 PM

No new bugs observed - resolving this for now. Logged the issue with longer formulas (T188734), although I'm not sure we can do much about it. All else looks good!

@ovasileva And T188581, but all the original issues were solved by HTML summaries, so this task is resolved

Dvorapa merged a task: T173640: Hovercard text extract is broken for academic titles before and after names of person.Mar 2 2018, 3:41 PM

Dvorapa mentioned this in T173640: Hovercard text extract is broken for academic titles before and after names of person.

Dvorapa merged a task: T173641: Hovercard article topic bolding fails if the page title has some qualifier.

Dvorapa added subscribers: Kizule, jeblad.

Dvorapa added a subscriber: JAnD.

Dvorapa mentioned this in T173641: Hovercard article topic bolding fails if the page title has some qualifier.Mar 2 2018, 3:43 PM

Dvorapa merged a task: T173639: Hovercard text extract is broken for `* ` sequence in parenthesis.

Dvorapa mentioned this in T173639: Hovercard text extract is broken for `* ` sequence in parenthesis.

Dvorapa added subscribers: Volker_E, • Pchelolo, matej_suchanek.

In T182321#4017757, @Dvorapa wrote:

@ovasileva And T188581, but all the original issues were solved by HTML summaries, so this task is resolved

yes, that's the other one. Thanks @Dvorapa, @Vachovec1 and everyone else for all your help with QA

matej_suchanek unsubscribed.Mar 2 2018, 3:45 PM

Dvorapa moved this task from Next Up to Done on the Page-Previews board.Mar 2 2018, 3:47 PM

Dvorapa merged a task: T174894: Extract cropped too much at certain pages with exintro=1.Mar 2 2018, 4:02 PM

Dvorapa mentioned this in T174894: Extract cropped too much at certain pages with exintro=1.

Dvorapa added a subscriber: Soustruh.

@ovasileva And finally T183833 looks still unresolved

Vachovec1 awarded a token.Mar 7 2018, 4:46 PM

• mobrovac closed subtask T179875: Update RESTBase to get summary content from MCS Summary 1.3 endpoint when development is complete as Resolved.Mar 12 2018, 7:30 PM

MBinder_WMF mentioned this in T193679: Phlogiston Bug: [Status Report] Task shows as Status = Done when task was open.May 2 2018, 9:01 PM

	F13972523: Screen Shot 2018-02-23 at 8.56.30 AM.png
	Feb 23 2018, 5:27 PM

	F13972524: Screen Shot 2018-02-23 at 8.56.55 AM.png
	Feb 23 2018, 5:27 PM

	F13972522: Screen Shot 2018-02-23 at 9.06.47 AM.png
	Feb 23 2018, 5:27 PM

	F13972528: Screen Shot 2018-02-23 at 9.07.33 AM.png
	Feb 23 2018, 5:27 PM

	F13974148: Previews 001.jpg
	Feb 23 2018, 8:09 PM

	F13974152: Previews 002.jpg
	Feb 23 2018, 8:09 PM

Show HTML summaries on cswikiClosed, ResolvedPublic2 Estimated Story PointsActions