Page MenuHomePhabricator
Create Task
Maniphest T188899

[Task] Remove hard-coded demo data from Lexeme code base
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

In T186726: Security review WikibaseLexeme extension the Application Security Reviews team stumbled across hard-coded demo data in the Lexeme code base. Before T168260: Deploy WikibaseLexeme extension on Wikimedia cluster these must all be removed, and possibly replaced with proper implementations:

  • Everything in the directory src/DemoData and also LexemeContent.php:
    • AskOut1Populator, AskOut2Populator, AskOut3Populator, HardLexemePopulator, LeiterLexemePopulator, and usages:
      • Currently exclusively used in LexemeContent.
    • Id.php is a set of constants.
      • Used in above populators.
      • Also directly used in LexemeContent.
  • FormIdFormatter.php and SenseIdFormatter.php are basically nothing but dummies with hard-coded demo-data.
    • The formatter should just display the ID (as a string).
    • resources/experts/Form.js and resources/experts/Sense.js contain the same demo data.

Details

SubjectRepoBranchLines +/-
Remove reference to demo data IDs in lexeme_page.rbmediawiki/extensions/WikibaseLexememaster+0 -5
Remove hard-coded demo data from Lexeme codebasemediawiki/extensions/WikibaseLexememaster+2 -512
Customize query in gerrit

Related Objects
Search...

Event Timeline

thiemowmde created this task.Mar 5 2018, 9:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 5 2018, 9:32 AM
thiemowmde added a parent task: T168260: Deploy WikibaseLexeme extension on Wikimedia cluster.Mar 5 2018, 9:32 AM
thiemowmde mentioned this in T186726: Security review WikibaseLexeme extension.Mar 5 2018, 10:33 AM
thiemowmde moved this task from incoming to ready to go on the Wikidata board.Mar 5 2018, 1:49 PM
Lydia_Pintscher moved this task from ready to go to consider for next sprint on the Wikidata board.Mar 5 2018, 4:26 PM
Lydia_Pintscher moved this task from incoming to features/bugs for next release (editor experience improvements) on the Wikidata Lexicographical data board.Mar 7 2018, 5:58 PM
Lydia_Pintscher triaged this task as Low priority.Mar 8 2018, 9:38 AM
Jakob_WMDE updated the task description. (Show Details)Mar 20 2018, 4:30 PM
Jakob_WMDE set the point value for this task to 2.
Addshore edited parent tasks, added: T191459: Deploy WikibaseLexeme to the Beta Cluster; removed: T168260: Deploy WikibaseLexeme extension on Wikimedia cluster.Apr 4 2018, 7:21 PM
WMDE-leszek moved this task from features/bugs for next release (editor experience improvements) to Features/bugs for first release on the Wikidata Lexicographical data board.Apr 5 2018, 9:28 AM
• RazShuty added a project: Wikidata-Turtles-Sprint#3.Apr 11 2018, 10:02 AM
WMDE-leszek updated the task description. (Show Details)Apr 11 2018, 2:04 PM
Lydia_Pintscher moved this task from consider for next sprint to in progress on the Wikidata board.Apr 15 2018, 10:26 AM
Jakob_WMDE claimed this task.Apr 20 2018, 11:27 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Turtles-Sprint#3 board.
gerritbot subscribed.Apr 20 2018, 12:47 PM

Change 427899 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Remove hard-coded demo data from Lexeme codebase

https://gerrit.wikimedia.org/r/427899

gerritbot added a project: Patch-For-Review.Apr 20 2018, 12:47 PM
Jakob_WMDE mentioned this in rEWLE2347c5ec665a: Remove hard-coded demo data from Lexeme codebase.Apr 20 2018, 12:48 PM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Turtles-Sprint#3 board.Apr 20 2018, 12:57 PM
gerritbot added a comment.Apr 20 2018, 2:02 PM

Change 427909 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] Remove reference to demo data IDs in lexeme_page.rb

https://gerrit.wikimedia.org/r/427909

Addshore mentioned this in rEWLEb5a25ab5d6e1: Remove reference to demo data IDs in lexeme_page.rb.Apr 20 2018, 2:04 PM
Jakob_WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Turtles-Sprint#3 board.Apr 20 2018, 2:07 PM
gerritbot added a comment.Apr 20 2018, 2:13 PM

Change 427899 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove hard-coded demo data from Lexeme codebase

https://gerrit.wikimedia.org/r/427899

gerritbot added a comment.Apr 20 2018, 2:24 PM

Change 427909 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove reference to demo data IDs in lexeme_page.rb

https://gerrit.wikimedia.org/r/427909

Lydia_Pintscher closed this task as Resolved.Apr 23 2018, 8:38 AM
Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Turtles-Sprint#3 board.
Addshore mentioned this in rEWLE84ef3b28d77d: Update patch set 2.Jun 9 2018, 11:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL