Page MenuHomePhabricator

Unwanted styling on ul.gallery galleries from skins.minerva.content.styles
Closed, InvalidPublic

Description

The skins.minerva.content.styles module applies currently applies ul styling to ul.gallery elements resulting in them being off-center due to a 1em left padding, and (on Android) having square list item bullet points. The off-centeredness due to left padding is visible on the mobile web as well.

(examples from Picasso's Blue Period)

AndroidMobile web

Adding a rule to remove the left padding from ul.gallery elements in galleries.less and importing that file in styles.less fixes the issue.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2018, 7:33 PM

Change 420828 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/skins/MinervaNeue@master] Fix ul.gallery styling

https://gerrit.wikimedia.org/r/420828

Have you tried loading mediawiki.page.gallery.styles ? I think that's where these styles are coming from.

Change 420836 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Remove unnecessary file for gallery styles

https://gerrit.wikimedia.org/r/420836

Confirmed that's where they are coming from.

Change 420828 abandoned by Mholloway:
Fix ul.gallery styling

Reason:
See discussion on ticket

https://gerrit.wikimedia.org/r/420828

Have you tried loading mediawiki.page.gallery.styles ? I think that's where these styles are coming from.

Aha, thanks! That does indeed fix this.

Mholloway closed this task as Invalid.Mar 20 2018, 8:30 PM
Mholloway reopened this task as Open.

Whoops, @Jdlrobson still has a related patch open.

ovasileva triaged this task as Normal priority.Mar 21 2018, 1:21 PM

Change 420836 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove unnecessary file for gallery styles

https://gerrit.wikimedia.org/r/420836

Mholloway closed this task as Invalid.Mar 21 2018, 3:19 PM

OK, declining the task as invalid now but feel free to change status if you see fit.