Page MenuHomePhabricator

Confusing wording in message when session is no longer valid
Closed, DuplicatePublic

Description

The wording in the dialogue that you get when your session is no longer valid (see below) is quite confusing. The message contains a Yes/No-question ("Do you want to save this page as an anonymous user instead?"), but the options are "Dismiss" and "Try again". It's unclear what these buttons will do.

confusing-dialogue-for-invalid-session.png (320×507 px, 25 KB)

Steps to reproduce:

  1. Go to a page on https://www.mediawiki.org/.
  2. Click Edit.
  3. Change something.
  4. Log out while still having the edit open (e.g. in another tab).
  5. Submit changes.

Event Timeline

Ammarpad subscribed.

This is a VE bug. Maybe the buttons should be reworded to something like: No, I don't want and Yes, post with my IP as that's what they really do.

JTannerWMF moved this task from To Triage to Triaged on the VisualEditor board.
JTannerWMF subscribed.

The Editing team will take a look at this

Frostly subscribed.

@JTannerWMF any updates on this? It's been almost 2 years :)

Change 876340 had a related patch set uploaded (by Nardog; author: Nardog):

[mediawiki/extensions/VisualEditor@master] Show "Continue" instead of "Try again" on button to save as another user

https://gerrit.wikimedia.org/r/876340

It's regrettable that the Continue button is still the one that's emphasized, but it's at least better than "Try again".

image.png (358×500 px, 24 KB)

While better, this may still not be easily understandable by a user. I think the best thing would be to change the labels (as mentioned in T190406#6063318). If that is too much work (looks like a generic error dialogue is used here) I think at least the word "continue" should be added to the message, e.g. "Do you want to continue and save this page[...]".

Change 876340 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Show "Continue" instead of "Try again" on button to save as another user

https://gerrit.wikimedia.org/r/876340

Changing the label of the buttons would be too much work. The related line is hardcoded here and there's no easy way to override it. Changing the message given to the user is much more possible, and since HTML is parsed in the latter portion of that message, we can add emphasis where needed. The message in that case would be:

We could not save your edit because the session was no longer valid. You can try again by saving this page as an anonymous user, but your IP address will be recorded in the page's edit history.

The related message changed above is here for reference. The change above follows the same sentence type of its counterpart (visualeditor-savedialog-identify-user), which uses a declarative statement instead of an interrogative one.

Thanks for the patch!

Changing the button labels and styles is a bit tricky, but possible. The error interface is implemented in OOUI and not easily customizable, but like most things in OOUI you can just override the method that displays it.

Here's an example of doing that I just found: https://gerrit.wikimedia.org/g/mediawiki/extensions/TemplateWizard/+/08db935590faaf907cc22b4f5ba861f1dead1a9f/resources/ext.TemplateWizard.Dialog.js#128 (and some more different examples: https://codesearch-beta.wmcloud.org/search/?q=.prototype.showErrors)

I'd be happy to review a patch if you submit one.

Test wiki on Patch demo by Nardog using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/13fb1c454e/w/

We're revisiting this message on the occasion of the IP Masking work, and I proposed several tweaks based on the discussion in this task: T343848#9091574

Please comment there. I'll close this task to centralize the discussion. Thanks!