Highlight does not cover the menu option entirely in the toolbar on Mobile VE
Production:
Beta:
Ryasmeen | |
Mar 23 2018, 11:25 PM |
F18583158: image.png | |
May 28 2018, 7:58 PM |
F16725164: Screen Shot 2018-04-05 at 4.08.33 PM.png | |
Apr 5 2018, 11:12 PM |
F16725153: Screen Shot 2018-04-05 at 4.08.26 PM.png | |
Apr 5 2018, 11:12 PM |
F16006838: Screen Shot 2018-03-23 at 4.23.21 PM.png | |
Mar 23 2018, 11:25 PM |
F16006840: Screen Shot 2018-03-23 at 4.23.27 PM.png | |
Mar 23 2018, 11:25 PM |
Highlight does not cover the menu option entirely in the toolbar on Mobile VE
Production:
Beta:
Thanks @Ryasmeen for looking into all the VE Mobile issues, I've been fiddling around yesterday and provided a first fix to MobileFrontend. More to come…
@Volker_E I'm not sure what to do with this task. Should it be merged into something else, if you're writing a patch that fixes those issues too?
okay looks like this is still not completely fixed. I see, it's fixed for the first menu option Text formatting but not for the other ones? Has there actually been any fix for this ?
Screenshots:
Text formatting highlight
Change 435827 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/VisualEditor@master] Make VE mobile tools use full height
Change 450580 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/skins/MinervaNeue@master] Slightly reduce toolbar height when using VE
Change 452598 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.init.mw.MobileArticleTarget: Tweak toolbar items' height
Change 435827 abandoned by Bartosz Dziewoński:
Make VE mobile tools use full height
Reason:
I guess we're going with Ed's approach.
We're solving this by overriding the height of mobile editor's toolbar from 3.35em to 3em only when using VisualEditor. The existing VisualEditor styles are written to use a 3em toolbar (same on desktop and mobile) and overriding everything to use 3.35em would require a lot of fragile code (and where does 3.35em come from, anyway?).
On Minerva, which uses a 16px base font size, 3.35em = 53.6px, 3em = 48px, which is still larger than the 44px minimum size I've seen recommended for mobile buttons. (On Vector, which uses a 14px base font size, 3em = 42px.)
Change 452598 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.init.mw.MobileArticleTarget: Tweak toolbar items' height
Change 450580 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Slightly reduce toolbar height when using VE