Maniphest T195791

Remove CSS special-casing of mobile VE
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Volker_E
	May 28 2018, 6:11 PM

Description

Special treatments by applying font-size overrides on VE overlay makes overriding general OOUI styles unnecessarily complex.

Current layout:

See the tool padding tab, overrides should happen on tool specific padding, not on the font-size property.

Proposed outcome:

Details

	Subject	Repo	Branch	Lines +/-
	Remove special `font-size` treatment of VE overlay	mediawiki/skins/MinervaNeue	master	+0 -3
	Remove special `font-size` treatment of VE overlay	mediawiki/extensions/MobileFrontend	master	+0 -3

Customize query in gerrit

Related Objects

Mentioned Here: T190596: Highlight does not cover the menu option entirely in the toolbar on Mobile VE

Event Timeline

Volker_E created this task.May 28 2018, 6:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2018, 6:11 PM

Related to T190596

Change 435823 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Remove special font-size treatment of VE overlay

https://gerrit.wikimedia.org/r/435823

gerritbot added a project: Patch-For-Review.May 28 2018, 7:23 PM

Volker_E updated the task description. (Show Details)May 28 2018, 7:28 PM

Volker_E updated the task description. (Show Details)May 28 2018, 7:59 PM

• Deskana assigned this task to Volker_E.May 29 2018, 6:33 PM

• Deskana triaged this task as Medium priority.

• Deskana edited projects, added VisualEditor (Current work); removed VisualEditor.

• Deskana moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Jdrewniak moved this task from Backlog to Team:Editing on the MobileFrontend board.May 30 2018, 12:20 PM

Jdlrobson added a project: Web-Team-Backlog (Tracking).May 30 2018, 12:20 PM

Change 436572 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Remove special font-size treatment of VE overlay

https://gerrit.wikimedia.org/r/436572

Change 435823 abandoned by VolkerE:
Remove special font-size treatment of VE overlay

Reason:
Abandoned for Ief66c0d3565d3b67399e5aa2a749035a9a4b47bc

https://gerrit.wikimedia.org/r/435823

Change 436572 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove special font-size treatment of VE overlay

https://gerrit.wikimedia.org/r/436572

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).May 31 2018, 8:00 PM

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Jun 4 2018, 4:19 PM

• Deskana closed this task as Resolved.Jun 5 2018, 4:47 PM

Jdforrester-WMF removed a project: Patch-For-Review.Jun 13 2018, 6:23 PM

Jdforrester-WMF set the point value for this task to 1.

• Vvjjkkii renamed this task from Remove CSS special-casing of mobile VE to o4baaaaaaa.Jul 1 2018, 1:07 AM