Page MenuHomePhabricator
Create Task
Maniphest T190821

Improve code coverage of APIDetailRetriever
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

ApiDetailRetriever is already tested with a line coverage of about 67%. The code is quite complex (long and deeply nested), that's why this is ranked higher than anything else in the code coverage tool.

Task:

  • Find out what important stuff is not covered (biggest chunk is continuation feature)

- Goal: 80% code coverage

The story points are considered our "stopper" since one could write tests forever

Details

SubjectRepoBranchLines +/-
Fully test continuation feature in ApiDetailRetrievermediawiki/extensions/FileImportermaster+63 -17
Test "continue" params passed by reference in ApiDetailRetrievermediawiki/extensions/FileImportermaster+5 -2
Cleanup assertTrue() and addToAssertionCount() in testsmediawiki/extensions/FileImportermaster+15 -29
Make ApiDetailRetrieverTest independend from configurationmediawiki/extensions/FileImportermaster+33 -36
Use PHPUnit's …->willReturn( … ) shortcut everywheremediawiki/extensions/FileImportermaster+25 -25
Reduce duplicate code in ApiDetailRetrieverTestmediawiki/extensions/FileImportermaster+69 -59
Improve code coverage of APIDetailRetrievermediawiki/extensions/FileImportermaster+182 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Lea_WMDE created this task.Mar 27 2018, 3:16 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptMar 27 2018, 3:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Lea_WMDE triaged this task as Medium priority.Mar 27 2018, 3:20 PM
• Lea_WMDE updated the task description. (Show Details)
• Lea_WMDE set the point value for this task to 5.
• Lea_WMDE moved this task from Tickets in preparation/investigation to Tickets ready for pickup on the Move-Files-To-Commons board.
thiemowmde mentioned this in T190290: Reach a stable test coverage for the FileImporter PHP code.Mar 27 2018, 3:39 PM
Andrew-WMDE claimed this task.Apr 3 2018, 1:10 PM
Andrew-WMDE added a project: WMDE-QWERTY-Sprint-2018-03-20.
Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-03-20 board.
WMDE-Fisch added a project: WMDE-QWERTY-Sprint-2018-04-03.Apr 3 2018, 2:53 PM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-04-03 board.
gerritbot subscribed.Apr 3 2018, 3:18 PM

Change 423716 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/FileImporter@master] [WIP] Improve code coverage of APIDetailRetriever

https://gerrit.wikimedia.org/r/423716

gerritbot added a project: Patch-For-Review.Apr 3 2018, 3:18 PM
Andrew-WMDE mentioned this in rEFLIf6fa79b9f8a6: [WIP] Improve code coverage of APIDetailRetriever.Apr 3 2018, 3:19 PM
WMDE-Fisch changed the point value for this task from 5 to 2.Apr 3 2018, 3:27 PM
WMDE-Fisch moved this task from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.Apr 3 2018, 3:29 PM
Andrew-WMDE mentioned this in rEFLI0e11cdc94c94: Improve code coverage of APIDetailRetriever.Apr 3 2018, 3:34 PM
Andrew-WMDE mentioned this in rEFLIb1cf72f52ed0: Improve code coverage of APIDetailRetriever.Apr 3 2018, 3:45 PM
Andrew-WMDE mentioned this in rEFLI0ae5d766311a: Improve code coverage of APIDetailRetriever.Apr 3 2018, 3:49 PM
Andrew-WMDE moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2018-04-03 board.Apr 3 2018, 3:56 PM
gerritbot added a comment.Apr 5 2018, 3:09 PM

Change 424330 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Reduce duplicate code in ApiDetailRetrieverTest

https://gerrit.wikimedia.org/r/424330

thiemowmde mentioned this in rEFLI8a4fa6d749c2: Reduce duplicate code in ApiDetailRetrieverTest.Apr 5 2018, 3:10 PM
gerritbot added a comment.Apr 5 2018, 3:14 PM

Change 424332 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Use PHPUnit's …->willReturn( … ) shortcut everywhere

https://gerrit.wikimedia.org/r/424332

thiemowmde mentioned this in rEFLIeffb952e00b9: Use PHPUnit's …->willReturn( … ) shortcut everywhere.Apr 5 2018, 3:15 PM
thiemowmde mentioned this in rEFLIe0d2d0e7d727: Reduce duplicate code in ApiDetailRetrieverTest.Apr 5 2018, 3:21 PM
gerritbot added a comment.Apr 5 2018, 4:11 PM

Change 424347 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Make ApiDetailRetrieverTest independend from configuration

https://gerrit.wikimedia.org/r/424347

gerritbot added a comment.Apr 5 2018, 4:11 PM

Change 424348 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Cleanup assertTrue() and addToAssertionCount() in tests

https://gerrit.wikimedia.org/r/424348

thiemowmde mentioned this in rEFLI3e61607f2d71: Make ApiDetailRetrieverTest independend from configuration.Apr 5 2018, 4:12 PM
thiemowmde mentioned this in rEFLIbc58819cb2d2: Cleanup assertTrue() and addToAssertionCount() in tests.
thiemowmde mentioned this in rEFLIc4a424e8d87e: Use PHPUnit's …->willReturn( … ) shortcut everywhere.Apr 5 2018, 4:16 PM
gerritbot added a comment.Apr 5 2018, 4:28 PM

Change 424351 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Remove not needed pass-by-reference from ApiDetailRetriever

https://gerrit.wikimedia.org/r/424351

thiemowmde mentioned this in rEFLIaf69a5f364d6: Remove not needed pass-by-reference from ApiDetailRetriever.Apr 5 2018, 4:31 PM
thiemowmde mentioned this in rEFLI54281129bbe2: Make ApiDetailRetrieverTest independend from configuration.Apr 5 2018, 4:34 PM
gerritbot added a comment.Apr 5 2018, 4:44 PM

Change 423716 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Improve code coverage of APIDetailRetriever

https://gerrit.wikimedia.org/r/423716

thiemowmde mentioned this in rEFLI6ce65c8bcfe6: Reduce duplicate code in ApiDetailRetrieverTest.Apr 5 2018, 4:53 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Apr 5 2018, 5:00 PM
WMDE-Fisch moved this task from Review to Done on the WMDE-QWERTY-Sprint-2018-04-03 board.Apr 5 2018, 5:12 PM
thiemowmde mentioned this in rEFLI8dd2ac7627e2: Test "continue" params passed by reference in ApiDetailRetriever.Apr 5 2018, 5:37 PM
gerritbot added a comment.Apr 5 2018, 6:00 PM

Change 424367 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Fully test continuation feature in ApiDetailRetriever

https://gerrit.wikimedia.org/r/424367

thiemowmde mentioned this in rEFLId085dc8ff3f3: Fully test continuation feature in ApiDetailRetriever.Apr 5 2018, 6:02 PM
thiemowmde mentioned this in rEFLI04805bcaee83: Reduce duplicate code in ApiDetailRetrieverTest.Apr 6 2018, 1:26 PM
gerritbot added a comment.Apr 9 2018, 8:19 AM

Change 424330 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Reduce duplicate code in ApiDetailRetrieverTest

https://gerrit.wikimedia.org/r/424330

WMDE-Fisch mentioned this in rEFLIf22dd6fbd15f: Use PHPUnit's …->willReturn( … ) shortcut everywhere.Apr 9 2018, 9:03 AM
gerritbot added a comment.Apr 9 2018, 9:13 AM

Change 424332 merged by WMDE-Fisch:
[mediawiki/extensions/FileImporter@master] Use PHPUnit's …->willReturn( … ) shortcut everywhere

https://gerrit.wikimedia.org/r/424332

thiemowmde mentioned this in rEFLI1060550b9c4e: Make ApiDetailRetrieverTest independend from configuration.Apr 10 2018, 9:50 AM
thiemowmde mentioned this in rEFLIa83e472608e8: Cleanup assertTrue() and addToAssertionCount() in tests.
thiemowmde mentioned this in rEFLIa581e700b23b: Test "continue" params passed by reference in ApiDetailRetriever.
thiemowmde mentioned this in rEFLIae18f4a1013b: Fully test continuation feature in ApiDetailRetriever.
gerritbot added a comment.Apr 10 2018, 10:00 AM

Change 424347 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Make ApiDetailRetrieverTest independend from configuration

https://gerrit.wikimedia.org/r/424347

gerritbot added a comment.Apr 10 2018, 10:10 AM

Change 424348 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Cleanup assertTrue() and addToAssertionCount() in tests

https://gerrit.wikimedia.org/r/424348

gerritbot added a comment.Apr 10 2018, 10:10 AM

Change 424351 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Test "continue" params passed by reference in ApiDetailRetriever

https://gerrit.wikimedia.org/r/424351

gerritbot added a comment.Apr 10 2018, 10:24 AM

Change 424367 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Fully test continuation feature in ApiDetailRetriever

https://gerrit.wikimedia.org/r/424367

thiemowmde added a parent task: T190290: Reach a stable test coverage for the FileImporter PHP code.Apr 11 2018, 5:28 PM
WMDE-Fisch closed this task as Resolved.Apr 19 2018, 8:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits