Maniphest T190924

Editing Lexeme: Check permission in APIs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pablo-WMDE
	Mar 28 2018, 11:29 AM

Description

wbeditentity (_should_ be protected already!?)
wbladdform
wbleditformelements
wblremoveform

Should be implemented for all ChangeOps already through repo/includes/ChangeOp/ChangeOpBase.php

Q: on API level or inside the individual ChangeOps/Entity/...?

Details

	Subject	Repo	Branch	Lines +/-
	api errors: assert keys instead of messages	mediawiki/extensions/WikibaseLexeme	master	+52 -46
	Editing Lexeme: Check permission in APIs	mediawiki/extensions/WikibaseLexeme	master	+155 -4

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T194253 Configure the CI job that runs WikibaseLexeme's browser tests against test wikidata
Resolved	Addshore	T168260 Deploy WikibaseLexeme extension on Wikimedia cluster
Resolved	Addshore	T191457 Deploy WikibaseLexeme on www.wikidata.org
Resolved	Addshore	T191458 Deploy WikibaseLexeme on test.wikidata.org
Resolved	Lydia_Pintscher	T168263 WikibaseLexeme functional baseline
Resolved	Lydia_Pintscher	T178916 Enforce user rights on Lexeme pages and its parts
Resolved	Lydia_Pintscher	T189480 Enforce permission checks when editing Lexeme
Resolved	• Pablo-WMDE	T190924 Editing Lexeme: Check permission in APIs

Event Timeline

• Pablo-WMDE triaged this task as Medium priority.Mar 28 2018, 11:29 AM

• Pablo-WMDE created this task.

• Pablo-WMDE updated the task description. (Show Details)Mar 28 2018, 11:33 AM

• Pablo-WMDE removed the point value for this task.Mar 28 2018, 11:36 AM

Lydia_Pintscher moved this task from incoming to other stuff on the Wikidata Lexicographical data board.Apr 3 2018, 7:21 PM

• Pablo-WMDE claimed this task.Apr 4 2018, 10:14 AM

• Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Turtles-18.03.28 board.

• Pablo-WMDE mentioned this in rEWLE8b368857aa72: Editing Lexeme: Check permission in APIs.Apr 4 2018, 3:29 PM

Change 423948 had a related patch set (by Pablo Grass (WMDE)) published:
[mediawiki/extensions/WikibaseLexeme@master] Editing Lexeme: Check permission in APIs

https://gerrit.wikimedia.org/r/423948

gerritbot added a project: Patch-For-Review.Apr 4 2018, 3:43 PM

• Pablo-WMDE removed • Pablo-WMDE as the assignee of this task.Apr 4 2018, 3:53 PM

• Pablo-WMDE moved this task from Doing to Peer Review on the Wikidata-Turtles-18.03.28 board.

Change 423948 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Editing Lexeme: Check permission in APIs

https://gerrit.wikimedia.org/r/423948

• Pablo-WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Turtles-18.03.28 board.Apr 5 2018, 12:47 PM

• Pablo-WMDE mentioned this in rEWLE812594f2a992: api errors: assert keys instead of messages.Apr 6 2018, 7:37 AM

Lydia_Pintscher closed this task as Resolved.Apr 6 2018, 9:36 AM

Lydia_Pintscher assigned this task to • Pablo-WMDE.

Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Turtles-18.03.28 board.

Change 424534 had a related patch set (by Pablo Grass (WMDE)) published:
[mediawiki/extensions/WikibaseLexeme@master] api errors: assert keys instead of messages

https://gerrit.wikimedia.org/r/424534

Change 424534 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] api errors: assert keys instead of messages