⚓ T192000 Create formatters for displaying a form as a statement value

Subject	Repo	Branch	Lines +/-
When linking to form, link to form section (fragment) on the lexeme page	mediawiki/extensions/WikibaseLexeme	master	+37 -45
Factor out NonExistingEntityIdHtmlFormatter	mediawiki/extensions/Wikibase	master	+91 -20
FormId formatters	mediawiki/extensions/WikibaseLexeme	master	+428 -107

Status	Assigned	Task
Open	None	T194253 Configure the CI job that runs WikibaseLexeme's browser tests against test wikidata
Resolved	Lydia_Pintscher	T169708 Wikidata 2017 Q3 goals
Resolved	Lydia_Pintscher	T165588 tasks for lexicographical data support until Wikimania 2017
Resolved	Addshore	T168260 Deploy WikibaseLexeme extension on Wikimedia cluster
Resolved	Addshore	T191457 Deploy WikibaseLexeme on www.wikidata.org
Resolved	Addshore	T191458 Deploy WikibaseLexeme on test.wikidata.org
Resolved	Lydia_Pintscher	T168263 WikibaseLexeme functional baseline
Open	None	T91505 [Epic] Adding new datatypes to Wikidata (tracking)
Resolved	Lydia_Pintscher	T165579 New data type to allow linking to Forms
Resolved	Lydia_Pintscher	T192000 Create formatters for displaying a form as a statement value

WMDE-leszek triaged this task as Medium priority.Apr 11 2018, 4:38 PM

WMDE-leszek created this task.

WMDE-leszek renamed this task from Create a formatter for displaying a form as a statement value to Create formatters for displaying a form as a statement value.Apr 11 2018, 4:54 PM

WMDE-leszek mentioned this in T192002: Adjust definition of the wikibase-form datatype.

Lydia_Pintscher moved this task from incoming to other stuff on the Wikidata Lexicographical data board.Apr 13 2018, 11:02 AM

Has to work with and without $wgArticlePath.

mw.Title.newFromText('Lexeme:L2-F1').getUrl();
// "/mediawiki/index.php?title=Lexeme:L2-F1"
mw.Title.newFromText('Lexeme:L2#F1').getUrl();
// "/mediawiki/index.php?title=Lexeme:L2#F1"

?

It should.

Addshore claimed this task.Apr 18 2018, 2:39 PM

Addshore moved this task from To Do to Doing on the Wikidata-Turtles-Sprint#3 board.

Restricted Application added a project: User-Addshore. · View Herald TranscriptApr 18 2018, 2:40 PM

Addshore updated the task description. (Show Details)Apr 18 2018, 3:09 PM

Addshore moved this task from Unsorted 💣 to Back Burner 🏛️ on the User-Addshore board.

Change 427655 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Factor out NonExistingEntityIdHtmlFormatter

https://gerrit.wikimedia.org/r/427655

gerritbot added a project: Patch-For-Review.Apr 19 2018, 1:23 PM

Change 427409 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] WIP DNM FormId formatters

https://gerrit.wikimedia.org/r/427409

Addshore mentioned this in rEWLE0a241cf97e60: WIP DNM FormId formatters.Apr 19 2018, 1:55 PM

Addshore mentioned this in rEWLEc38b1eb33ba2: FormId formatters.Apr 19 2018, 3:39 PM

Addshore moved this task from Doing to Peer Review on the Wikidata-Turtles-Sprint#3 board.Apr 19 2018, 3:40 PM

Addshore mentioned this in rEWLEce7a991be316: FormId formatters.Apr 19 2018, 3:46 PM

WMDE-leszek mentioned this in rEWLE8a31e9b0ec1b: FormId formatters.Apr 19 2018, 4:47 PM

Addshore mentioned this in rEWLEfc81b9cc012a: FormId formatters.Apr 20 2018, 9:12 AM

WMDE-leszek mentioned this in rEWLE1723e8ddd8bb: FormId formatters.Apr 20 2018, 9:24 AM

WMDE-leszek mentioned this in rEWLE300dee259321: FormId formatters.Apr 20 2018, 9:37 AM

Addshore mentioned this in rEWLE12a1f825622b: FormId formatters.Apr 20 2018, 9:58 AM

Addshore mentioned this in rEWLE5a3fdc05e8a0: FormId formatters.Apr 20 2018, 10:09 AM

Addshore mentioned this in rEWLE41dd8c5efa4d: FormId formatters.Apr 20 2018, 10:19 AM

Addshore mentioned this in rEWLEc47bb2623828: FormId formatters.Apr 20 2018, 10:36 AM

Addshore mentioned this in rEWLE9e58f4757fa7: FormId formatters.Apr 20 2018, 10:45 AM

Addshore mentioned this in rEWLEeb94b10f8e76: FormId formatters.Apr 20 2018, 11:22 AM

Addshore mentioned this in rEWLE03b8efce852f: FormId formatters.Apr 20 2018, 11:26 AM

WMDE-leszek mentioned this in rEWLE19f6609200df: FormId formatters.Apr 20 2018, 11:52 AM

Change 427895 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] When linking to form, link to form section (fragment) on the lexeme page

https://gerrit.wikimedia.org/r/427895

WMDE-leszek mentioned this in rEWLEea8506d8c5a7: When linking to form, link to form section (fragment) on the lexeme page.Apr 20 2018, 12:20 PM

Change 427655 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Factor out NonExistingEntityIdHtmlFormatter

https://gerrit.wikimedia.org/r/427655

Change 427409 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] FormId formatters

https://gerrit.wikimedia.org/r/427409

I believe the requirement mention above by @Pablo-WMDE

Has to work with and without $wgArticlePath.

is actually considered here, isn't it? Not sure if I checked all what's possible, but links to forms seem to be created correctly according to wiki settings. I might be mistaken though.

Addshore moved this task from Peer Review to Test (Product Review) on the Wikidata-Turtles-Sprint#3 board.Apr 20 2018, 12:56 PM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).Apr 20 2018, 1:00 PM

Change 427895 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] When linking to form, link to form section (fragment) on the lexeme page

https://gerrit.wikimedia.org/r/427895

Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Apr 23 2018, 7:15 AM

It looks fine on the Form-level but I'm not marking this as accepted yet because of T192766.

WMDE-leszek added a project: Wikidata-Turtles-Sprint#4.Apr 25 2018, 10:03 AM

WMDE-leszek moved this task from To Do to Doing on the Wikidata-Turtles-Sprint#4 board.

WMDE-leszek moved this task from Doing to To Do on the Wikidata-Turtles-Sprint#4 board.

Problem with statement on property is tracked as T192766. If there is any other issue, could you please @Lydia_Pintscher describe it at least here as a comment, so we know it?