Maniphest T192296

The Cancel Button should return the user to the original file page
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Motivation
Special:ImportFile has an "import" button, and a "cancel" button. Right now, when clicking the cancel button, nothing happens. However, when clicking on cancel, users should be redirected to the file page they came from, to offer a "safe" way of canceling the import. Just closing the tab might make some people uncomfortable, since they would not know that nothing has changed in the background yet.

Task

When users click on "Cancel", they are redirected to the page they orginally come from.

Details

	Subject	Repo	Branch	Lines +/-
	Cancel button redirects back to the file's original wiki	mediawiki/extensions/FileImporter	master	+3 -2

Customize query in gerrit

Related Objects

Mentioned In: rEFLIc3964104027e: Cancel button redirects back to the file's original wiki
rEFLI84af2ec15d50: Cancel button redirects back to the file's original wiki

Event Timeline

• MichaelSchoenitzer_WMDE created this task.Apr 16 2018, 3:04 PM

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptApr 16 2018, 3:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I guess you mean on Special:ImportFile ?

Addshore renamed this task from The Cancel-Button doesn't do anything to The Cancel Button doesn't do anything.Apr 16 2018, 3:15 PM

Addshore updated the task description. (Show Details)

I guess you mean on Special:ImportFile ?

Yes, my bad.

Lea_WMDE moved this task from Backlog to Tickets in preparation/investigation on the Move-Files-To-Commons board.Apr 17 2018, 3:01 PM

@Hanna_Petruschat_WMDE should the cancel button be removed, and if not, what exactly should happen if it is clicked?

Restricted Application added a project: Design. · View Herald TranscriptApr 17 2018, 3:18 PM

I'm not certain on which page exactly you are right now. I assume you mean the "Cancel" button below the edit summary next to the "Import file" button? Then this "Cancel" button should end the importing process and presumingly bring the user back to where she/he start (back to the original file). If this is not what you meant I'd ask for a screenshot for clarification.

Lea_WMDE set the point value for this task to 1.Apr 24 2018, 2:08 PM

Lea_WMDE renamed this task from The Cancel Button doesn't do anything to The Cancel Button should return the user to the original file page.Apr 25 2018, 1:10 PM

Lea_WMDE triaged this task as Medium priority.

Lea_WMDE updated the task description. (Show Details)

Lea_WMDE moved this task from Tickets in preparation/investigation to Tickets ready for pickup on the Move-Files-To-Commons board.Apr 25 2018, 1:31 PM

Tobi_WMDE_SW added a project: WMDE-QWERTY-Sprint-2018-05-02.May 2 2018, 2:48 PM

Tobi_WMDE_SW moved this task from Tickets ready for pickup to Tickets in sprint on the Move-Files-To-Commons board.

Charlie_WMDE edited projects, added WMDE-Design (WMDE-Design-Workboard Doing); removed WMDE-Design.May 7 2018, 3:12 PM

Andrew-WMDE claimed this task.May 9 2018, 10:18 AM

Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-05-02 board.

Change 432057 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/FileImporter@master] Cancel button redirects back to the file's original wiki

https://gerrit.wikimedia.org/r/432057

gerritbot added a project: Patch-For-Review.May 9 2018, 10:34 AM

Andrew-WMDE mentioned this in rEFLI84af2ec15d50: Cancel button redirects back to the file's original wiki.May 9 2018, 10:38 AM

Andrew-WMDE mentioned this in rEFLIc3964104027e: Cancel button redirects back to the file's original wiki.May 9 2018, 10:45 AM

WMDE-Fisch moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2018-05-02 board.May 9 2018, 10:51 AM

Change 432057 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Cancel button redirects back to the file's original wiki

https://gerrit.wikimedia.org/r/432057

Tobi_WMDE_SW moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2018-05-02 board.May 9 2018, 11:17 AM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)).May 9 2018, 12:00 PM

Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2018-05-02 board.May 11 2018, 12:17 PM

thiemowmde moved this task from Incoming to Move files to Commons on the TCB-Team (now WMDE-TechWish) board.May 11 2018, 5:06 PM

Lea_WMDE closed this task as Resolved.May 16 2018, 10:30 AM