Page MenuHomePhabricator

Regression: OOUI checkboxes collapsing
Closed, InvalidPublic

Description

NOTE: I have a feeling this is something wrong with my local installation, and that this isn't a real regression

I am not sure how I didn't notice this earlier, but since rMWbf56ea38746c: Update OOUI to v0.26.3 checkboxes have been collapsing into a single line, for example in Special:PagesWithProp:

BeforeAfter
Screen Shot 2018-04-23 at 9.47.19 AM.png (708×2 px, 92 KB)
Screen Shot 2018-04-23 at 9.47.51 AM.png (692×2 px, 91 KB)

I see this on Chrome 65 and Firefox 59 on MacOS 10.12.6.

Event Timeline

I have experienced this as well, and fixed it by running composer update.

Thanks @Mainframe98!


I am confused, do we use the oojs-ui from vendor/ or the one in resources/lib?

Both...

The php part is provided via composer, since it is not listed in autoload.php. (And PhpStorm doesn't complain about duplicate definitions)
The JavaScript and stylesheets are, according to Resources.php, provided via resources/lib. There are no PHP files in there, so those are provided using composer. Perhaps that is because vendor/ doesn't need to be web-accessible this way?

For documentation reasons, a snip of IRC conversation with @matmarex yesterday:

<MatmaRex> Volker_E: that would only happen if you had OOUI PHP code v0.26.2 (before checkbox changes), but OOUI CSS code v0.26.3 (after)
<MatmaRex> i saw that kind of thing when testing on my own test wiki
[…]
<MatmaRex> it could potentially occur if the HTML generated by old OOUI was cached somewhere, but it shouldn't be cached on special pages, as far as i know

From that IRC conversation, @Etonkovidova apparently saw this issue in production for a moment. At first I couldn't believe that ;) , but it was in fact probably visible for about 5 minutes after 2018-04-19 22:30 UTC (last Thursday), when we reverted from wmf.30 to wmf.29 (and thus OOUI v0.26.3 to v0.26.2). I wrote up some more details on T192951#4155800. But the short version is that it was a temporary deployment issue and shouldn't occur again.