Page MenuHomePhabricator

CX2: Section highlights have unbalanced padding
Closed, ResolvedPublic

Description

Paragraph highlight should have some room around the text to avoid the text start to touch the highlight edge, and such room should be balanced (e.g. avoiding to extend too much at the bottom of the paragraph as shown below).


The reason behind this is that paragraphs only have bottom margin.

CX1CX2

Event Timeline

Pginer-WMF triaged this task as Normal priority.Apr 25 2018, 1:14 PM
Pginer-WMF moved this task from Backlog to Priority backlog on the Language-2018-Apr-June board.

Change 429531 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] CX2: Balance section padding

https://gerrit.wikimedia.org/r/429531

Change 429531 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CX2: Balance section padding

https://gerrit.wikimedia.org/r/429531

@Etonkovidova patch for this ticket changed the sizes of sections, so alignment needs to be monitored and made sure nothing is broken.

I haven't yet encountered misalignment after the patch is merged, but be extra cautious when checking this.

Checked in cx2-testing - seems to be fine.
@Petar.petkovic
Comparing to cx-testing I saw only one issue - the highlight around template-based tables used to be a border-like outline:


In cx2 - the highlight goes well beyond the table boundaries:

However, I think it's quite acceptable to have the highlight as it is now. Waiting for your feedback to close the ticket.

Checked in cx2-testing - seems to be fine.
@Petar.petkovic
Comparing to cx-testing I saw only one issue - the highlight around template-based tables used to be a border-like outline:


In cx2 - the highlight goes well beyond the table boundaries:

However, I think it's quite acceptable to have the highlight as it is now. Waiting for your feedback to close the ticket.

Not only tables, but many elements have less compact highlight area compared to CX1. I have filed a ticket to address that difference (T191127), which was declined, so CX2 highlight behavior is preferable.

Etonkovidova closed this task as Resolved.May 5 2018, 12:57 AM

Thx, @Petar.petkovic for clarification. Closing the ticket as Resolved.