Page MenuHomePhabricator
Create Task
Maniphest T193260

Codemirror makes text align left when editing in 2017 WTE on RTL wikis
Closed, ResolvedPublic
Actions

Description

This came up during my testing when we allowed syntax highlighting as a beta feature on RTL wikis. It appears that in Safari, the text aligns left when Codemirror is turned on.

CM safari bug.m4v2 MBDownload

Bizarre.

Related Objects

Event Timeline

Niharika created this task.Apr 27 2018, 6:03 PM
Restricted Application added projects: VisualEditor, Community-Tech. · View Herald TranscriptApr 27 2018, 6:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders subscribed.Apr 28 2018, 9:32 AM

This was fixed in https://gerrit.wikimedia.org/r/#/c/426951/, which I tagged against T191923, and merged 3 days ago. You should either backport that patch, or wait until Tuesday next before enabling CM on RTL wikis.

Esanders renamed this task from Codemirror makes text align left when editing in 2017 WE on RTL wikis to Codemirror makes text align left when editing in 2017 WTE on RTL wikis.Apr 29 2018, 9:50 PM
Esanders merged a task: T193288: Ctrl+Shift+X is ignored when using Syntax Highlighting on 2017 wikitext editor.Apr 30 2018, 9:59 AM
Esanders added a subscriber: Guycn2.
Niharika closed this task as Resolved.Apr 30 2018, 7:21 PM
Niharika assigned this task to Esanders.
Niharika moved this task from New & TBD Tickets to Archive on the Community-Tech board.

Patch backported as part of the morning SWAT today. It works great. Thanks Ed.

@Guycn2 The problem should be fixed now. Feel free to reopen this task if not.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 30 2018, 7:21 PM
Guycn2 added a comment.Apr 30 2018, 7:37 PM
In T193260#4169175, @Niharika wrote:

Patch backported as part of the morning SWAT today. It works great. Thanks Ed.

@Guycn2 The problem should be fixed now. Feel free to reopen this task if not.

Great! Thanks a lot for everyone who made this work.

Jdforrester-WMF edited projects, added VisualEditor (Current work); removed VisualEditor.Apr 30 2018, 7:57 PM
Jdforrester-WMF moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.
Liuxinyu970226 moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.May 5 2018, 12:25 AM
• Vvjjkkii renamed this task from Codemirror makes text align left when editing in 2017 WTE on RTL wikis to z2daaaaaaa.Jul 1 2018, 1:13 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Esanders as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
Ryasmeen renamed this task from z2daaaaaaa to Codemirror makes text align left when editing in 2017 WTE on RTL wikis.Jul 1 2018, 5:03 AM
Ryasmeen closed this task as Resolved.
Ryasmeen assigned this task to Esanders.
Ryasmeen removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a subscriber: Aklapper.
CommunityTechBot raised the priority of this task from High to Needs Triage.Jul 5 2018, 6:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL