Maniphest T193520

[Bug] Table of contents duplicating ids, breaking hash behaviour
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	May 1 2018, 6:27 PM

Description

Steps to Reproduce

Visit https://en.m.wikipedia.org/wiki/Ulaanbaatar#Names_and_etymology
Click Names and etymology

Expected Results

Taken to "Names and etymology" section

Actual Results

Taken to link in table of contents

Environments Observed

Chrome

Testing Environment for QA

beta cluster

Browser Version

OS Version

Device Model

Device Language

Developer notes

Inspecting the table of contents HTML the toc item is rendered like so:

<li>
       <a href="#Names_and_etymology"><span id="Names_and_etymology"></span>Names and etymology</a>
       <ul>
       </ul>
</li>

Expected - the span id should not be present.
Should be possible to create a QUnit test to check for this and make sure HTML with ids is not printed in the table of contents.

Related Objects

Mentioned In: T189688: On long infoboxes, section 1 is pushed down page despite space available
Mentioned Here: T193926: On iPhone (TBC) section linking to other pages do not work properly

Event Timeline

Jdlrobson created this task.May 1 2018, 6:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2018, 6:27 PM

Jdlrobson mentioned this in T189688: On long infoboxes, section 1 is pushed down page despite space available.May 1 2018, 6:44 PM

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.May 1 2018, 7:13 PM

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.May 7 2018, 8:10 PM

It sounds like the causes are different but T193926 is topically similar.

• Niedzielski added a project: MobileFrontend.May 9 2018, 1:12 PM

@Niedzielski indeed. The table of contents shouldn't render in mobile, but if for any reason it does, yes it might make it ambiguous to where to scroll to. However, this one is clear - the HTML is rendered twice. Something similar may be happening in T193926 but would likely be a different code path.

The heading wikitext contains an anchor with the same text as the title which is breaking the mobile TOC.

=={{anchor|Names and etymology}}Names and etymology==

The template is quite widely used: https://en.m.wikipedia.org/wiki/Template:Anchor but this seems to be an inappropriate use of this template as it results in invalid HTML (multiple IDs)

• Vvjjkkii renamed this task from [Bug] Table of contents duplicating ids, breaking hash behaviour to rvdaaaaaaa.Jul 1 2018, 1:12 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii removed a subscriber: Aklapper.

Daimona merged a task: T196538: Section links not always working from mobile.Jul 1 2018, 12:08 PM

Daimona added subscribers: Daimona, Aklapper.

Vachovec1 renamed this task from rvdaaaaaaa to [Bug] Table of contents duplicating ids, breaking hash behaviour.Jul 1 2018, 6:11 PM

Vachovec1 closed this task as Invalid.

Vachovec1 lowered the priority of this task from High to Medium.

Vachovec1 updated the task description. (Show Details)

• Petar.petkovic removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.Jul 8 2018, 8:00 PM

[Bug] Table of contents duplicating ids, breaking hash behaviourClosed, InvalidPublicActions