Page MenuHomePhabricator
Create Task
Maniphest T193603

[UI] Change title of the field of a lemma language
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When editing a lexeme, there's a field "language". The value expected here is a language code. As a shortfix to make it more understandable for the users, I'd like to have this field named "Language code" instead.

Screenshot from 2018-05-02 09-52-27.png (258×838 px, 13 KB)

Details

SubjectRepoBranchLines +/-
Don't refer to the spelling variant as "language"mediawiki/extensions/WikibaseLexemewmf/1.32.0-wmf.5+4 -4
Don't refer to the spelling variant as "language"mediawiki/extensions/WikibaseLexemewmf/1.32.0-wmf.4+4 -4
Don't refer to the spelling variant as "language"mediawiki/extensions/WikibaseLexememaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

Lea_Lacroix_WMDE created this task.May 2 2018, 7:54 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptMay 2 2018, 7:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lea_Lacroix_WMDE added a subscriber: Lydia_Pintscher.May 2 2018, 7:55 AM
Lydia_Pintscher moved this task from incoming to features/bugs for next release (editor experience improvements) on the Wikidata Lexicographical data board.May 8 2018, 12:44 PM
WMDE-leszek renamed this task from [UI] Change title of the field of a Lexeme language to [UI] Change title of the field of a lemma language.May 8 2018, 1:09 PM
WMDE-leszek set the point value for this task to 1.
Lydia_Pintscher added a subscriber: daniel.May 23 2018, 12:31 PM

@daniel

daniel added a comment.May 23 2018, 12:36 PM

That field should be called "variant" or "spelling", it should not make any reference to "language".

For the reference, the message key is wikibaselexeme-form-field-language-label

gerritbot subscribed.May 23 2018, 12:54 PM

Change 434686 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/WikibaseLexeme@master] Don't refer to the spelling variant as "language"

https://gerrit.wikimedia.org/r/434686

gerritbot added a project: Patch-For-Review.May 23 2018, 12:54 PM
daniel mentioned this in rEWLEaf88730fca78: Don't refer to the spelling variant as "language".May 23 2018, 12:55 PM
daniel mentioned this in rEWLE4cab70c2df24: Don't refer to the spelling variant as "language".May 23 2018, 1:03 PM
gerritbot added a comment.May 23 2018, 1:13 PM

Change 434690 had a related patch set uploaded (by Addshore; owner: Daniel Kinzler):
[mediawiki/extensions/WikibaseLexeme@wmf/1.32.0-wmf.4] Don't refer to the spelling variant as "language"

https://gerrit.wikimedia.org/r/434690

gerritbot added a comment.May 23 2018, 1:14 PM

Change 434691 had a related patch set uploaded (by Addshore; owner: Daniel Kinzler):
[mediawiki/extensions/WikibaseLexeme@wmf/1.32.0-wmf.5] Don't refer to the spelling variant as "language"

https://gerrit.wikimedia.org/r/434691

Addshore mentioned this in rEWLEc55fd2afe6a6: Don't refer to the spelling variant as "language".May 23 2018, 1:14 PM
Addshore mentioned this in rEWLE1dc063789f80: Don't refer to the spelling variant as "language".
gerritbot added a comment.May 23 2018, 1:32 PM

Change 434686 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Don't refer to the spelling variant as "language"

https://gerrit.wikimedia.org/r/434686

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 23 2018, 2:01 PM
gerritbot added a comment.May 23 2018, 2:24 PM

Change 434690 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@wmf/1.32.0-wmf.4] Don't refer to the spelling variant as "language"

https://gerrit.wikimedia.org/r/434690

gerritbot added a comment.May 23 2018, 2:24 PM

Change 434691 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@wmf/1.32.0-wmf.5] Don't refer to the spelling variant as "language"

https://gerrit.wikimedia.org/r/434691

Stashbot subscribed.May 23 2018, 2:28 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-23T14:28:18Z] <addshore@tin> Started scap: WikibaseLexeme: Do not refer to the spelling variant as language, T193603, [[gerrit:434691|Patch 1]], [[gerrit:434690|Patch 2]]

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)); removed MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 23 2018, 3:00 PM
Stashbot added a comment.May 23 2018, 4:11 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-23T16:11:56Z] <addshore@tin> Finished scap: WikibaseLexeme: Do not refer to the spelling variant as language, T193603, [[gerrit:434691|Patch 1]], [[gerrit:434690|Patch 2]] (duration: 103m 38s)

Lydia_Pintscher closed this task as Resolved.May 24 2018, 8:49 AM
Lydia_Pintscher claimed this task.
• Vvjjkkii renamed this task from [UI] Change title of the field of a lemma language to gtdaaaaaaa.Jul 1 2018, 1:12 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Lydia_Pintscher as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from gtdaaaaaaa to [UI] Change title of the field of a lemma language.Jul 1 2018, 9:24 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Lydia_Pintscher.
CommunityTechBot set the point value for this task to 1.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
CommunityTechBot raised the priority of this task from High to Needs Triage.Jul 3 2018, 1:57 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL