Page MenuHomePhabricator

VisualEditor removing href attribute on edited refs?
Open, MediumPublic

Description

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.05.07/parsoid?id=AWM7juzOIqXYUKtvalDt&_g=h@44136fa

euwiki/Lankide:Iurre/Proba_orria

TypeError: Cannot read property 'replace' of null
    at Normalizer.moveFormatTagOutsideATag (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:331:49)
    at Normalizer.normalizeNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:433:15)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:604:15)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:552:11)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:601:9)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:552:11)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:601:9)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:552:11)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:601:9)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:552:11)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:601:9)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:561:12)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:601:9)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:561:12)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:601:9)
    at Normalizer.normalizeDOM (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:622:14)

Event Timeline

Arlolra created this task.May 7 2018, 8:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2018, 8:21 PM
ssastry assigned this task to Sbailey.May 7 2018, 8:23 PM
ssastry triaged this task as Medium priority.
Arlolra raised the priority of this task from Medium to High.May 7 2018, 9:07 PM

Change 431673 had a related patch set uploaded (by Sbailey; owner: Sbailey):
[mediawiki/services/parsoid@master] Fix moveFormatToOutsideATag, such that if an A tag without href is encountered, it will no longer crash parsoid, and instead emit a log entry.

https://gerrit.wikimedia.org/r/431673

Change 431673 had a related patch set uploaded (by Sbailey; owner: Sbailey):
[mediawiki/services/parsoid@master] Fix crasher in moveFormatTagOutsideATag

https://gerrit.wikimedia.org/r/431673

Change 431673 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Fix crasher in moveFormatTagOutsideATag

https://gerrit.wikimedia.org/r/431673

Mentioned in SAL (#wikimedia-operations) [2018-05-09T20:21:39Z] <arlolra> Updated Parsoid to 5ce2608 (T194081, T188118)

Here's an example of the new errors you're logging.

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.05.09/parsoid?id=AWNGkki7ZoLyKtr1CL26&_g=h@44136fa

href is missing from a tag
<a style="counter-reset: mw-Ref 3;"><span class="mw-reflink-text">[3]</span></a>

Is this actionable? Or should be reclassified as info?

ssastry moved this task from Needs Triage to html2wt on the Parsoid board.May 9 2018, 9:50 PM
ssastry added subscribers: Esanders, ssastry.

Here's an example of the new errors you're logging.

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.05.09/parsoid?id=AWNGkki7ZoLyKtr1CL26&_g=h@44136fa

href is missing from a tag
<a style="counter-reset: mw-Ref 3;"><span class="mw-reflink-text">[3]</span></a>

Is this actionable? Or should be reclassified as info?

I pinged @Esanders about this on IRC. It is potentially actionable on the VE-end. If not, we can change the severity from error to info.

ssastry renamed this task from Cannot read property 'replace' of null to VisualEditor removing href attribute on edited refs?.May 9 2018, 9:52 PM
ssastry removed Sbailey as the assignee of this task.
ssastry lowered the priority of this task from High to Medium.
ssastry edited projects, added VisualEditor; removed Patch-For-Review.
ssastry moved this task from html2wt to Non-Parsoid Tasks on the Parsoid board.
ssastry added a subscriber: Sbailey.
Vvjjkkii renamed this task from VisualEditor removing href attribute on edited refs? to 6fdaaaaaaa.Jul 1 2018, 1:11 AM
Vvjjkkii raised the priority of this task from Medium to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from 6fdaaaaaaa to VisualEditor removing href attribute on edited refs?.Jul 2 2018, 6:35 AM
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added subscribers: gerritbot, Aklapper.